jolly has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Add missing Pepare Download error handling
......................................................................
Add missing Pepare Download error handling
If Prepare Download on eUICC fails, an error code ist set. Be sure to
check the error code and trigger session cancellation, if set.
Related: SYS#8101
Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
---
M src/ipa/libipa/proc_prfle_dwnld.c
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/src/ipa/libipa/proc_prfle_dwnld.c b/src/ipa/libipa/proc_prfle_dwnld.c
index 2c6893e..ac127a7 100644
--- a/src/ipa/libipa/proc_prfle_dwnld.c
+++ b/src/ipa/libipa/proc_prfle_dwnld.c
@@ -46,10 +46,13 @@
prep_dwnld_res = ipa_es10b_prep_dwnld(ctx, &prep_dwnld_req);
if (!prep_dwnld_res)
goto error;
+ if (prep_dwnld_res->prep_dwnld_err)
+ goto error;
- /* The request may still have failed but we do not have to take any action on this since we forward the
- * result as a whole to the eIM. In case of failure it is the responsibility of the eIM to look at error
- * codes and to react accordingly. */
+ /* In case the ES10b PrepareDownload returns a PrepareDownloadResponseError, the procedure is stopped.
+ * In all other cases we will forward the unmodified result to the eIM to continue the procedure normally.
+ * (see also: GSMA SGP.32, section 3.2.3.2, step 16) */
+
get_bnd_prfle_pkg_req.prep_dwnld_res = prep_dwnld_res->res;
get_bnd_prfle_pkg_res = ipa_esipa_get_bnd_prfle_pkg(ctx, &get_bnd_prfle_pkg_req);
if (!get_bnd_prfle_pkg_res)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
Gerrit-Change-Number: 43302
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
jolly has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Use mandatory transaction ID in AuthenticateClientOkDPEsipa
......................................................................
Use mandatory transaction ID in AuthenticateClientOkDPEsipa
The transaction ID in the sequence of AuthenticateClientOkDPEsipa is
optional, so lets use the mandatory transaction ID from the smdpSigned2
field instead.
If the optional transaction ID exists, check if it matches with the
mandatory one.
Related: SYS#8101
Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
---
M src/ipa/libipa/esipa_auth_clnt.c
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
dexter: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/ipa/libipa/esipa_auth_clnt.c b/src/ipa/libipa/esipa_auth_clnt.c
index 8af59a6..f579dda 100644
--- a/src/ipa/libipa/esipa_auth_clnt.c
+++ b/src/ipa/libipa/esipa_auth_clnt.c
@@ -62,11 +62,21 @@
case AuthenticateClientResponseEsipa_PR_authenticateClientOkDPEsipa:
res->auth_clnt_ok_dpe =
&msg_to_ipa->choice.authenticateClientResponseEsipa.choice.authenticateClientOkDPEsipa;
- res->transaction_id = res->auth_clnt_ok_dpe->transactionId;
+ res->transaction_id = &res->auth_clnt_ok_dpe->smdpSigned2.transactionId;
if (!IPA_ASN_STR_CMP(res->transaction_id, &req->req.transactionId)) {
IPA_LOGP_ESIPA("AuthenticateClient", LERROR,
"eIM responded with unexpected transaction ID (expected: %s, got: %s)\n",
ipa_hexdump(req->req.transactionId.buf, req->req.transactionId.size),
+ ipa_hexdump(res->auth_clnt_ok_dpe->smdpSigned2.transactionId.buf,
+ res->auth_clnt_ok_dpe->smdpSigned2.transactionId.size));
+ res->auth_clnt_err = -1;
+ }
+ if (res->auth_clnt_ok_dpe->transactionId &&
+ !IPA_ASN_STR_CMP(res->transaction_id, res->auth_clnt_ok_dpe->transactionId)) {
+ IPA_LOGP_ESIPA("AuthenticateClient", LERROR,
+ "eIM responded with different transaction IDs (%s != %s)\n",
+ ipa_hexdump(res->auth_clnt_ok_dpe->transactionId->buf,
+ res->auth_clnt_ok_dpe->transactionId->size),
ipa_hexdump(res->transaction_id->buf, res->transaction_id->size));
res->auth_clnt_err = -1;
}
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
Gerrit-Change-Number: 43223
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter, jolly.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43072?usp=email )
Change subject: V1.2: Add eimId to GetEimConfigurationDataRequest
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43072?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia8aacd9d5b8ec7a9d524a446114557efdb0614f5
Gerrit-Change-Number: 43072
Gerrit-PatchSet: 14
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Aug 2026 07:17:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email )
Change subject: Update README.md related to the current command line parameters
......................................................................
Patch Set 3:
(4 comments)
File README.md:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/76b6b606_80d029d2… :
PS2, Line 4: element in the 3GPP IoT eSIM system as described in SGP.31 and SGP.32. It interfaces between the eUICC on one side,
> oops! There is a trailing white space that was already there before...
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/884fa9ac_3b0e0b88… :
PS2, Line 95: * `add-initial-eim <PATH>` specifies the path to an initial eIM configuration file.
> I would move this line to the bottom since we usually pass the operations at the end of the command- […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/e0edffa9_90ce611f… :
PS2, Line 104: During the first run, onomondo-ipa will create an `nvstate.bin` file in its working directory.
> again A whitsepace that has been overlooked. We should remove it with this patch.
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/17c36ef9_d86bcd8f… :
PS2, Line 121: the eidValue from the eUICC and use it to query the eIM for eIM packages. In case no eIM package is available (error
> I would change […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485
Gerrit-Change-Number: 43403
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Aug 2026 07:17:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Add missing Pepare Download error handling
......................................................................
Add missing Pepare Download error handling
If Prepare Download on eUICC fails, an error code ist set. Be sure to
check the error code and trigger session cancellation, if set.
Related: SYS#8101
Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
---
M src/ipa/libipa/proc_prfle_dwnld.c
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/02/43302/6
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
Gerrit-Change-Number: 43302
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Use mandatory transaction ID in AuthenticateClientOkDPEsipa
......................................................................
Use mandatory transaction ID in AuthenticateClientOkDPEsipa
The transaction ID in the sequence of AuthenticateClientOkDPEsipa is
optional, so lets use the mandatory transaction ID from the smdpSigned2
field instead.
If the optional transaction ID exists, check if it matches with the
mandatory one.
Related: SYS#8101
Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
---
M src/ipa/libipa/esipa_auth_clnt.c
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/23/43223/7
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
Gerrit-Change-Number: 43223
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Change remaining ASN1 definition to SGP.32 V1.2
......................................................................
V1.2: Change remaining ASN1 definition to SGP.32 V1.2
These minor changes are not relevant, because they have no impact on
the process of IPAd. Most of them relate to formatting and comments.
Related: SYS#8101
Change-Id: Ifa2546784a6d75170e4f5aae2a5e98edb2c0627a
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/EuiccPackageErrorCode.h
M src/ipa/libasn/EuiccPackageErrorDataSigned.c
M src/ipa/libasn/EuiccPackageErrorDataSigned.h
M src/ipa/libasn/EuiccPackageSigned.c
5 files changed, 87 insertions(+), 40 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/73/43073/13
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ifa2546784a6d75170e4f5aae2a5e98edb2c0627a
Gerrit-Change-Number: 43073
Gerrit-PatchSet: 13
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>