August 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: xua_snm: Trim received Affected PC Mask to configured PC width
by pespin 27 Aug '26

27 Aug '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43418?usp=email ) Change subject: xua_snm: Trim received Affected PC Mask to configured PC width ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie178ff4b9fcbab16ca9d13b96fd689c4a57e8023 Gerrit-Change-Number: 43418 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 08:14:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: Validate Affected PCs follow configured formatting
by osmith 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419?usp=email ) Change subject: xua_snm: Validate Affected PCs follow configured formatting ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: typo in the function name, otherwise LGTM File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419/comment/c77bca68_6ed81… : PS1, Line 70: osmo_ss7_pointocde_is_valid ```suggestion bool osmo_ss7_pointcode_is_valid(const struct osmo_ss7_instance *inst, uint32_t pc); ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4cb19d11e0ca885dd6d717b5fb67be92bc01fd13 Gerrit-Change-Number: 43419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 08:02:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow
by osmith 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43417?usp=email ) Change subject: sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1feabda052dc7a78b7d1d146aeb684e763923f74 Gerrit-Change-Number: 43417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 07:59:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in onomondo-eim[master]: rest_api_response_schema: re-structure REST API responses
by Jenkins Builder 27 Aug '26

27 Aug '26

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email ) Change subject: rest_api_response_schema: re-structure REST API responses ...................................................................... Patch Set 2: (1 comment) File priv/rest_api_response_schema.json: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/43402/comment/3b539613_6f73f260… : PS2, Line 441: "description": "indicates a session cancelation problem, see also GSMA SGP.23, section 5.14.8 (CancelSessionResponse->cancelSessionResponseError)", 'cancelation' may be misspelled - perhaps 'cancellation'? -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I16cc063c185727e1b30f26d656bd15154504b087 Gerrit-Change-Number: 43402 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 07:57:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in onomondo-eim[master]: rest_api_response_schema: re-structure REST API responses
by dexter 27 Aug '26

27 Aug '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: rest_api_response_schema: re-structure REST API responses ...................................................................... rest_api_response_schema: re-structure REST API responses The REST API responses are in parts inconsistent and the schema file lacks proper spec references in the description fields. Also in some places we mix proprietary error codes with return codes from SGP.32, which may lead to unexpected effects in case the SGP.32 ASN.1 spec changes. With this patch we clean up those remaining shortcomings, in particular the following: - Add a spec reference to each non-proprietary field - No longer mix SGP.32 error codes with proprietary error codes - Rename procedureError to eimProcedureError and make sure all possible error codes appear in the JSON schema properly. - Add dedicated error fields for each SGP.32 error code, so that the REST API user gets more detailed information in the error case - Restructure profileInstallationResult also return AID and SimaResponse, also add an profileInstallationError field which returns BppCommandId, ErrorReason and SimaResponse so that a REST API user has a chance to debug profile installation issues. - Orient the layout of result and error responses closer to the SGP.32 ASN.1 specification. - Do not specify the error codes in the JSON schema file to avoid unexpected problems when SGP.32 adds new error code. A spec reference in the field description should be sufficient. Change-Id: I16cc063c185727e1b30f26d656bd15154504b087 Related: SYS#8100 --- M doc/build.md M doc/database.md M priv/rest_api_response_schema.json M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl M src/esipa_asn1_http_handler.erl M src/esipa_json_handler.erl M src/esipa_json_http_handler.erl M src/esipa_rest_utils.erl M src/mnesia_db.erl M src/mnesia_db_euicc.erl M src/mnesia_db_rest.erl M src/mnesia_db_work.erl 13 files changed, 388 insertions(+), 456 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/02/43402/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I16cc063c185727e1b30f26d656bd15154504b087 Gerrit-Change-Number: 43402 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg
by osmith 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43416?usp=email ) Change subject: sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8f9a20b4eff4f4fd76f6c5a7e87ac0afb5921a8b Gerrit-Change-Number: 43416 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 07:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow i...
by osmith 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43415?usp=email ) Change subject: sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow if ptr in tail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibc5da4d03fff9bd83e85945c28dded3608611ab7 Gerrit-Change-Number: 43415 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 07:53:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-ipa[master]: cosmetic: remove trailing whitespaces in copyright notices
by dexter 27 Aug '26

27 Aug '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cosmetic: remove trailing whitespaces in copyright notices ...................................................................... cosmetic: remove trailing whitespaces in copyright notices Related: SYS#8101 Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 --- M src/ipa/libipa/es10b_add_init_eim.c M src/ipa/libipa/es10b_cancel_session.c M src/ipa/libipa/es10b_prep_dwnld.c M src/ipa/libipa/es10c_get_eid.c M src/ipa/libipa/esipa_auth_clnt.c M src/ipa/libipa/esipa_get_bnd_prfle_pkg.c M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c 7 files changed, 7 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ipa/libipa/es10b_add_init_eim.c b/src/ipa/libipa/es10b_add_init_eim.c index c495bff..ba9e3c1 100644 --- a/src/ipa/libipa/es10b_add_init_eim.c +++ b/src/ipa/libipa/es10b_add_init_eim.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, 5.9.4: Function (ES10b): AddInitialEim */ diff --git a/src/ipa/libipa/es10b_cancel_session.c b/src/ipa/libipa/es10b_cancel_session.c index a45d505..83eae79 100644 --- a/src/ipa/libipa/es10b_cancel_session.c +++ b/src/ipa/libipa/es10b_cancel_session.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.22, 5.7.14: Function (ES10b): CancelSession */ diff --git a/src/ipa/libipa/es10b_prep_dwnld.c b/src/ipa/libipa/es10b_prep_dwnld.c index c3c8c68..6617b0a 100644 --- a/src/ipa/libipa/es10b_prep_dwnld.c +++ b/src/ipa/libipa/es10b_prep_dwnld.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.22, section 5.7.5: Function (ES10b): PrepareDownload */ diff --git a/src/ipa/libipa/es10c_get_eid.c b/src/ipa/libipa/es10c_get_eid.c index b002ec0..c5a40e3 100644 --- a/src/ipa/libipa/es10c_get_eid.c +++ b/src/ipa/libipa/es10c_get_eid.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.22, 5.7.20: Function (ES10c): GetEID */ diff --git a/src/ipa/libipa/esipa_auth_clnt.c b/src/ipa/libipa/esipa_auth_clnt.c index 963cfc8..295e2d5 100644 --- a/src/ipa/libipa/esipa_auth_clnt.c +++ b/src/ipa/libipa/esipa_auth_clnt.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, section 5.14.3: Function: (Esipa) AuthenticateClient */ diff --git a/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c b/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c index 79bc98d..8e742a4 100644 --- a/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c +++ b/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, section 5.14.2: Function: (ESipa) GetBoundProfilePackage */ diff --git a/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c b/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c index 03aa1e3..96af767 100644 --- a/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c +++ b/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, section 5.14.6: Function (ESipa): ProvideEimPackageResult */ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 Gerrit-Change-Number: 43414 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in onomondo-ipa[master]: cosmetic: remove trailing whitespaces in copyright notices
by dexter 27 Aug '26

27 Aug '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: remove trailing whitespaces in copyright notices ...................................................................... cosmetic: remove trailing whitespaces in copyright notices Related: SYS#8101 Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 --- M src/ipa/libipa/es10b_add_init_eim.c M src/ipa/libipa/es10b_cancel_session.c M src/ipa/libipa/es10b_prep_dwnld.c M src/ipa/libipa/es10c_get_eid.c M src/ipa/libipa/esipa_auth_clnt.c M src/ipa/libipa/esipa_get_bnd_prfle_pkg.c M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c 7 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/14/43414/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 Gerrit-Change-Number: 43414 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: Trim received Affected PC Mask to configured PC width
by osmith 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43418?usp=email ) Change subject: xua_snm: Trim received Affected PC Mask to configured PC width ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie178ff4b9fcbab16ca9d13b96fd689c4a57e8023 Gerrit-Change-Number: 43418 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 07:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026