August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_part(): Log subpart where parse failed
by pespin 27 Aug '26

27 Aug '26

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43423?usp=email ) Change subject: sua: sua_addr_parse_part(): Log subpart where parse failed ...................................................................... sua: sua_addr_parse_part(): Log subpart where parse failed Change-Id: Id33b74f10cb617d94a404b509240a46f6d11324b --- M src/sua.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/43423/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id33b74f10cb617d94a404b509240a46f6d11324b Gerrit-Change-Number: 43423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_part(): Fix potential read buffer overflow
by pespin 27 Aug '26

27 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43421?usp=email ) Change subject: sua: sua_addr_parse_part(): Fix potential read buffer overflow ...................................................................... sua: sua_addr_parse_part(): Fix potential read buffer overflow The sua_addr_parse_part() function lacked validating that the length value in the TLV struct didn't go past the buffer, which could end up in a read buffer overflow. Related: OS#7079 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I12fbdfc37bfbf6cf9ba18942eb0ec43c9d1349fe --- M src/sua.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/21/43421/1 diff --git a/src/sua.c b/src/sua.c index 3b217f4..0784b61 100644 --- a/src/sua.c +++ b/src/sua.c @@ -830,9 +830,12 @@ par_tag = ntohs(par->tag); par_len = ntohs(par->len); - /* sanity: check par->len received on the wire, make sure the subtraction does not wrap past zero. */ + /* L value must account for at least TL (struct xua_parameter_hdr): */ if (par_len < sizeof(*par)) goto subpar_fail; + /* Avoid reading past buffer: */ + if (pos + par_len > param->len) + goto subpar_fail; par_datalen = par_len - sizeof(*par); LOGP(DLSUA, LOGL_DEBUG, "SUA IEI 0x%04x pos %hu/%hu: subpart tag 0x%04x, len %hu\n", -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12fbdfc37bfbf6cf9ba18942eb0ec43c9d1349fe Gerrit-Change-Number: 43421 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_get(): Propagate failure from sua_parse_gt()
by pespin 27 Aug '26

27 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43422?usp=email ) Change subject: sua: sua_addr_parse_get(): Propagate failure from sua_parse_gt() ...................................................................... sua: sua_addr_parse_get(): Propagate failure from sua_parse_gt() As a result, addresses with > 31 digits would be silently trimmed and accepted. Also, remove the par_datalen check, sua_parse_gt() already takes care of it. Change-Id: Ia9d33d313b272e5b230be68eccb8e14ff739d9a4 --- M src/sua.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/22/43422/1 diff --git a/src/sua.c b/src/sua.c index 0784b61..f3ed921 100644 --- a/src/sua.c +++ b/src/sua.c @@ -857,9 +857,8 @@ out->presence |= OSMO_SCCP_ADDR_T_SSN; break; case SUA_IEI_GT: - if (par_datalen < 8) + if (sua_parse_gt(&out->gt, par->data, par_datalen) < 0) goto subpar_fail; - sua_parse_gt(&out->gt, par->data, par_datalen); out->presence |= OSMO_SCCP_ADDR_T_GT; break; case SUA_IEI_IPv4: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia9d33d313b272e5b230be68eccb8e14ff739d9a4 Gerrit-Change-Number: 43422 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_get(): Log subpart where parse failed
by pespin 27 Aug '26

27 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43423?usp=email ) Change subject: sua: sua_addr_parse_get(): Log subpart where parse failed ...................................................................... sua: sua_addr_parse_get(): Log subpart where parse failed Change-Id: Id33b74f10cb617d94a404b509240a46f6d11324b --- M src/sua.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/43423/1 diff --git a/src/sua.c b/src/sua.c index f3ed921..e14130f 100644 --- a/src/sua.c +++ b/src/sua.c @@ -888,8 +888,8 @@ return 0; subpar_fail: - LOGP(DLSUA, LOGL_ERROR, "Failed to parse subparts of address IEI=0x%04x\n", - param->tag); + LOGP(DLSUA, LOGL_ERROR, "Failed to parse SUA Address IEI=0x%04x (subpart tag 0x%04x, len %hu)\n", + param->tag, par_tag, par_len); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id33b74f10cb617d94a404b509240a46f6d11324b Gerrit-Change-Number: 43423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/README: automatic backtraces for coredumps
by osmith 27 Aug '26

27 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43420?usp=email ) Change subject: testenv/README: automatic backtraces for coredumps ...................................................................... testenv/README: automatic backtraces for coredumps Add documentation for this feature. Change-Id: I9b65bfb14853edb03ddb571867bb795bde9d495c --- M _testenv/README.md 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/README.md b/_testenv/README.md index 710c021..047abc0 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -309,6 +309,19 @@ Switching between the versions is done either by setting a `titan_min` version in `testsrcdir.cfg`, or by using `-T` / `--titan-version`. +## Automatic backtraces for coredumps + +When your SUT crashes with a coredump, testenv automatically runs `gdb` to get +a backtrace, displays it in the output and writes it next to other logs into a +`.backtrace` file. + +For this to work, you either need to have `systemd-coredump` set up, or +alternatively have a core pattern in `/proc/sys/kernel/core_pattern` starting +with `core`. + +Executables that do not start with a relevant prefix (`osmo-` or `open5gs-`) +get ignored, see `testenv.coredump.executable_is_relevant()`. + ## Troubleshooting ### Timeout waiting for RESET-ACK after sending RESET -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b65bfb14853edb03ddb571867bb795bde9d495c Gerrit-Change-Number: 43420 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/README: automatic backtraces for coredumps
by fixeria 27 Aug '26

27 Aug '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43420?usp=email ) Change subject: testenv/README: automatic backtraces for coredumps ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b65bfb14853edb03ddb571867bb795bde9d495c Gerrit-Change-Number: 43420 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 08:32:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in onomondo-eim[master]: rest_api_response_schema: re-structure REST API responses
by dexter 27 Aug '26

27 Aug '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: rest_api_response_schema: re-structure REST API responses ...................................................................... rest_api_response_schema: re-structure REST API responses The REST API responses are in parts inconsistent and the schema file lacks proper spec references in the description fields. Also in some places we mix proprietary error codes with return codes from SGP.32, which may lead to unexpected effects in case the SGP.32 ASN.1 spec changes. With this patch we clean up those remaining shortcomings, in particular the following: - Add a spec reference to each non-proprietary field - No longer mix SGP.32 error codes with proprietary error codes - Rename procedureError to eimProcedureError and make sure all possible error codes appear in the JSON schema properly. - Add dedicated error fields for each SGP.32 error code, so that the REST API user gets more detailed information in the error case - Restructure profileInstallationResult also return AID and SimaResponse, also add an profileInstallationError field which returns BppCommandId, ErrorReason and SimaResponse so that a REST API user has a chance to debug profile installation issues. - Orient the layout of result and error responses closer to the SGP.32 ASN.1 specification. - Do not specify the error codes in the JSON schema file to avoid unexpected problems when SGP.32 adds new error code. A spec reference in the field description should be sufficient. Change-Id: I16cc063c185727e1b30f26d656bd15154504b087 Related: SYS#8100 --- M doc/build.md M doc/database.md M priv/rest_api_response_schema.json M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl M src/esipa_asn1_http_handler.erl M src/esipa_json_handler.erl M src/esipa_json_http_handler.erl M src/esipa_rest_utils.erl M src/mnesia_db.erl M src/mnesia_db_euicc.erl M src/mnesia_db_rest.erl M src/mnesia_db_work.erl 13 files changed, 388 insertions(+), 456 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/02/43402/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I16cc063c185727e1b30f26d656bd15154504b087 Gerrit-Change-Number: 43402 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: Validate Affected PCs follow configured formatting
by pespin 27 Aug '26

27 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419?usp=email ) Change subject: xua_snm: Validate Affected PCs follow configured formatting ...................................................................... xua_snm: Validate Affected PCs follow configured formatting Avoid handling unexpected point codes being out of range regarding the point code formatting configured at the SS/ instance. In the case of DAUD, simply answer stating the unexpected PC is unavailable. Change-Id: I4cb19d11e0ca885dd6d717b5fb67be92bc01fd13 --- M include/osmocom/sigtran/osmo_ss7.h M src/ss7_instance.c M src/xua_snm.c 3 files changed, 41 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 074027f..594cbae 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -67,6 +67,7 @@ int osmo_ss7_find_free_rctx(struct osmo_ss7_instance *inst); bool osmo_ss7_pc_is_local(const struct osmo_ss7_instance *inst, uint32_t pc); +bool osmo_ss7_pointcode_is_valid(const struct osmo_ss7_instance *inst, uint32_t pc); int osmo_ss7_pointcode_parse(const struct osmo_ss7_instance *inst, const char *str); int osmo_ss7_pointcode_parse_mask_or_len(const struct osmo_ss7_instance *inst, const char *in); const char *osmo_ss7_pointcode_print_buf(char *buf, size_t buf_len, const struct osmo_ss7_instance *inst, uint32_t pc); diff --git a/src/ss7_instance.c b/src/ss7_instance.c index b349974..61b0a2c 100644 --- a/src/ss7_instance.c +++ b/src/ss7_instance.c @@ -240,6 +240,16 @@ return false; } +/*! Whether the PC is valid according to SS7 instance point code format configuration + * \param[in] inst SS7 Instance on which we operate + * \param[in] pc Point Code to validate + * \returns true if valid, false if not valid (out of range) + */ +bool osmo_ss7_pointcode_is_valid(const struct osmo_ss7_instance *inst, uint32_t pc) +{ + return !(pc & ~ss7_pc_full_mask(&inst->cfg.pc_fmt)); +} + /* Next RCTX, skipping special value "0" meaning no context. */ static inline uint32_t rctx_inc(uint32_t rctx) { diff --git a/src/xua_snm.c b/src/xua_snm.c index 6befecc..3aa067e 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -161,6 +161,13 @@ uint32_t pc = _aff_pc & 0xffffff; uint8_t mask = mask_from_affected_pc(s7i, _aff_pc); + if (!osmo_ss7_pointcode_is_valid(s7i, pc)) { + LOGSS7(s7i, LOGL_ERROR, + "Ignoring unexpected invalid Affected Point Code pc=%u=%s/%u\n", + pc, osmo_ss7_pointcode_print(s7i, pc), _aff_pc >> 24); + continue; + } + if (!mask) { if (available) mtp_resume_ind_up_to_all_users(s7i, pc); @@ -224,6 +231,13 @@ uint32_t pc = _aff_pc & 0xffffff; uint8_t mask = mask_from_affected_pc(s7i, _aff_pc); + if (!osmo_ss7_pointcode_is_valid(s7i, pc)) { + LOGPAS(as, DLSS7, LOGL_ERROR, + "Ignoring unexpected invalid Affected Point Code pc=%u=%s/%u\n", + pc, osmo_ss7_pointcode_print(s7i, pc), _aff_pc >> 24); + continue; + } + if (!mask) { xua_snm_srm_pc_available_single(as, pc, available); } else { @@ -368,6 +382,13 @@ uint32_t pc = _aff_pc & 0xffffff; uint8_t mask = mask_from_affected_pc(s7i, _aff_pc); + if (!osmo_ss7_pointcode_is_valid(s7i, pc)) { + LOGSS7(s7i, LOGL_ERROR, + "Ignoring unexpected invalid Affected Point Code pc=%u=%s/%u\n", + pc, osmo_ss7_pointcode_print(s7i, pc), _aff_pc >> 24); + continue; + } + if (!mask) { mtp_status_ind_up_to_all_users(s7i, pc, MTP_UNAVAIL_C_CONGESTED, cong_level_present, cong_level); @@ -450,6 +471,15 @@ uint8_t mask = mask_from_affected_pc(s7i, _aff_pc); bool is_available; + if (!osmo_ss7_pointcode_is_valid(s7i, pc)) { + LOGPASP(asp, DLSS7, LOGL_ERROR, + "Rejecting unexpected invalid Affected Point Code pc=%u=%s/%u\n", + pc, osmo_ss7_pointcode_print(s7i, pc), _aff_pc >> 24); + xua_tx_snm_available(asp, rctx, num_rctx, &aff_pc[i], 1, "Response to DAUD", + false); + continue; + } + if (mask == 0) { /* one single point code */ /* Check if there's an "active" route available: */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4cb19d11e0ca885dd6d717b5fb67be92bc01fd13 Gerrit-Change-Number: 43419 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/README: automatic backtraces for coredumps
by pespin 27 Aug '26

27 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43420?usp=email ) Change subject: testenv/README: automatic backtraces for coredumps ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b65bfb14853edb03ddb571867bb795bde9d495c Gerrit-Change-Number: 43420 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 08:19:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: Validate Affected PCs follow configured formatting
by osmith 27 Aug '26

27 Aug '26

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419?usp=email ) Change subject: xua_snm: Validate Affected PCs follow configured formatting ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419/comment/69bc9cc1_ef83e… : PS1, Line 70: osmo_ss7_pointocde_is_valid > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4cb19d11e0ca885dd6d717b5fb67be92bc01fd13 Gerrit-Change-Number: 43419 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 08:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026