Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43429?usp=email )
Change subject: es9p_client: use SGP.32 specific AuthenticateServerResponse type
......................................................................
Patch Set 1:
(1 comment)
File src/es9p_client.erl:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-eim/+/43429/comment/836e2562_91bb9211… :
PS1, Line 227: % The AuthenticateServerResponse type has been re-defined by SGP.32, in particular to accomodate for the SGP.32
'accomodate' may be misspelled - perhaps 'accommodate'?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43429?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ia550804d1d73f9704aa3135819926c7615379d1a
Gerrit-Change-Number: 43429
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 27 Aug 2026 16:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43429?usp=email )
Change subject: es9p_client: use SGP.32 specific AuthenticateServerResponse type
......................................................................
es9p_client: use SGP.32 specific AuthenticateServerResponse type
SGP.32 re-defines the AuthenticateServerResponse type. This is in
particular due to the SGP.32 specific EUICCInfo2 type, which is
contained in this struct. This means we have to use the re-defined
type for encoding. Since the RSPDefinitions have
"EXTENSIBILITY IMPLIED", the extra fields added to EUICCInfo2 are
ignored by the SM-DP+.
Change-Id: Ia550804d1d73f9704aa3135819926c7615379d1a
Related: SYS#8100
---
M src/es9p_client.erl
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/29/43429/1
diff --git a/src/es9p_client.erl b/src/es9p_client.erl
index ac89456..ce51a2e 100644
--- a/src/es9p_client.erl
+++ b/src/es9p_client.erl
@@ -224,9 +224,11 @@
request_json({authenticateClientRequest, AuthClientReq}, BaseUrl) ->
Json = #{
<<"transactionId">> => utils:binary_to_hex(maps:get(transactionId, AuthClientReq)),
+ % The AuthenticateServerResponse type has been re-defined by SGP.32, in particular to accomodate for the SGP.32
+ % specific EUICCInfo2 type (see also SGP.32, section 5.6.1).
<<"authenticateServerResponse">> => enc_asn1_b64(
- 'RSPDefinitions',
- 'AuthenticateServerResponse',
+ 'SGP32Definitions',
+ 'SGP32-AuthenticateServerResponse',
maps:get(authenticateServerResponse, AuthClientReq)
)
},
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43429?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ia550804d1d73f9704aa3135819926c7615379d1a
Gerrit-Change-Number: 43429
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43427?usp=email )
Change subject: proc_prfle_dwnld: Add TODO about missing profileMetadata check
......................................................................
proc_prfle_dwnld: Add TODO about missing profileMetadata check
Related: SYS#8100
Change-Id: I99aae5efa7f3ec16315d53dd3aaa67692d918672
---
M src/ipa/libipa/proc_prfle_dwnld.c
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/27/43427/1
diff --git a/src/ipa/libipa/proc_prfle_dwnld.c b/src/ipa/libipa/proc_prfle_dwnld.c
index e753408..c30442c 100644
--- a/src/ipa/libipa/proc_prfle_dwnld.c
+++ b/src/ipa/libipa/proc_prfle_dwnld.c
@@ -62,6 +62,15 @@
else if (!get_bnd_prfle_pkg_res->get_bnd_prfle_pkg_ok)
goto error;
+ /* TODO: SGP.32, section 3.2.3.2, step 19 requires us to compare the SGP32_StoreMetadataRequest from
+ pars->auth_clnt_ok_dpe->profileMetaData (optional field) against the SGP32_StoreMetadataRequest from
+ the ES8+ StoreMetadata (see SGP.22, section 5.5.3) function call in the BoundProfilePackage we have
+ just received.
+
+ The ES8+ StoreMetadata function call is not encrypted, so we can decode it and extract the
+ SGP32_StoreMetadataRequest contents from it. Then we can do the comparison. In case a mismatch is
+ detected, the session should be cancelled (metadataMismatch) */
+
/* In case of error it is the responsibility of the caller to call the Common Cancel Session procedure.
* In case of success, the caller should ask the user for consent before continuing with the profile
* installation. */
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43427?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I99aae5efa7f3ec16315d53dd3aaa67692d918672
Gerrit-Change-Number: 43427
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: smf: Implement PFCP Sess Est and Sess Del procedures
......................................................................
smf: Implement PFCP Sess Est and Sess Del procedures
With these in place, the following tests now pass:
TC_createSession_deleteSession
f_TC_deleteSession_unknown
TC_s2b_createSession_v4_noapco
TC_s2b_createSession_v4_apco
Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
---
M library/PFCP_Templates.ttcn
M smf/SMF_Session_CT.ttcn
M smf/SMF_Tests.cfg
M smf/SMF_Tests.ttcn
M smf/expected-results.xml
M smf/gen_links.sh
6 files changed, 367 insertions(+), 26 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/43378/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
Gerrit-Change-Number: 43378
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: smf: Implement PFCP Sess Est and Sess Del procedures
......................................................................
smf: Implement PFCP Sess Est and Sess Del procedures
With these in place, the following tests now pass:
TC_createSession_deleteSession
f_TC_deleteSession_unknown
TC_s2b_createSession_v4_noapco
TC_s2b_createSession_v4_apco
Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
---
M library/PFCP_Templates.ttcn
M smf/SMF_Session_CT.ttcn
M smf/SMF_Tests.cfg
M smf/SMF_Tests.ttcn
M smf/expected-results.xml
M smf/gen_links.sh
6 files changed, 367 insertions(+), 26 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/43378/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
Gerrit-Change-Number: 43378
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
pespin has uploaded a new patch set (#4). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email )
Change subject: smf: Implement PFCP Sess Est and Sess Del procedures
......................................................................
smf: Implement PFCP Sess Est and Sess Del procedures
With these in place, the following tests now pass:
TC_createSession_deleteSession
TC_s2b_createSession_v4_noapco
TC_s2b_createSession_v4_apco
Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
---
M library/PFCP_Templates.ttcn
M smf/SMF_Session_CT.ttcn
M smf/SMF_Tests.cfg
M smf/SMF_Tests.ttcn
M smf/expected-results.xml
M smf/gen_links.sh
6 files changed, 363 insertions(+), 25 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/43378/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
Gerrit-Change-Number: 43378
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>