August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-hnodeb[master]: Bump version: 0.2.1.1-5433 → 0.2.2
by pespin 20 Aug '26

20 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/43334?usp=email ) Change subject: Bump version: 0.2.1.1-5433 → 0.2.2 ...................................................................... Bump version: 0.2.1.1-5433 → 0.2.2 Change-Id: Ibfdd0e2466be9066b1d591dd0ead8bed8b70af34 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/34/43334/1 diff --git a/debian/changelog b/debian/changelog index d9bcb83..535eae1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-hnodeb (0.2.2) unstable; urgency=medium + + * rtp: fail if IuUP instance is not created + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Thu, 20 Aug 2026 14:01:27 +0200 + osmo-hnodeb (0.2.1) unstable; urgency=medium [ Oliver Smith ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/43334?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ibfdd0e2466be9066b1d591dd0ead8bed8b70af34 Gerrit-Change-Number: 43334 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by daniel 20 Aug '26

20 Aug '26

Attention is currently required from: daniel. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... sigtran-osmocom.adoc: Describe tcap-aware loadshare Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Related: OS#5423 --- M common/chapters/sigtran-osmocom.adoc 1 file changed, 100 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/90/42190/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: typo 'concetenation' in personalization.py
by fixeria 20 Aug '26

20 Aug '26

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43289?usp=email ) Change subject: typo 'concetenation' in personalization.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I51345db014335e8a70a7437a9cad5a3e47570a95 Gerrit-Change-Number: 43289 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 11:52:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: test_configurable_parameters: test less templates
by fixeria 20 Aug '26

20 Aug '26

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43288?usp=email ) Change subject: test_configurable_parameters: test less templates ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Commit message lacks the motivation. I guess because it's slow? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67 Gerrit-Change-Number: 43288 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 11:52:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: saip BatchPersonalization: call rebuild_mandatory_services()
by fixeria 20 Aug '26

20 Aug '26

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43287?usp=email ) Change subject: saip BatchPersonalization: call rebuild_mandatory_services() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f Gerrit-Change-Number: 43287 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 11:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: Revert "jobs: run ttcn3-remsim-test-asan with bookworm"
by osmith 20 Aug '26

20 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43311?usp=email ) Change subject: Revert "jobs: run ttcn3-remsim-test-asan with bookworm" ...................................................................... Revert "jobs: run ttcn3-remsim-test-asan with bookworm" I just verified that it works with trixie now. This reverts commit ffef33c677f7bf9c76a99a6dfa7ab7eb29a49c23. Closes: OS#6845 Change-Id: I399a0247fa8e76e98618da449fc0d9e584dc846b --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 944a92c..c75f7b8 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -568,8 +568,7 @@ - ttcn3-remsim-test-asan: # ~6 min testsuite: remsim - # "-d debian:bookworm": OS#6845 - args: -b osmocom:nightly:asan -c all -d debian:bookworm + args: -b osmocom:nightly:asan -c all timer: H 17 * * * - ttcn3-sccp-test-asan: # ~2 min @@ -637,11 +636,11 @@ which-build: last-successful stable: true - shell: |- + DISTRO="debian:trixie" + IMAGE="registry.osmocom.org/osmocom-build/"$(echo "$DISTRO" | tr : -)"-osmo-ttcn3-testenv" KERNEL="{kernel}" - for debver in trixie bookworm; do - podman pull registry.osmocom.org/osmocom-build/debian-"$debver"-osmo-ttcn3-testenv - done + podman pull "$IMAGE" # Clean up leftover apt partial directories, which the host system # user can't remove directly -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I399a0247fa8e76e98618da449fc0d9e584dc846b Gerrit-Change-Number: 43311 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: various small syntax tweaks
by osmith 20 Aug '26

20 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email ) Change subject: testenv: various small syntax tweaks ...................................................................... testenv: various small syntax tweaks Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3 --- M .ruff.toml M _testenv/testenv.py M _testenv/testenv/__init__.py M _testenv/testenv/podman.py M _testenv/testenv/testenv_cfg.py M _testenv/testenv/testsuite.py 6 files changed, 11 insertions(+), 21 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/.ruff.toml b/.ruff.toml index d8fc4db..ff68e24 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -10,14 +10,9 @@ "DTZ004", # https://docs.astral.sh/ruff/rules/call-datetime-utcfromtimestamp/ "DTZ005", # https://docs.astral.sh/ruff/rules/call-datetime-now-without-tzinfo/ "DTZ007", # https://docs.astral.sh/ruff/rules/call-datetime-strptime-without-zone/ - "FURB105", # https://docs.astral.sh/ruff/rules/print-empty-string/ "I001", # https://docs.astral.sh/ruff/rules/unsorted-imports/ "LOG015", # https://docs.astral.sh/ruff/rules/root-logger-call/ - "PIE808", # https://docs.astral.sh/ruff/rules/unnecessary-range-start/ "PLC0206", # https://docs.astral.sh/ruff/rules/dict-index-missing-items/ "PLW0602", # https://docs.astral.sh/ruff/rules/global-variable-not-assigned/ "RUF012", # https://docs.astral.sh/ruff/rules/mutable-class-default/ - "SIM102", # https://docs.astral.sh/ruff/rules/collapsible-if/ - "SIM103", # https://docs.astral.sh/ruff/rules/needless-bool/ - "SIM118", # https://docs.astral.sh/ruff/rules/in-dict-keys/ ] diff --git a/_testenv/testenv.py b/_testenv/testenv.py index 29bf56e..01f6d95 100755 --- a/_testenv/testenv.py +++ b/_testenv/testenv.py @@ -138,7 +138,7 @@ testenv.podman.stop() sys.exit(2) except KeyboardInterrupt: - print("") # new line + print() # new line test = testenv.testsuite.get_current_test() if test: logging.critical(f"^C during {test}") diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py index ed302ab..5a24c10 100644 --- a/_testenv/testenv/__init__.py +++ b/_testenv/testenv/__init__.py @@ -329,7 +329,7 @@ } def __init__(self): - for color in self.colors.keys(): + for color in self.colors: env_var = f"TESTENV_COLOR_{color.upper()}" if env_var in os.environ: self.colors[color] = os.environ.get(env_var) diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 4fcb905..0293712 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -57,13 +57,11 @@ def image_build(check_existing=True): - if check_existing: - if image_exists() and image_up_to_date(): - logging.debug(f"Podman image is up-to-date: {image_name}") - if testenv.args.force: - logging.debug("Building anyway since --force was used") - else: - return + if check_existing and image_exists() and image_up_to_date(): + logging.debug(f"Podman image is up-to-date: {image_name}") + if not testenv.args.force: + return + logging.debug("Building anyway since --force was used") logging.info(f"Building podman image: {image_name}") testenv.cmd.run( @@ -348,10 +346,7 @@ return False cmd = ["podman", "ps", "-q", "--filter", f"name={container_name}"] - if not subprocess.run(cmd, capture_output=True, text=True, check=False).stdout: - return False - - return True + return bool(subprocess.run(cmd, capture_output=True, text=True, check=False).stdout) def stop(restart=False): diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py index 93ffa5d..cf7896e 100644 --- a/_testenv/testenv/testenv_cfg.py +++ b/_testenv/testenv/testenv_cfg.py @@ -87,7 +87,7 @@ qemu_required = False for basename, cfg in cfgs.items(): - for section in cfg.keys(): + for section in cfg: if "qemu" in cfg[section]: qemu_supported = True if cfg[section]["qemu"] == "required": @@ -171,7 +171,7 @@ exit_error_readme() for section in cfg: - for key in cfg[section].keys(): + for key in cfg[section]: valid = keys_valid_component if section == "testsuite": valid = keys_valid_testsuite diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index 6a85cd5..b1bd8a8 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -210,7 +210,7 @@ logging.debug("Waiting until test has stopped...") - for i in range(0, 1200): + for i in range(1200): time.sleep(0.1) if not os.path.exists(path): return -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3 Gerrit-Change-Number: 43306 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp/generate_all_test_certificates: use f-string
by osmith 20 Aug '26

20 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43304?usp=email ) Change subject: smdpp/generate_all_test_certificates: use f-string ...................................................................... smdpp/generate_all_test_certificates: use f-string Related: https://docs.astral.sh/ruff/rules/f-string/ Change-Id: I2671f03e5f35d1e71fb3f090e90a37961fae6a1d --- M .ruff.toml M smdpp/generate_all_test_certificates.py 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/.ruff.toml b/.ruff.toml index 8a24384..53bd7ed 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -21,5 +21,4 @@ "SIM102", # https://docs.astral.sh/ruff/rules/collapsible-if/ "SIM103", # https://docs.astral.sh/ruff/rules/needless-bool/ "SIM118", # https://docs.astral.sh/ruff/rules/in-dict-keys/ - "UP032", # https://docs.astral.sh/ruff/rules/f-string/ ] diff --git a/smdpp/generate_all_test_certificates.py b/smdpp/generate_all_test_certificates.py index 3bc1733..a53c30e 100755 --- a/smdpp/generate_all_test_certificates.py +++ b/smdpp/generate_all_test_certificates.py @@ -597,4 +597,4 @@ print("\nGenerated certificates in ./InvalidTestCases/:") for cert in certificates_generated: print(f" • {cert}") - print("\nTotal: {} certificates generated".format(len(certificates_generated))) + print(f"\nTotal: {len(certificates_generated)} certificates generated") -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2671f03e5f35d1e71fb3f090e90a37961fae6a1d Gerrit-Change-Number: 43304 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: subprocess.run with explicit check=False
by osmith 20 Aug '26

20 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43303?usp=email ) Change subject: testenv: subprocess.run with explicit check=False ...................................................................... testenv: subprocess.run with explicit check=False Make explicit that we want check=False for these subprocess.run commands. Related: https://docs.astral.sh/ruff/rules/subprocess-run-without-check/ Change-Id: Ia4e85e4fd9aa780a4c8dca433fa95c537c43ddaa --- M .ruff.toml M _testenv/testenv/cmd.py M _testenv/testenv/coredump.py M _testenv/testenv/podman.py M _testenv/testenv/podman_install.py 5 files changed, 9 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/.ruff.toml b/.ruff.toml index ebf5d74..8a24384 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -17,7 +17,6 @@ "PIE808", # https://docs.astral.sh/ruff/rules/unnecessary-range-start/ "PLC0206", # https://docs.astral.sh/ruff/rules/dict-index-missing-items/ "PLW0602", # https://docs.astral.sh/ruff/rules/global-variable-not-assigned/ - "PLW1510", # https://docs.astral.sh/ruff/rules/subprocess-run-without-check/ "RUF012", # https://docs.astral.sh/ruff/rules/mutable-class-default/ "SIM102", # https://docs.astral.sh/ruff/rules/collapsible-if/ "SIM103", # https://docs.astral.sh/ruff/rules/needless-bool/ diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index 97e5c0d..06630c0 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -134,6 +134,7 @@ env=generate_env(env), shell=isinstance(cmd, str), stdin=stdin, + check=False, *args, **kwargs, ) diff --git a/_testenv/testenv/coredump.py b/_testenv/testenv/coredump.py index d436551..3c95b15 100644 --- a/_testenv/testenv/coredump.py +++ b/_testenv/testenv/coredump.py @@ -49,7 +49,7 @@ cmd = ["coredumpctl", "-q", "-S", since, "--json=short", "-n1"] logging.debug(f"+ {cmd}") - p = subprocess.run(cmd, capture_output=True, text=True) + p = subprocess.run(cmd, capture_output=True, text=True, check=False) if p.returncode != 0: logging.debug("No coredump found") return diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index eefa911..3641693 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -189,7 +189,11 @@ try: while True: time.sleep(2) - p = subprocess.run(["podman", "exec", container_name, "touch", "/tmp/watchdog"], stderr=subprocess.DEVNULL) + p = subprocess.run( + ["podman", "exec", container_name, "touch", "/tmp/watchdog"], + stderr=subprocess.DEVNULL, + check=False, + ) if p.returncode: logging.debug("feed_watchdog_loop: podman container has stopped") return @@ -345,7 +349,7 @@ return False cmd = ["podman", "ps", "-q", "--filter", f"name={container_name}"] - if not subprocess.run(cmd, capture_output=True, text=True).stdout: + if not subprocess.run(cmd, capture_output=True, text=True, check=False).stdout: return False return True diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 9f40388..438f875 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -66,7 +66,7 @@ for dbg_pkg in get_dbg_pkgs(dep): # Use subprocess.run so we don't get lots of log messages. # Also we don't need to run grep through podman. - grep = subprocess.run(["grep", "-q", f"^{dbg_pkg}$", dbg_pkgs_all]) + grep = subprocess.run(["grep", "-q", f"^{dbg_pkg}$", dbg_pkgs_all], check=False) if grep.returncode == 0: dbg_pkgs[dep] = dbg_pkg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4e85e4fd9aa780a4c8dca433fa95c537c43ddaa Gerrit-Change-Number: 43303 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: remove *args from various functions
by osmith 20 Aug '26

20 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43305?usp=email ) Change subject: testenv: remove *args from various functions ...................................................................... testenv: remove *args from various functions Whenever **kwargs can be passed to functions, I have also added *args even though it is unused. If it was actually used, it could lead to confusing behavior as they are passed along after keyword arguments. Related: https://docs.astral.sh/ruff/rules/star-arg-unpacking-after-keyword-arg/ Change-Id: I18edc0ee16bd23e1188162156939e9b51f6b13d2 --- M .ruff.toml M _testenv/testenv/cmd.py M _testenv/testenv/podman.py 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/.ruff.toml b/.ruff.toml index 53bd7ed..d8fc4db 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -5,7 +5,6 @@ [lint] ignore = [ - "B026", # https://docs.astral.sh/ruff/rules/star-arg-unpacking-after-keyword-arg/ "BLE001", # https://docs.astral.sh/ruff/rules/blind-except/ "DTZ001", # https://docs.astral.sh/ruff/rules/call-datetime-without-tzinfo/ "DTZ004", # https://docs.astral.sh/ruff/rules/call-datetime-utcfromtimestamp/ diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index 06630c0..4da2360 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -121,10 +121,10 @@ return ret -def run(cmd, check=True, env=None, no_podman=False, stdin=subprocess.DEVNULL, *args, **kwargs): +def run(cmd, check=True, env=None, no_podman=False, stdin=subprocess.DEVNULL, **kwargs): env = env or {} if not no_podman and testenv.args.podman: - return testenv.podman.exec_cmd(cmd, check=check, env=env, *args, **kwargs) + return testenv.podman.exec_cmd(cmd, check=check, env=env, **kwargs) logging.debug(f"+ {cmd}") @@ -135,7 +135,6 @@ shell=isinstance(cmd, str), stdin=stdin, check=False, - *args, **kwargs, ) diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 3641693..4fcb905 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -137,7 +137,7 @@ run_shell_on_stop = True -def exec_cmd(cmd, podman_opts=None, cwd=None, env=None, *args, **kwargs): +def exec_cmd(cmd, podman_opts=None, cwd=None, env=None, **kwargs): podman_opts = podman_opts or [] env = env or {} @@ -158,7 +158,6 @@ return testenv.cmd.run( ["podman", "exec"] + podman_opts + [container_name] + cmd, no_podman=True, - *args, **kwargs, ) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18edc0ee16bd23e1188162156939e9b51f6b13d2 Gerrit-Change-Number: 43305 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026