August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again
by pespin 27 Aug '26

27 Aug '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43426?usp=email ) Change subject: deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57b635f4a75ece6b280f9c6f7e698804ec3b15a2 Gerrit-Change-Number: 43426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 14:28:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again
by pespin 27 Aug '26

27 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43426?usp=email ) Change subject: deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again ...................................................................... deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again As of current master all the PRs submitted have been merged, so there's no need to keep using a fork for now. Change-Id: I57b635f4a75ece6b280f9c6f7e698804ec3b15a2 --- M deps/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/43426/1 diff --git a/deps/Makefile b/deps/Makefile index abab58a..6f54041 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -38,6 +38,7 @@ titan.ProtocolModules.NS_v7.3.0 \ titan.ProtocolModules.SGsAP_13.2.0 \ titan.ProtocolModules.SNDCP_v7.0.0 \ + titan.ProtocolModules.PFCP_v15.1.0 \ titan.TestPorts.Common_Components.Socket-API \ titan.TestPorts.Common_Components.Abstract_Socket \ titan.TestPorts.HTTPmsg \ @@ -60,7 +61,6 @@ OSMOGITEA_REPOS= nas \ titan.ProtocolModules.BSSMAP \ titan.ProtocolModules.MAP \ - titan.ProtocolModules.PFCP_v15.1.0 \ titan.TestPorts.AF_PACKET \ titan.TestPorts.USB @@ -107,7 +107,7 @@ titan.ProtocolModules.SUA_commit= R.5.A-5-gcf1137a titan.ProtocolModules.TCP_commit= R.3.A-5-g39e5f45 titan.ProtocolModules.UDP_commit= R.4.A-5-geea8aa3 -titan.ProtocolModules.PFCP_v15.1.0_commit= f2fbaf3662519b045077c26e256f32deae4fbf33 +titan.ProtocolModules.PFCP_v15.1.0_commit= c995f70038465a0d455a553780bcee67eed5a7cd titan.TestPorts.AF_PACKET_commit= 0.1-5-g89ebea6 titan.TestPorts.Common_Components.Socket-API_commit= R.6.A-6-gf4380d0 titan.TestPorts.Common_Components.Abstract_Socket_commit= R.9.B-4-gbd41994 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57b635f4a75ece6b280f9c6f7e698804ec3b15a2 Gerrit-Change-Number: 43426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce initial PFCP support
by pespin 27 Aug '26

27 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43308?usp=email ) Change subject: smf: Introduce initial PFCP support ...................................................................... Patch Set 5: (1 comment) File smf/SMF_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43308/comment/b715c200_7e26… : PS5, Line 204: g_pfcp_answer_heartbeat_req > Wouldn't it be more practical to accept this as a parameter of this function? Then you'd need to pass it over f_init(), etc. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fb988b5ad351b40e18f02f9bfca7bbd267bb6a4 Gerrit-Change-Number: 43308 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 14:27:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by laforge 27 Aug '26

27 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 12: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 27 Aug 2026 13:23:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by laforge 27 Aug '26

27 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > IMHO: the linter is not a blocker to merge it. I'm following there the previous style. […] ACK -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 27 Aug 2026 13:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_part(): Propagate failure from sua_parse_gt()
by pespin 27 Aug '26

27 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43422?usp=email ) Change subject: sua: sua_addr_parse_part(): Propagate failure from sua_parse_gt() ...................................................................... sua: sua_addr_parse_part(): Propagate failure from sua_parse_gt() As a result, addresses with > 31 digits would be silently trimmed and accepted. Also, remove the par_datalen check, sua_parse_gt() already takes care of it. Change-Id: Ia9d33d313b272e5b230be68eccb8e14ff739d9a4 --- M src/sua.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sua.c b/src/sua.c index 0784b61..f3ed921 100644 --- a/src/sua.c +++ b/src/sua.c @@ -857,9 +857,8 @@ out->presence |= OSMO_SCCP_ADDR_T_SSN; break; case SUA_IEI_GT: - if (par_datalen < 8) + if (sua_parse_gt(&out->gt, par->data, par_datalen) < 0) goto subpar_fail; - sua_parse_gt(&out->gt, par->data, par_datalen); out->presence |= OSMO_SCCP_ADDR_T_GT; break; case SUA_IEI_IPv4: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia9d33d313b272e5b230be68eccb8e14ff739d9a4 Gerrit-Change-Number: 43422 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_part(): Log subpart where parse failed
by pespin 27 Aug '26

27 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43423?usp=email ) Change subject: sua: sua_addr_parse_part(): Log subpart where parse failed ...................................................................... sua: sua_addr_parse_part(): Log subpart where parse failed Change-Id: Id33b74f10cb617d94a404b509240a46f6d11324b --- M src/sua.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sua.c b/src/sua.c index f3ed921..e14130f 100644 --- a/src/sua.c +++ b/src/sua.c @@ -888,8 +888,8 @@ return 0; subpar_fail: - LOGP(DLSUA, LOGL_ERROR, "Failed to parse subparts of address IEI=0x%04x\n", - param->tag); + LOGP(DLSUA, LOGL_ERROR, "Failed to parse SUA Address IEI=0x%04x (subpart tag 0x%04x, len %hu)\n", + param->tag, par_tag, par_len); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id33b74f10cb617d94a404b509240a46f6d11324b Gerrit-Change-Number: 43423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_addr_parse_part(): Fix potential read buffer overflow
by pespin 27 Aug '26

27 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43421?usp=email ) Change subject: sua: sua_addr_parse_part(): Fix potential read buffer overflow ...................................................................... sua: sua_addr_parse_part(): Fix potential read buffer overflow The sua_addr_parse_part() function lacked validating that the length value in the TLV struct didn't go past the buffer, which could end up in a read buffer overflow. Related: OS#7079 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I12fbdfc37bfbf6cf9ba18942eb0ec43c9d1349fe --- M src/sua.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/sua.c b/src/sua.c index 3b217f4..0784b61 100644 --- a/src/sua.c +++ b/src/sua.c @@ -830,9 +830,12 @@ par_tag = ntohs(par->tag); par_len = ntohs(par->len); - /* sanity: check par->len received on the wire, make sure the subtraction does not wrap past zero. */ + /* L value must account for at least TL (struct xua_parameter_hdr): */ if (par_len < sizeof(*par)) goto subpar_fail; + /* Avoid reading past buffer: */ + if (pos + par_len > param->len) + goto subpar_fail; par_datalen = par_len - sizeof(*par); LOGP(DLSUA, LOGL_DEBUG, "SUA IEI 0x%04x pos %hu/%hu: subpart tag 0x%04x, len %hu\n", -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12fbdfc37bfbf6cf9ba18942eb0ec43c9d1349fe Gerrit-Change-Number: 43421 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_*(): propagate failure of sccp_addr_to_sua_ptr()
by laforge 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43425?usp=email ) Change subject: sccp2sua: sccp_to_xua_*(): propagate failure of sccp_addr_to_sua_ptr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I44612fb0ea0728fab3147cf0eefcee17f96b29fa Gerrit-Change-Number: 43425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 12:06:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_*(): Fix potential read buffer overflow
by laforge 27 Aug '26

27 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43424?usp=email ) Change subject: sccp2sua: sccp_to_xua_*(): Fix potential read buffer overflow ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I310c9b65625aef227100cbc37709dc63fc4e7f8a Gerrit-Change-Number: 43424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 12:05:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026