August 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_*(): propagate failure of sccp_addr_to_sua_ptr()
by osmith 28 Aug '26

28 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43425?usp=email ) Change subject: sccp2sua: sccp_to_xua_*(): propagate failure of sccp_addr_to_sua_ptr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I44612fb0ea0728fab3147cf0eefcee17f96b29fa Gerrit-Change-Number: 43425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Aug 2026 06:38:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_*(): Fix potential read buffer overflow
by osmith 28 Aug '26

28 Aug '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43424?usp=email ) Change subject: sccp2sua: sccp_to_xua_*(): Fix potential read buffer overflow ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I310c9b65625aef227100cbc37709dc63fc4e7f8a Gerrit-Change-Number: 43424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Aug 2026 06:37:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: test_configurable_parameters: test less templates
by neels 28 Aug '26

28 Aug '26

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43288?usp=email ) Change subject: test_configurable_parameters: test less templates ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67 Gerrit-Change-Number: 43288 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2026 23:07:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: RandomHexDigitSource: rather return in string format, not bytes
by neels 28 Aug '26

28 Aug '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40826?usp=email ) Change subject: RandomHexDigitSource: rather return in string format, not bytes ...................................................................... Abandoned outdated -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e86289f6fb72cbd4cf0c90b8b49538cfab69a7f Gerrit-Change-Number: 40826 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: saip SmspTpScAddr: safeguard against decoding error
by neels 28 Aug '26

28 Aug '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41920?usp=email ) Change subject: saip SmspTpScAddr: safeguard against decoding error ...................................................................... Abandoned outdated -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic436e206776b81f24de126e8ee0ae8bf5f3e8d7a Gerrit-Change-Number: 41920 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: param_source: allow input val expansion like '0 * 32'
by neels 28 Aug '26

28 Aug '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40207?usp=email ) Change subject: param_source: allow input val expansion like '0 * 32' ...................................................................... Abandoned outdated -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie7171c152a7b478736f8825050305606b5af5735 Gerrit-Change-Number: 40207 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: esim/http_json_api.py: support text/plain response Content-Type
by neels 28 Aug '26

28 Aug '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email ) Change subject: esim/http_json_api.py: support text/plain response Content-Type ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > no feedback regarding those comments? When the content-type is not JSON, but exactly plain UTF-8 text, the caller will receive a result dict of the form { 'data': 'foobar' } which will not match the signature that a JSON API function expects, so there should be errors thrown in the calling code. i can add an explicit flag but don't agree that it is necessary, i believe problems are being imagined that don't exist. What's your final verdict? While inventing problems, we could make it { 'utf-8': 'foobar' } instead of 'data' in case more content types show up, like binary...? Still don't think that it is necessary. (curious, i thought i had first submitted this patch only a few days ago -- it must have been part of an earlier submission before fixeria started...) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 Gerrit-Change-Number: 42155 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 27 Aug 2026 23:04:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: saip BatchPersonalization: call rebuild_mandatory_services()
by neels 28 Aug '26

28 Aug '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43287?usp=email ) Change subject: saip BatchPersonalization: call rebuild_mandatory_services() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I don't see how we'd ever need to rebuild the mandatory service list on a _per profile_ basis. […] The process is: - load the template - modify it - then set up the 5G SUCI and other flags according to what is found in the PES. That means i have to call the function after each profile has all information in the PES -- in the unchanged template, the 5G SUCI calc info is not set up yet, so we cannot determine which flags it needs. Not sure how else one would do this. This function is fast because it just sets a couple of flags, right? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f Gerrit-Change-Number: 43287 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 27 Aug 2026 22:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again
by pespin 28 Aug '26

28 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43426?usp=email ) Change subject: deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again ...................................................................... deps/Makefile: titan.ProtocolModules.PFCP_v15.1.0: Use upstream again As of current master all the PRs submitted have been merged, so there's no need to keep using a fork for now. Change-Id: I57b635f4a75ece6b280f9c6f7e698804ec3b15a2 --- M deps/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index abab58a..6f54041 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -38,6 +38,7 @@ titan.ProtocolModules.NS_v7.3.0 \ titan.ProtocolModules.SGsAP_13.2.0 \ titan.ProtocolModules.SNDCP_v7.0.0 \ + titan.ProtocolModules.PFCP_v15.1.0 \ titan.TestPorts.Common_Components.Socket-API \ titan.TestPorts.Common_Components.Abstract_Socket \ titan.TestPorts.HTTPmsg \ @@ -60,7 +61,6 @@ OSMOGITEA_REPOS= nas \ titan.ProtocolModules.BSSMAP \ titan.ProtocolModules.MAP \ - titan.ProtocolModules.PFCP_v15.1.0 \ titan.TestPorts.AF_PACKET \ titan.TestPorts.USB @@ -107,7 +107,7 @@ titan.ProtocolModules.SUA_commit= R.5.A-5-gcf1137a titan.ProtocolModules.TCP_commit= R.3.A-5-g39e5f45 titan.ProtocolModules.UDP_commit= R.4.A-5-geea8aa3 -titan.ProtocolModules.PFCP_v15.1.0_commit= f2fbaf3662519b045077c26e256f32deae4fbf33 +titan.ProtocolModules.PFCP_v15.1.0_commit= c995f70038465a0d455a553780bcee67eed5a7cd titan.TestPorts.AF_PACKET_commit= 0.1-5-g89ebea6 titan.TestPorts.Common_Components.Socket-API_commit= R.6.A-6-gf4380d0 titan.TestPorts.Common_Components.Abstract_Socket_commit= R.9.B-4-gbd41994 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57b635f4a75ece6b280f9c6f7e698804ec3b15a2 Gerrit-Change-Number: 43426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce initial PFCP support
by pespin 28 Aug '26

28 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43308?usp=email ) Change subject: smf: Introduce initial PFCP support ...................................................................... smf: Introduce initial PFCP support With this commit PFCP association setup procedure already succeeds. Change-Id: I3fb988b5ad351b40e18f02f9bfca7bbd267bb6a4 --- M smf/SMF_Tests.ttcn M smf/gen_links.sh M smf/regen_makefile.sh 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index 1e11337..c94e851 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -23,6 +23,11 @@ import from DIAMETER_ts32_299_Templates all; import from DIAMETER_Emulation all; +import from PFCP_Types all; +import from PFCP_Emulation all; +import from PFCP_Templates all; +import from PFCP_CodecPort all; + import from SMF_Session_CT all; modulepar { @@ -40,10 +45,14 @@ integer mp_aaa_local_port := 3870; charstring mp_diam_realm := "localdomain"; + + /* IP address at which we listen for PFCP to emulate a UPF in ttcn3 */ + charstring mp_pfcp_ip_local := "127.0.0.7"; + charstring mp_pfcp_upf_node_id := "\07osmocom\03org"; } /* main component, we typically have one per testcase */ -type component SMF_Test_CT extends GTP2_ConnHdlr { +type component SMF_Test_CT extends GTP2_ConnHdlr, PFCP_ConnHdlr { var GTPv2_Emulation_CT vc_GTP2; port GTP2EM_PT TEIC0; var GTPv1U_Emulation_CT vc_GTP1U; @@ -61,6 +70,11 @@ var DIAMETER_Emulation_CT vc_S6b; port DIAMETER_PT S6b_UNIT; port DIAMETEREM_PROC_PT S6b_PROC; + + /* emulated UPF */ + var PFCP_Emulation_CT vc_PFCP; + var boolean g_pfcp_answer_heartbeat_req := true; + /* global test case guard timer (actual timeout value is set in f_init()) */ timer T_guard; } @@ -178,13 +192,41 @@ vc_GTP1U.start(GTPv1U_Emulation.main(cfg)); } +function f_init_pfcp(charstring id) runs on SMF_Test_CT { + id := id & "-PFCP"; + + var PFCP_Emulation_Cfg pfcp_cfg := { + pfcp_bind_ip := mp_pfcp_ip_local, + pfcp_bind_port := PFCP_PORT, + pfcp_remote_ip := mp_smf_hostname, + pfcp_remote_port := PFCP_PORT, + role := UPF, + answer_heartbeat_req := g_pfcp_answer_heartbeat_req + }; + + vc_PFCP := PFCP_Emulation_CT.create(id) alive; + vc_PFCP.start(PFCP_Emulation.main(pfcp_cfg)); + + /* Temporarily hook to PFCP to make sure we are back to PFCP Associated state: */ + connect(self:PFCP, vc_PFCP:CLIENT); + connect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); + f_pfcp_force_assoc_setup_req(ts_PFCP_Node_ID_ipv4(f_inet_addr(mp_pfcp_ip_local)), + fail_timeout := true); + disconnect(self:PFCP, vc_PFCP:CLIENT); + disconnect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); + +} + private function f_init(float guard_timeout := 60.0) runs on SMF_Test_CT { T_guard.start(guard_timeout); activate(as_Tguard()); + var charstring id := testcasename(); f_init_gtp2c(); f_init_gtp1u(); + f_init_pfcp(id); + if (mp_pcrf_local_ip != "") { f_init_diameter(testcasename()); } diff --git a/smf/gen_links.sh b/smf/gen_links.sh index 1f56b9c..3b4fe2a 100755 --- a/smf/gen_links.sh +++ b/smf/gen_links.sh @@ -7,6 +7,7 @@ DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn TCCConversion.cc TCCInterface.cc TCCInterface_ip.h" FILES+=" TCCEncoding_Functions.ttcn TCCEncoding.cc " # BCD coding +FILES+="TCCDateTime.cc TCCDateTime_Functions.ttcn " # NTP_Functions (NTP timestamp) gen_links $DIR $FILES DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src @@ -49,6 +50,10 @@ FILES="GTPv2_Types.ttcn" gen_links $DIR $FILES +DIR=$BASEDIR/titan.ProtocolModules.PFCP_v15.1.0/src +FILES="PFCP_Types.ttcn" +gen_links $DIR $FILES + DIR=$BASEDIR/titan.ProtocolModules.DIAMETER_ProtocolModule_Generator/src FILES="DIAMETER_EncDec.cc" gen_links $DIR $FILES @@ -63,6 +68,7 @@ FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc4004_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_212_Templates.ttcn DIAMETER_ts29_212_Templates.ttcn DIAMETER_ts29_229_Templates.ttcn DIAMETER_ts29_272_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn DIAMETER_ts32_299_Templates.ttcn " FILES+="SCTP_Templates.ttcn " +FILES+="NTP_Functions.ttcn PFCP_Templates.ttcn PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn " gen_links $DIR $FILES gen_links_finish diff --git a/smf/regen_makefile.sh b/smf/regen_makefile.sh index 51a50d4..a2cb4bc 100755 --- a/smf/regen_makefile.sh +++ b/smf/regen_makefile.sh @@ -20,9 +20,11 @@ IP_EncDec.cc Native_FunctionDefs.cc TCCConversion.cc + TCCDateTime.cc TCCInterface.cc TCCEncoding.cc UDP_EncDec.cc + PFCP_CodecPort_CtrlFunctDef.cc " CPPFLAGS_TTCN3="" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fb988b5ad351b40e18f02f9bfca7bbd267bb6a4 Gerrit-Change-Number: 43308 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026