August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: use tmpfs
by laforge 21 Aug '26

21 Aug '26

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: use tmpfs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: for which jobs does this apply? I think we have to be careful in terms of RAM utilization. So which jobs does it aplpy to? how large are they? how many parallel builders do we have concurrently? IMHO for example TTCN-3 jobs are not suitable for tmpfs, as the compiler already needs *massive* amounts of RAM. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e9cd491f528bda2f556fc6922d8780785d058f6 Gerrit-Change-Number: 43344 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: use tmpfs
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: use tmpfs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e9cd491f528bda2f556fc6922d8780785d058f6 Gerrit-Change-Number: 43344 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:01:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sua: refactor sua_parse_gt() digit loop
by fixeria 21 Aug '26

21 Aug '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email ) Change subject: sua: refactor sua_parse_gt() digit loop ...................................................................... sua: refactor sua_parse_gt() digit loop The digit-parsing loop in sua_parse_gt() bounded output writes to gt->digits[] via mid-loop break checks against the clamped num_digits, while the loop itself iterated over datalen-8. Although provably safe, Coverity cannot correlate the break conditions with the loop bound and flags a false-positive overrun. Rewrite the loop to iterate directly over num_digits, so the bound on writes into gt->digits[] is syntactically obvious. No functional change. Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Related: OS#7046, CID#562801 --- M src/sua.c 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/48/43348/1 diff --git a/src/sua.c b/src/sua.c index 35c4a8e..7c6d57f 100644 --- a/src/sua.c +++ b/src/sua.c @@ -412,16 +412,20 @@ rc = -ENOSPC; } - /* parse digits */ + /* parse digits: bounded by num_digits (already clamped above), so this + * can never write more than sizeof(gt->digits)-1 nibbles into gt->digits[] */ out_digits = gt->digits; - for (i = 0; i < datalen-8; i++) { - uint8_t byte = data[8+i]; - *out_digits++ = osmo_bcd2char(byte & 0x0F); - if (out_digits - gt->digits >= num_digits) + for (i = 0; i < num_digits; i++) { + unsigned int byte_off = 8 + i / 2; + uint8_t byte; + + if (byte_off >= datalen) break; - *out_digits++ = osmo_bcd2char(byte >> 4); - if (out_digits - gt->digits >= num_digits) - break; + byte = data[byte_off]; + if (i & 1) + *out_digits++ = osmo_bcd2char(byte >> 4); + else + *out_digits++ = osmo_bcd2char(byte & 0x0F); } *out_digits++ = '\0'; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Gerrit-Change-Number: 43348 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: adjust apt pattern
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: adjust apt pattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82eba41631d520abedc6fb2e2507afbbe618066a Gerrit-Change-Number: 43345 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:00:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: adjust apt pattern
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: adjust apt pattern ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82eba41631d520abedc6fb2e2507afbbe618066a Gerrit-Change-Number: 43345 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: remsim_client: only set usb parameters if given by config
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email ) Change subject: remsim_client: only set usb parameters if given by config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a Gerrit-Change-Number: 43347 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:59:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: usb: osmo_libusb_open_claim_interface: print an error when no device ...
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email ) Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/usb/osmo_libusb.c: https://gerrit.osmocom.org/c/libosmocore/+/43346/comment/fcdcfb9c_bfa82274?… : PS1, Line 583: do we really need the goto? Doesn the if (!usb_devh) nicely cover what we need here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce Gerrit-Change-Number: 43346 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:58:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: Remote Card Procedure Framework
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: dexter, pespin. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42996?usp=email ) Change subject: Remote Card Procedure Framework ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I would move this out of the contrib directory. […] I agree with that. I think it's still a separate question if this should go in pysim.git or rather a separate/new repository, too. It uses some pySim code of course, but that's possible also via a library/module dependency. I'm somewhat undecided on that part. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8500a98492328ed5b3eb4bb177af2a4a8e481f80 Gerrit-Change-Number: 42996 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:57:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-remsim[master]: remsim_client: only set usb parameters if given by config
by lynxis lazus 20 Aug '26

20 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email ) Change subject: remsim_client: only set usb parameters if given by config ...................................................................... remsim_client: only set usb parameters if given by config Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a --- M src/client/user_simtrace2.c 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/47/43347/1 diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 2535efb..1e847c0 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -415,12 +415,18 @@ bc->cardem = ci; memset(ifm, 0, sizeof(*ifm)); - ifm->vendor = cfg->usb.vendor_id; - ifm->product = cfg->usb.product_id; - ifm->configuration = cfg->usb.config_id; - ifm->interface = cfg->usb.if_num; - ifm->altsetting = cfg->usb.altsetting; - ifm->addr = cfg->usb.addr; + if (cfg->usb.vendor_id >= 0) + ifm->vendor = cfg->usb.vendor_id; + if (cfg->usb.product_id >= 0) + ifm->product = cfg->usb.product_id; + if (cfg->usb.config_id >= 0) + ifm->configuration = cfg->usb.config_id; + if (cfg->usb.if_num >= 0) + ifm->interface = cfg->usb.if_num; + if (cfg->usb.altsetting >= 0) + ifm->altsetting = cfg->usb.altsetting; + if (cfg->usb.addr >= 0) + ifm->addr = cfg->usb.addr; if (cfg->usb.path) osmo_strlcpy(ifm->path, cfg->usb.path, sizeof(ifm->path)); transp->udp_fd = -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a Gerrit-Change-Number: 43347 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmocore[master]: usb: osmo_libusb_open_claim_interface: print an error when no device ...
by lynxis lazus 20 Aug '26

20 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email ) Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found ...................................................................... usb: osmo_libusb_open_claim_interface: print an error when no device was found When no device was found, osmo_libusb_open_claim_interface() was silent and the other had no idea what went wrong. Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce --- M src/usb/osmo_libusb.c 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/43346/1 diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c index a249d10..e08a607 100644 --- a/src/usb/osmo_libusb.c +++ b/src/usb/osmo_libusb.c @@ -543,14 +543,14 @@ if (rc < 0) { fprintf(stderr, "Cannot open device: %s\n", libusb_error_name(rc)); usb_devh = NULL; - break; + goto out; } rc = libusb_get_configuration(usb_devh, &config); if (rc < 0) { fprintf(stderr, "Cannot get current configuration: %s\n", libusb_error_name(rc)); libusb_close(usb_devh); usb_devh = NULL; - break; + goto out; } if (config != ifm->configuration) { rc = libusb_set_configuration(usb_devh, ifm->configuration); @@ -558,7 +558,7 @@ fprintf(stderr, "Cannot set configuration: %s\n", libusb_error_name(rc)); libusb_close(usb_devh); usb_devh = NULL; - break; + goto out; } } rc = libusb_claim_interface(usb_devh, ifm->interface); @@ -566,7 +566,7 @@ fprintf(stderr, "Cannot claim interface: %s\n", libusb_error_name(rc)); libusb_close(usb_devh); usb_devh = NULL; - break; + goto out; } rc = libusb_set_interface_alt_setting(usb_devh, ifm->interface, ifm->altsetting); if (rc < 0) { @@ -574,11 +574,14 @@ libusb_release_interface(usb_devh, ifm->interface); libusb_close(usb_devh); usb_devh = NULL; - break; + goto out; } } } + if (!usb_devh) + fprintf(stderr, "Failed to find a matching usb device\n"); +out: /* unref / free list */ for (dev = list; *dev; dev++) libusb_unref_device(*dev); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce Gerrit-Change-Number: 43346 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026