August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: OM2K: Check bounds of OM2K Negotiation Request
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email ) Change subject: OM2K: Check bounds of OM2K Negotiation Request ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/43293/comment/99d56c47_1891a05d?usp… : PS1, Line 2777: uint8_t *cur = o2h->data+3; You are accessing msg already here before the first check you added in 2785, are you sure this is correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed Gerrit-Change-Number: 43293 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 20 Aug 2026 16:06:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: sua: sua_parse_gt(): reject GT with num_digits exceeding blob length
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349?usp=email ) Change subject: sua: sua_parse_gt(): reject GT with num_digits exceeding blob length ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349/comment/ea9df4ab_feb72… : PS1, Line 417: /* Parse as much as we can; return -EINVAL */ I wonder what's the point in parsing as much as we can if anyway we end up in error, but ok...To me working on known malfunctioned packets doesn't seem like a good idea. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I918278b6471bc78511bf97a292204e6719d4031a Gerrit-Change-Number: 43349 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 16:04:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sua: refactor sua_parse_gt() digit loop
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email ) Change subject: sua: refactor sua_parse_gt() digit loop ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Gerrit-Change-Number: 43348 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 16:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: cosmetic: fix missing space
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43353?usp=email ) Change subject: cosmetic: fix missing space ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia83c96e5e39431dedfa64444290f1b7b816ce540 Gerrit-Change-Number: 43353 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Aug 2026 15:58:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: usb: osmo_libusb_open_claim_interface: print an error when no device ...
by lynxis lazus 21 Aug '26

21 Aug '26

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email ) Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found ...................................................................... Patch Set 1: (1 comment) File src/usb/osmo_libusb.c: https://gerrit.osmocom.org/c/libosmocore/+/43346/comment/485d94ce_39f81e48?… : PS1, Line 583: > do we really need the goto? Doesn the if (!usb_devh) nicely cover what we need here? Without the goto you will have: """ Cannot set interface altsetting X Failed to find a matching usb device """ The second line would be wrong in the error case, because it found a matching device, but couldn't configure it in the right way. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce Gerrit-Change-Number: 43346 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Aug 2026 15:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-remsim[master]: handle_options(): exit(2) if an unparsed argument was given
by lynxis lazus 21 Aug '26

21 Aug '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: handle_options(): exit(2) if an unparsed argument was given ...................................................................... handle_options(): exit(2) if an unparsed argument was given All osmo-remsim binaries are only supporting arguments starting with a dash ('-'), but no positional argument. Ensure all binaries will exit when an positional argument was given and do the same when an unrecognized argument was given. Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/52/43352/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 Gerrit-Change-Number: 43352 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by daniel 21 Aug '26

21 Aug '26

Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email ) Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... Patch Set 2: (1 comment) File common/chapters/sigtran-osmocom.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/5565bebc_a50a… : PS1, Line 201: ASP. > I'm missing here: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Aug 2026 15:07:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: client: simtrace2: Use the new API osmo_apdu_segment_in2()
by lynxis lazus 21 Aug '26

21 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/43351?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: client: simtrace2: Use the new API osmo_apdu_segment_in2() ...................................................................... client: simtrace2: Use the new API osmo_apdu_segment_in2() The old osmo_apdu_segment_in() could not parse GP GET DATA correctly and will fail when parsing a GP GET DATA case 2 with an Le != 0. Related: SYS#8147 Change-Id: I432c96c8cdbcb78bc3e4f135ebd51c4077aa9007 --- M TODO-RELEASE M src/client/user_simtrace2.c 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/51/43351/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I432c96c8cdbcb78bc3e4f135ebd51c4077aa9007 Gerrit-Change-Number: 43351 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-remsim[master]: handle_options(): exit(2) if an unparsed argument was given
by Jenkins Builder 21 Aug '26

21 Aug '26

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email ) Change subject: handle_options(): exit(2) if an unparsed argument was given ...................................................................... Patch Set 1: (4 comments) File src/bankd/bankd_main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43352/comment/aa5513df_580a4a1f?… : PS1, Line 415: } code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43352/comment/95700302_b1f9e67a?… : PS1, Line 415: } please, no spaces at the start of a line File src/client/remsim_client_main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43352/comment/5e5bbaf8_066fea71?… : PS1, Line 179: } code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43352/comment/827fcd14_0c4009bd?… : PS1, Line 179: } please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 Gerrit-Change-Number: 43352 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 20 Aug 2026 14:57:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-remsim[master]: handle_options(): exit(2) if an unparsed argument was given
by lynxis lazus 21 Aug '26

21 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email ) Change subject: handle_options(): exit(2) if an unparsed argument was given ...................................................................... handle_options(): exit(2) if an unparsed argument was given All osmo-remsim binaries are only supporting arguments starting with a dash ('-'), but no positional argument. Ensure all binaries will exit when an positional argument was given and do the same when an unrecognized argument was given. Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/52/43352/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 9ef05a4..ef149a8 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -399,8 +399,20 @@ case 'e': log_set_log_level(osmo_stderr_target, atoi(optarg)); break; + case '?': + /* unsupported/unrecognized argument */ + exit(2); + break; + default: + break; } } + + if (argc > optind) { + while (optind < argc) + fprintf(stderr, "Unsupported positional arguments on command line %s\n", argv[optind++]); + exit(2); + } } int main(int argc, char **argv) diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index ff89478..76e79d9 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -163,10 +163,20 @@ cfg->usb.path = optarg; break; #endif + case '?': + /* unsupported/unrecognized argument */ + exit(2); + break; default: break; } } + + if (argc > optind) { + while (optind < argc) + fprintf(stderr, "Unsupported positional arguments on command line %s\n", argv[optind++]); + exit(2); + } } diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 3687f15..1821938 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -71,6 +71,10 @@ case 'L': log_set_use_color(osmo_stderr_target, 0); break; + case '?': + /* unsupported/unrecognized argument */ + exit(2); + break; default: /* ignore */ break; @@ -78,7 +82,8 @@ } if (argc > optind) { - fprintf(stderr, "Unsupported extra positional arguments in command line\n"); + while (optind < argc) + fprintf(stderr, "Unsupported positional arguments on command line %s\n", argv[optind++]); exit(2); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 Gerrit-Change-Number: 43352 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026