Attention is currently required from: fixeria, neels.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/43288?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria
Change subject: test_configurable_parameters: test less templates
......................................................................
test_configurable_parameters: test less templates
The tests take long and don't need to be this many.
A patch is coming up that adds another profile to test SUCI in GFM,
this patch makes some room for that.
Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67
Jenkins: skip-card-test
---
M tests/unittests/test_configurable_parameters.py
M tests/unittests/xo/test_configurable_parameters
2 files changed, 0 insertions(+), 1,402 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/43288/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43288?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67
Gerrit-Change-Number: 43288
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email )
Change subject: OM2K: Check bounds of OM2K Negotiation Request
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/43293/comment/8e95d248_20002093?usp… :
PS1, Line 2777: uint8_t *cur = o2h->data+3;
> You are accessing msg already here before the first check you added in 2785, are you sure this is co […]
o2h points to l2 pointer of msg.
o2h->data points behind the o2h header.
o2h->data+3 points 3 bytes after the o2h header.
I am not accessing anything, just setting a pointer (cur) with an offset ahead of the l2 pointer of msg. This should not be a problem. Please correct me, if I am wrong.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed
Gerrit-Change-Number: 43293
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Aug 2026 18:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, dexter, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Code-Review+2 by daniel
Change subject: SGSN: Remove unsupport acl test cases
......................................................................
SGSN: Remove unsupport acl test cases
The functionality for ACL based authentication (only use
the IMSI, but don't request information from the HLR) will
be removed from the SGSN.
Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 181 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/39261/16
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
Gerrit-Change-Number: 39261
Gerrit-PatchSet: 16
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, lynxis lazus.
Hello Jenkins Builder, daniel, dexter, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: Remove unsupport test cases
......................................................................
SGSN: Remove unsupport test cases
The functionality for ACL based authentication (only use
the IMSI, but don't request information from the HLR) will
be removed from the SGSN.
Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 181 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/39261/15
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
Gerrit-Change-Number: 39261
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: remove TC_attach_no_imei_response
......................................................................
SGSN: remove TC_attach_no_imei_response
The SGSN doesn't request the IMEI via Identity Response anymore.
This information is requested via Authentication/Ciphering Req/Resp.
Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 48 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/39260/15
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
Gerrit-Change-Number: 39260
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: SGSN_Tests: fix TC_sgsn_context_req_out
......................................................................
SGSN_Tests: fix TC_sgsn_context_req_out
The TC_sgsn_context_req_out wasn't complete when merged
and didn't work as expected.
Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
---
M sgsn/SGSN_Tests.ttcn
M sgsn/gen_links.sh
2 files changed, 151 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/39017/12
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email )
Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce
Gerrit-Change-Number: 43346
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 20 Aug 2026 16:07:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes