Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email )
Change subject: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is detached
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia74407c34576bfcc1f4ab9d1940b500da86cfbab
Gerrit-Change-Number: 43390
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Aug 2026 07:39:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, lynxis lazus, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/43433?usp=email )
Change subject: vlr: send RAT type in GSUP ULR
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
1 + 1 = 2 (Pau already voted +1 before I updated the commit message slightly)
PS2:
> This may cause some TTCN-3 tests to fail, because our GSUP templates are not flexible enough to matc […]
Ack. I ran the whole msc ttcn3 testsuite with this patch and almost had the same result as in the `ttcn3-msc-test` jenkins job.
`<testsuite name='Titan' tests='240' failures='6' errors='0' skipped='0' inconc='0' time='1209.00'>`
There was one additional failure in `TC_sgsap_paging_and_nothing` that did not fail in master. But it passed when I ran it separately or in combination with the test before, so it seems to be a race condition and unrelated to the patch here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43433?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia290f483fb5a564396e7665a7eebe633db93ee65
Gerrit-Change-Number: 43433
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 07:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43434?usp=email )
Change subject: deps/Makefile: Update to newer PFCP with change in one field name
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43434?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibb863b7607c603ea7be09e24073da2e19b7fdcbb
Gerrit-Change-Number: 43434
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Aug 2026 07:12:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email )
Change subject: smf: Implement PFCP Sess Est and Sess Del procedures
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File smf/SMF_Session_CT.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378/comment/0cbf30d5_755e… :
PS7, Line 680: f_pfcp_sess_del_resp
> No, I meant the function body is somehow tabulated twice...
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d
Gerrit-Change-Number: 43378
Gerrit-PatchSet: 9
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Aug 2026 20:02:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43436?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: smf: Implement TC_gy_ccr_update_rejected
......................................................................
smf: Implement TC_gy_ccr_update_rejected
Add missing code to have a successful TC_gy_ccr_update_rejected.
Change-Id: I9ad9fb1520f8a2163ed90e8ca5c121edcb267006
---
M library/PFCP_Templates.ttcn
M smf/SMF_Session_CT.ttcn
M smf/SMF_Tests.ttcn
3 files changed, 489 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/43436/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43436?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9ad9fb1520f8a2163ed90e8ca5c121edcb267006
Gerrit-Change-Number: 43436
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder