August 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email ) Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I see no reference to tcap-unroutable-sessions VTY command -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 21 Aug 2026 09:06:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email ) Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... Patch Set 2: (6 comments) File common/chapters/sigtran-osmocom.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/45d0bb88_18f9… : PS2, Line 197: The Osmocom SIGTRAN stack supports TCAP-aware routing as described above I'd probably keep IPA specialties in a separate subsection. https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/93d9c43c_2abb… : PS2, Line 212: ===== TCAP range management TCAP range management on IPA ASPs https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/7ac1849e_dc3e… : PS2, Line 216: identifier set to IPAC_PROTO_OSMO (0xEE). The extension header inside has the You can probably format the enums and values with "_" or whatever you find in docs around here. https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/f2b1847a_5291… : PS2, Line 234: as well as a point code and subsystem number to restrict this range to. Point Code (PC), Subsystem Number (SSN) I had to think what "subsystem number" meant here ;) https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/2372e364_f99c… : PS2, Line 282: Ranges are removed when an ASP disconnects, there is currently no other way to what does "ASP disconnect" mean here exactly? https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190/comment/e53e5843_908b… : PS2, Line 287: If you're not an SS7 expert, and all you want is to run your own small I'm missing something explaining UDTS messages will be sent back under some situations iirc. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 21 Aug 2026 09:05:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in onomondo-eim[master]: mnesia_db_rest: add comment on why we create an euicc entry early
by jolly 21 Aug '26

21 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42991?usp=email ) Change subject: mnesia_db_rest: add comment on why we create an euicc entry early ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ifb9340655c5f36e074a1a92c0e234ef62c79b9d8 Gerrit-Change-Number: 42991 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Aug 2026 09:03:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: mnesia_db_euicc: rename timer_setparam to timer_rest
by jolly 21 Aug '26

21 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42960?usp=email ) Change subject: mnesia_db_euicc: rename timer_setparam to timer_rest ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Icfa203477e044ce2cc312d4b6e2693a97191c61d Gerrit-Change-Number: 42960 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Aug 2026 08:56:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: esipa_asn1_handler_utils: rename EsipaReq to Debuginfo
by jolly 21 Aug '26

21 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42949?usp=email ) Change subject: esipa_asn1_handler_utils: rename EsipaReq to Debuginfo ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I8115d382172989b9ef7ae7f97ce39520e3e2dd16 Gerrit-Change-Number: 42949 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Aug 2026 08:42:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: esipa: supply eimTransactionId in profileDownloadTriggerRequest
by jolly 21 Aug '26

21 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42948?usp=email ) Change subject: esipa: supply eimTransactionId in profileDownloadTriggerRequest ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I822d6b2bb51498713739671804b173260e9a28a3 Gerrit-Change-Number: 42948 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Aug 2026 08:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: esipa: rename TransactionId to EimTransactionId where applicable
by jolly 21 Aug '26

21 Aug '26

Attention is currently required from: dexter, fixeria. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42947?usp=email ) Change subject: esipa: rename TransactionId to EimTransactionId where applicable ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ia97f96c27d5dc4405effd5266de4cdb797849699 Gerrit-Change-Number: 42947 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Aug 2026 08:31:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: OM2K: Check bounds of OM2K Negotiation Request
by jolly 21 Aug '26

21 Aug '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email ) Change subject: OM2K: Check bounds of OM2K Negotiation Request ...................................................................... OM2K: Check bounds of OM2K Negotiation Request Check if message length and array sizes are large enough to read and store IWD versions while parsing OM2K Negotiation Request. This prevents out-of-bounds read and write, if message is corrupted. Related: OS#7057 Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed --- M src/osmo-bsc/abis_om2000.c 1 file changed, 28 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index 69a86b5..825c68a 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -2773,7 +2773,7 @@ struct gsm_bts *bts = sign_link->trx->bts; struct abis_om2k_hdr *o2h = msgb_l2(msg); struct iwd_type iwd_types[16]; - uint8_t num_iwd_types = o2h->data[2]; + uint8_t num_iwd_types; uint8_t *cur = o2h->data+3; unsigned int i; int v; @@ -2782,18 +2782,43 @@ uint8_t *out_cur = out_buf+1; uint8_t out_num_types = 0; + if (msgb_l2len(msg) < sizeof(*o2h) + 3) { + LOGP(DNM, LOGL_ERROR, "Message too short\n"); + return -EINVAL; + } + num_iwd_types = o2h->data[2]; + memset(iwd_types, 0, sizeof(iwd_types)); /* Parse the RBS-supported IWD versions into iwd_types array */ for (i = 0; i < num_iwd_types; i++) { - uint8_t num_versions = *cur++; - uint8_t iwd_type = *cur++; + uint8_t num_versions, iwd_type; + + if (cur + 2 > (uint8_t *)msgb_l2(msg) + msgb_l2len(msg)) { + LOGP(DNM, LOGL_ERROR, "Message too short\n"); + return -EINVAL; + } + num_versions = *cur++; + iwd_type = *cur++; + + if (num_versions > ARRAY_SIZE(iwd_types[0].v)) { + LOGP(DNM, LOGL_ERROR, "Num versions %u out of range\n", num_versions); + return -EINVAL; + } + if (iwd_type >= ARRAY_SIZE(iwd_types)) { + LOGP(DNM, LOGL_ERROR, "IWD Type %u out of range\n", iwd_type); + return -EINVAL; + } iwd_types[iwd_type].num_vers = num_versions; for (v = 0; v < num_versions; v++) { struct iwd_version *iwd_v = &iwd_types[iwd_type].v[v]; + if (cur + 6 > (uint8_t *)msgb_l2(msg) + msgb_l2len(msg)) { + LOGP(DNM, LOGL_ERROR, "Message too short\n"); + return -EINVAL; + } memcpy(iwd_v->gen_char, cur, 3); cur += 3; memcpy(iwd_v->rev_char, cur, 3); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed Gerrit-Change-Number: 43293 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: f_routing_area_update: add authentication argument
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email ) Change subject: SGSN: f_routing_area_update: add authentication argument ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7125ed8aa81fbda48a19f7f4fc711bc1bf2c875f Gerrit-Change-Number: 39018 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 21 Aug 2026 08:24:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix TC_sgsn_context_req_out
by pespin 21 Aug '26

21 Aug '26

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email ) Change subject: SGSN_Tests: fix TC_sgsn_context_req_out ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 21 Aug 2026 08:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026