August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: xua_snm: Fix mask_from_affected_pc() always returning 0
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: xua_snm: Fix mask_from_affected_pc() always returning 0 ...................................................................... xua_snm: Fix mask_from_affected_pc() always returning 0 A recent commit adding the mask_from_affected_pc() mistyped the aff_pc converting it to a uint8_t, which is wrong. Fix it. Related: Coverity CID#563282 Related: OS#7078 Fixes: 41af6a55110d6ddc5febce71d5bba3cf0f33f27e Change-Id: Id376528802662b8ea53845158e73a1f730e6c590 --- M src/xua_snm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/42/43442/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id376528802662b8ea53845158e73a1f730e6c590 Gerrit-Change-Number: 43442 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: constify xua_msg param in xua_snm_rx_*
by fixeria 31 Aug '26

31 Aug '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43225?usp=email ) Change subject: xua_snm: constify xua_msg param in xua_snm_rx_* ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e5844a6f0d40c1df3ae31955bb8b24d891d86b1 Gerrit-Change-Number: 43225 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Aug 2026 09:03:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: lint: checkpatch: escape gerrit markdown chars
by fixeria 31 Aug '26

31 Aug '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43445?usp=email ) Change subject: lint: checkpatch: escape gerrit markdown chars ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9cf1705fc17873c90b57725227a1a6a3d4cd699 Gerrit-Change-Number: 43445 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Aug 2026 08:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: lint/checkpatch/checkpatch_json: format with ruff
by fixeria 31 Aug '26

31 Aug '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43444?usp=email ) Change subject: lint/checkpatch/checkpatch_json: format with ruff ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie67fce9de101fd58db0af4e5fe54922a54ce2c9b Gerrit-Change-Number: 43444 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Aug 2026 08:24:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: xua_snm: Fix mask_from_affected_pc() always returning 0
by osmith 31 Aug '26

31 Aug '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442?usp=email ) Change subject: xua_snm: Fix mask_from_affected_pc() always returning 0 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442/comment/632a621a_37870… : PS1, Line 10: uint32_t I guess you mean: ```suggestion converting it to a uint8_t, which is wrong. Fix it. ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id376528802662b8ea53845158e73a1f730e6c590 Gerrit-Change-Number: 43442 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Aug 2026 08:22:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: (do not merge) testing CI
by osmith 31 Aug '26

31 Aug '26

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/43443?usp=email ) Change subject: (do not merge) testing CI ...................................................................... Abandoned this was an example for https://gerrit.osmocom.org/c/osmo-ci/+/43445 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3c0cd5f6e13dfc22303eadeb347854c17e4a6e8b Gerrit-Change-Number: 43443 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-ci[master]: lint: checkpatch: escape gerrit markdown chars
by osmith 31 Aug '26

31 Aug '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43445?usp=email ) Change subject: lint: checkpatch: escape gerrit markdown chars ...................................................................... lint: checkpatch: escape gerrit markdown chars Fix that some messages look wrong in gerrit, for example: "foo* bar" should be "foo *bar" The asterisk symbols would be removed and the text between them would be displayed in cursive. Example: https://gerrit.osmocom.org/c/libosmocore/+/43443/comment/ad7b209c_7b2929c1/ Change-Id: Ic9cf1705fc17873c90b57725227a1a6a3d4cd699 --- M lint/checkpatch/checkpatch_json.py 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/45/43445/1 diff --git a/lint/checkpatch/checkpatch_json.py b/lint/checkpatch/checkpatch_json.py index c4ea3b0..c35c4f3 100755 --- a/lint/checkpatch/checkpatch_json.py +++ b/lint/checkpatch/checkpatch_json.py @@ -16,6 +16,14 @@ list_temp = {} +def gerrit_markdown_escape(msg): + """Escape characters that would get interpreted as markdown syntax in + gerrit comments. For example: "foo* bar" should be "foo *bar" """ + msg = msg.replace("*", "\\*") + msg = msg.replace("`", "\\`") + return msg + + def update_struct(file_path, msg_output, line_number): if file_path not in list_temp: list_temp[file_path] = [] @@ -24,7 +32,7 @@ "robot_run_id": sys.argv[3], "url": sys.argv[4], "line": line_number, - "message": msg_output, + "message": gerrit_markdown_escape(msg_output), } if error not in list_temp[file_path]: list_temp[file_path].append(error) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9cf1705fc17873c90b57725227a1a6a3d4cd699 Gerrit-Change-Number: 43445 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: lint/checkpatch/checkpatch_json: format with ruff
by osmith 31 Aug '26

31 Aug '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43444?usp=email ) Change subject: lint/checkpatch/checkpatch_json: format with ruff ...................................................................... lint/checkpatch/checkpatch_json: format with ruff Change-Id: Ie67fce9de101fd58db0af4e5fe54922a54ce2c9b --- M .ruff.toml M lint/checkpatch/checkpatch_json.py 2 files changed, 16 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/44/43444/1 diff --git a/.ruff.toml b/.ruff.toml index 1cfd21b..14e05db 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -2,7 +2,6 @@ [format] exclude = [ - "lint/checkpatch/checkpatch_json.py", "scripts/jenkins-gerrit/comment_generate.py", "scripts/obs/build_binpkg.py", "scripts/obs/build_srcpkg.py", diff --git a/lint/checkpatch/checkpatch_json.py b/lint/checkpatch/checkpatch_json.py index e0c4dcd..c4ea3b0 100755 --- a/lint/checkpatch/checkpatch_json.py +++ b/lint/checkpatch/checkpatch_json.py @@ -7,28 +7,31 @@ INPUT: output of checkpatch.pl. OUTPUT: json format output that can be used to post comment in gerrit """ + import sys import json data = {} -data['comments'] = [] +data["comments"] = [] list_temp = {} -def update_struct( file_path, msg_output, line_number): + +def update_struct(file_path, msg_output, line_number): if file_path not in list_temp: list_temp[file_path] = [] error = { - "robot_id" : "checkpatch", - "robot_run_id" : sys.argv[3], - "url" : sys.argv[4], - "line" : line_number, - "message" : msg_output, + "robot_id": "checkpatch", + "robot_run_id": sys.argv[3], + "url": sys.argv[4], + "line": line_number, + "message": msg_output, } if error not in list_temp[file_path]: list_temp[file_path].append(error) + def parse_file(input_file): - fp = open (input_file, "r") + fp = open(input_file, "r") for line in fp: if line.startswith("ERROR:"): msg_output = line.split("ERROR:")[1].strip() @@ -38,11 +41,12 @@ temp = line.split("FILE:") file_path = temp[1].split(":")[0] line_number = temp[1].split(":")[1] - update_struct( file_path.strip(), msg_output, str(line_number) ) + update_struct(file_path.strip(), msg_output, str(line_number)) else: continue fp.close() + def main(): if (len(sys.argv) < 5) or (sys.argv[1] == "-h"): print("HELP:") @@ -51,11 +55,12 @@ print(sys.argv[1]) parse_file(sys.argv[1]) - data['robot_comments'] = list_temp + data["robot_comments"] = list_temp print(json.dumps(data)) - out_file = open( sys.argv[2] , "w") + out_file = open(sys.argv[2], "w") json.dump(data, out_file, sort_keys=True, indent=4) out_file.close() + if __name__ == "__main__": main() -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie67fce9de101fd58db0af4e5fe54922a54ce2c9b Gerrit-Change-Number: 43444 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: (do not merge) testing CI
by osmith 31 Aug '26

31 Aug '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43443?usp=email ) Change subject: (do not merge) testing CI ...................................................................... (do not merge) testing CI Change-Id: I3c0cd5f6e13dfc22303eadeb347854c17e4a6e8b --- M src/core/fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/43/43443/1 diff --git a/src/core/fsm.c b/src/core/fsm.c index 54cea99..4809797 100644 --- a/src/core/fsm.c +++ b/src/core/fsm.c @@ -233,7 +233,7 @@ talloc_steal(fsm_term_safely.collect_ctx, talloc_object); } -struct osmo_fsm *osmo_fsm_find_by_name(const char *name) +struct osmo_fsm *osmo_fsm_find_by_name(const char* name) { struct osmo_fsm *fsm; llist_for_each_entry(fsm, &osmo_g_fsms, list) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3c0cd5f6e13dfc22303eadeb347854c17e4a6e8b Gerrit-Change-Number: 43443 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_snm: Fix mask_from_affected_pc() always returning 0
by pespin 31 Aug '26

31 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442?usp=email ) Change subject: xua_snm: Fix mask_from_affected_pc() always returning 0 ...................................................................... xua_snm: Fix mask_from_affected_pc() always returning 0 A recent commit adding the mask_from_affected_pc() mistyped the aff_pc converting it to a uint32_t, which is wrong. Fix it. Related: Coverity CID#563282 Related: OS#7078 Fixes: 41af6a55110d6ddc5febce71d5bba3cf0f33f27e Change-Id: Id376528802662b8ea53845158e73a1f730e6c590 --- M src/xua_snm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/42/43442/1 diff --git a/src/xua_snm.c b/src/xua_snm.c index 3aa067e..609cd95 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -53,7 +53,7 @@ * This prevents creating incorrect bitmasks and ending up in long loops based on peer * inputting unexpected big values (ie. >14 on ITU and >24 on ANSI). */ -static uint8_t mask_from_affected_pc(const struct osmo_ss7_instance *s7i, uint8_t aff_pc) +static uint8_t mask_from_affected_pc(const struct osmo_ss7_instance *s7i, uint32_t aff_pc) { const uint8_t pc_width = osmo_ss7_pc_width(&s7i->cfg.pc_fmt); uint8_t mask = aff_pc >> 24; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id376528802662b8ea53845158e73a1f730e6c590 Gerrit-Change-Number: 43442 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026