Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43404?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Update copyright notice in all files
......................................................................
Update copyright notice in all files
Change-Id: I0be68590607d88140c6b478fb4a88d2354cd0605
---
M CMakeLists.txt
M include/onomondo/ipa/http.h
M include/onomondo/ipa/http_hdr.h
M include/onomondo/ipa/ipad.h
M include/onomondo/ipa/log.h
M include/onomondo/ipa/mem.h
M include/onomondo/ipa/scard.h
M include/onomondo/ipa/utils.h
M src/CMakeLists.txt
M src/ipa/CMakeLists.txt
M src/ipa/http.c
M src/ipa/libipa/CMakeLists.txt
M src/ipa/libipa/activation_code.c
M src/ipa/libipa/activation_code.h
M src/ipa/libipa/bpp_segments.c
M src/ipa/libipa/bpp_segments.h
M src/ipa/libipa/context.h
M src/ipa/libipa/es10a_get_euicc_cfg_addr.c
M src/ipa/libipa/es10a_get_euicc_cfg_addr.h
M src/ipa/libipa/es10b_add_init_eim.c
M src/ipa/libipa/es10b_add_init_eim.h
M src/ipa/libipa/es10b_auth_serv.c
M src/ipa/libipa/es10b_auth_serv.h
M src/ipa/libipa/es10b_cancel_session.c
M src/ipa/libipa/es10b_cancel_session.h
M src/ipa/libipa/es10b_euicc_mem_rst.c
M src/ipa/libipa/es10b_euicc_mem_rst.h
M src/ipa/libipa/es10b_get_certs.c
M src/ipa/libipa/es10b_get_certs.h
M src/ipa/libipa/es10b_get_eim_cfg_data.c
M src/ipa/libipa/es10b_get_eim_cfg_data.h
M src/ipa/libipa/es10b_get_euicc_chlg.c
M src/ipa/libipa/es10b_get_euicc_chlg.h
M src/ipa/libipa/es10b_get_euicc_info.c
M src/ipa/libipa/es10b_get_euicc_info.h
M src/ipa/libipa/es10b_get_rat.c
M src/ipa/libipa/es10b_get_rat.h
M src/ipa/libipa/es10b_immediate_enable.c
M src/ipa/libipa/es10b_immediate_enable.h
M src/ipa/libipa/es10b_load_bnd_prfle_pkg.c
M src/ipa/libipa/es10b_load_bnd_prfle_pkg.h
M src/ipa/libipa/es10b_load_euicc_pkg.c
M src/ipa/libipa/es10b_load_euicc_pkg.h
M src/ipa/libipa/es10b_prep_dwnld.c
M src/ipa/libipa/es10b_prep_dwnld.h
M src/ipa/libipa/es10b_prfle_rollback.c
M src/ipa/libipa/es10b_prfle_rollback.h
M src/ipa/libipa/es10b_retr_notif_from_lst.c
M src/ipa/libipa/es10b_retr_notif_from_lst.h
M src/ipa/libipa/es10b_rm_notif_from_lst.c
M src/ipa/libipa/es10b_rm_notif_from_lst.h
M src/ipa/libipa/es10c_delete_prfle.c
M src/ipa/libipa/es10c_delete_prfle.h
M src/ipa/libipa/es10c_disable_prfle.c
M src/ipa/libipa/es10c_disable_prfle.h
M src/ipa/libipa/es10c_enable_prfle.c
M src/ipa/libipa/es10c_enable_prfle.h
M src/ipa/libipa/es10c_get_eid.c
M src/ipa/libipa/es10c_get_eid.h
M src/ipa/libipa/es10c_get_prfle_info.c
M src/ipa/libipa/es10c_get_prfle_info.h
M src/ipa/libipa/es10x.c
M src/ipa/libipa/es10x.h
M src/ipa/libipa/esipa.c
M src/ipa/libipa/esipa.h
M src/ipa/libipa/esipa_auth_clnt.c
M src/ipa/libipa/esipa_auth_clnt.h
M src/ipa/libipa/esipa_cancel_session.c
M src/ipa/libipa/esipa_cancel_session.h
M src/ipa/libipa/esipa_get_bnd_prfle_pkg.c
M src/ipa/libipa/esipa_get_bnd_prfle_pkg.h
M src/ipa/libipa/esipa_get_eim_pkg.c
M src/ipa/libipa/esipa_get_eim_pkg.h
M src/ipa/libipa/esipa_handle_notif.c
M src/ipa/libipa/esipa_handle_notif.h
M src/ipa/libipa/esipa_init_auth.c
M src/ipa/libipa/esipa_init_auth.h
M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c
M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.h
M src/ipa/libipa/euicc.c
M src/ipa/libipa/euicc.h
M src/ipa/libipa/ipad.c
M src/ipa/libipa/length.h
M src/ipa/libipa/log.c
M src/ipa/libipa/proc_cmn_cancel_sess.c
M src/ipa/libipa/proc_cmn_cancel_sess.h
M src/ipa/libipa/proc_cmn_mtl_auth.c
M src/ipa/libipa/proc_cmn_mtl_auth.h
M src/ipa/libipa/proc_eim_pkg_retr.c
M src/ipa/libipa/proc_eim_pkg_retr.h
M src/ipa/libipa/proc_euicc_data_req.c
M src/ipa/libipa/proc_euicc_data_req.h
M src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c
M src/ipa/libipa/proc_euicc_pkg_dwnld_exec.h
M src/ipa/libipa/proc_indirect_prfle_dwnld.c
M src/ipa/libipa/proc_indirect_prfle_dwnld.h
M src/ipa/libipa/proc_notif_delivery.c
M src/ipa/libipa/proc_notif_delivery.h
M src/ipa/libipa/proc_prfle_dwnld.c
M src/ipa/libipa/proc_prfle_dwnld.h
M src/ipa/libipa/proc_prfle_inst.c
M src/ipa/libipa/proc_prfle_inst.h
M src/ipa/libipa/utils.c
M src/ipa/libipa/utils.h
M src/ipa/main.c
M src/ipa/scard.c
M tests/CMakeLists.txt
M tests/activation_code/CMakeLists.txt
M tests/activation_code/activation_code_test.c
M tests/bpp_segments/CMakeLists.txt
M tests/bpp_segments/bpp_segments_test.c
M tests/utils/CMakeLists.txt
M tests/utils/utils_test.c
113 files changed, 113 insertions(+), 113 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/04/43404/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43404?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0be68590607d88140c6b478fb4a88d2354cd0605
Gerrit-Change-Number: 43404
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter, jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Verified+1 by Jenkins Builder
Change subject: Update README.md related to the current command line parameters
......................................................................
Update README.md related to the current command line parameters
Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485
---
M README.md
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/03/43403/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485
Gerrit-Change-Number: 43403
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email )
Change subject: firmware: Implement debug command via USB control vendor class
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
Patchset:
PS12:
ping? Is it difficult to fix the linter issues, or is there a problem with the linter? This has been sitting for two weeks without any progess on getting V+1
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6
Gerrit-Change-Number: 43005
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 26 Aug 2026 21:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email )
(
8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: V1.2: Add function to set Device Capabilities
......................................................................
V1.2: Add function to set Device Capabilities
Add new library function to set the SGP.22 Device Capabilities. Also
add an option to the command line interface to call the library
function.
The IoT device (modem) may and the IPA must set Device Capabilities.
They cannot be set independently. The IoT device would overwrite what
IPA has set and vice versa. Therefore add a library function for the
IoT device that takes care about setting the required capabilities for
IPA.
Reference: SGP.22 Section 3.4.2
Related: SYS#8101
Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
---
M include/onomondo/ipa/ipad.h
M src/ipa/libipa/euicc.c
M src/ipa/main.c
3 files changed, 15 insertions(+), 2 deletions(-)
Approvals:
dexter: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/onomondo/ipa/ipad.h b/include/onomondo/ipa/ipad.h
index 42086fa..8bea1d8 100644
--- a/include/onomondo/ipa/ipad.h
+++ b/include/onomondo/ipa/ipad.h
@@ -86,6 +86,12 @@
* function here to handle the consent request. In case no callback function is provided onomondo-eim will
* automatically consent to any profile installation. */
ipa_prfle_inst_consent_cb prfle_inst_consent_cb;
+
+ /*! Set the Device Capabilities.
+ * As IPAd need to set the device capabilities, it overwrites any other capabilities that might have set by
+ * the modem or IoT device. The upper 5 bits can be set according to section 3.4.2 of SGG.22. The lower 3
+ * bit are set automatically by this IPAd. */
+ uint8_t device_capabilities;
};
struct ipa_context *ipa_new_ctx(struct ipa_config *cfg, struct ipa_buf *nvstate);
diff --git a/src/ipa/libipa/euicc.c b/src/ipa/libipa/euicc.c
index cfeda30..e6cc5fc 100644
--- a/src/ipa/libipa/euicc.c
+++ b/src/ipa/libipa/euicc.c
@@ -532,12 +532,14 @@
* \returns 0 on success, negative on error. */
int ipa_euicc_init_es10x(struct ipa_context *ctx)
{
- /* Capabilities according to 3GPP TS 102.221, section 11.1.19.2.4 and GSMA SGP.32, section 3.8.2 */
+ /* Capabilities according to 3GPP TS 102.221, section 11.1.19.2.4 and
+ * GSMA SGP.22, section 3.4.2 and GSMA SGP.32, section 3.8.2 */
uint8_t termcap[] = { 0xA9, 0x06, 0x83, 0x01, 0x07, 0x84, 0x01, 0x01 };
size_t termcap_size = sizeof(termcap);
int rc;
/* Set capabilities to enable support for eUICC and IoT functions. */
+ termcap[4] |= ctx->cfg->device_capabilities;
/* A non-IoT eUICC does not have IoT capabilities. */
if (ctx->cfg->iot_euicc_emu_enabled) {
termcap[1] -= 3;
diff --git a/src/ipa/main.c b/src/ipa/main.c
index 4a61762..9ad3fbc 100644
--- a/src/ipa/main.c
+++ b/src/ipa/main.c
@@ -69,6 +69,7 @@
printf(" -I .......................... disable SSL certificate verification (insecure)\n");
printf(" -E .......................... emulate IoT eUICC (compatibility mode to use consumer eUICCs)\n");
printf(" -1 .......................... force the IPAd to process only one eUICC package (debug, use with caution)\n");
+ printf(" -D 0xXX ..................... set optional device capabilities (SGP.22, table 7, bits 8..4)\n");
printf("operation:\n");
printf(" get-eim-package ............. Ask eIM for eIM package and process it (default operation)\n");
printf(" add-initial-eim PATH ........ set initial eIM configuration from given file\n");
@@ -179,7 +180,7 @@
/* Overwrite configuration values with user defined parameters */
while (1) {
- opt = getopt(argc, argv, "ht:e:r:c:Rn:C:SIEy:a1");
+ opt = getopt(argc, argv, "ht:e:r:c:Rn:C:SIEy:a1D:");
if (opt == -1)
break;
@@ -227,6 +228,9 @@
case '1':
getopt_one_euicc_pkg_only = true;
break;
+ case 'D':
+ cfg.device_capabilities = strtoul(optarg, NULL, 0);
+ break;
default:
printf("unsupported option: %c!\n", opt);
opt = -1;
@@ -281,6 +285,7 @@
printf(" tac = %s\n", ipa_hexdump(cfg.tac, sizeof(cfg.tac)));
printf(" iot_euicc_emu_enabled = %u\n", cfg.iot_euicc_emu_enabled);
printf(" esipa_req_retries = %u\n", cfg.esipa_req_retries);
+ printf(" device_capabilities = 0x%02x\n", cfg.device_capabilities);
printf("\n");
if (cfg.eim_cabundle) {
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
Gerrit-Change-Number: 43060
Gerrit-PatchSet: 12
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>