April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: Remove unconditional assignment of asn_debug = 0
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email ) Change subject: Remove unconditional assignment of asn_debug = 0 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:47:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: asn1: move asn_debug into librspro
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email ) Change subject: asn1: move asn_debug into librspro ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icb03e8905f3b38ecebfcf294727a01f994511cce Gerrit-Change-Number: 42707 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:46:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/rspro_util.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/33adbc64_e7d3b295?… : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); You decided to free pdu here in case of encoding failure. Look inside the users worker_send_rspro(), cli_conn_send_rspro() and client_conn_send(), they will double free in case of a failure. https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/3a1ea97e_9a0852a2?… : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); Same issue here. This casues a double free. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:26:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: asn1: ber_decoder: disable stack size check on ctx = NULL
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email ) Change subject: asn1: ber_decoder: disable stack size check on ctx = NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 Gerrit-Change-Number: 42706 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:26:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: asn1: move asn_debug into librspro
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: asn1: move asn_debug into librspro ...................................................................... asn1: move asn_debug into librspro To allow compiling the asn code with `-DEMIT_ASN_DEBUG=1`. Otherwise it will fail with an unresolved symbol because librspro is compiled as shared-object. Further initialize it as disable (0). Change-Id: Icb03e8905f3b38ecebfcf294727a01f994511cce --- M src/asn1c_helpers.c M src/asn1c_helpers.h M src/bankd/bankd_main.c M src/bankd/main.c M src/client/remsim_client_main.c 5 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/07/42707/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icb03e8905f3b38ecebfcf294727a01f994511cce Gerrit-Change-Number: 42707 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Patch Set 5: (1 comment) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42665/comment/e5f5cf90_77195037?… : PS5, Line 1073: signal(SIGPIPE, handle_sig_pipe); maybe move this into the general main.c where the other signal are also setup it? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 13:56:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-remsim[master]: Fix: Remove slot mapping at bankd when client disconnects
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email ) Change subject: Fix: Remove slot mapping at bankd when client disconnects ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 Gerrit-Change-Number: 42645 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 13:54:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email ) Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 13:53:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Remove unconditional assignment of asn_debug = 0
by lynxis lazus 27 Apr '26

27 Apr '26

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email ) Change subject: Remove unconditional assignment of asn_debug = 0 ...................................................................... Remove unconditional assignment of asn_debug = 0 It is now the default and there is no code to set it. Remove the assignment Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a --- M src/bankd/bankd_main.c M src/bankd/main.c M src/client/remsim_client_main.c 3 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/08/42708/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026