April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: don't use axis
by osmith 14 Apr '26

14 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42608?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: don't use axis ...................................................................... jobs/octsim_osmo-ccid-firmware: don't use axis There is only one node, so we can specify it directly instead of using a build axis. Change-Id: I552c8f1b244c8e8b0f902720698fbb6ba660fb72 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/42608/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index e64e7ea..c777fe0 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -1,10 +1,5 @@ - job: - axes: - - axis: - name: label - type: slave - values: - - octsimtest + node: octsimtest block-downstream: false block-upstream: false parameters: @@ -24,7 +19,6 @@ execution-strategy: sequential: false name: octsim_osmo-ccid-firmware - project-type: matrix scm: - git: url: https://gerrit.osmocom.org/osmo-ccid-firmware -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I552c8f1b244c8e8b0f902720698fbb6ba660fb72 Gerrit-Change-Number: 42608 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: various tweaks
by osmith 14 Apr '26

14 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42609?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: various tweaks ...................................................................... jobs/octsim_osmo-ccid-firmware: various tweaks * move name and desc up (in preparation to adding another job in the same file) * remove "concurrent: false": the octsimtest node is already configured to only accept one job. if we had multiple octsimtest nodes, we wouldn't need this limitation of not running concurrently, so this isn't useful. * remove options without effect (block-downstream, block-upstream, disabled, build-blocker, etc.) * add "scm checkout" comment to retry-count as we have it in other files Change-Id: If64787efbe4a1305cd60941b69e9416960d056a2 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 5 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/09/42609/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index c777fe0..1491416 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -1,7 +1,9 @@ - job: + name: octsim_osmo-ccid-firmware + description: | + octsim osmo-ccid-firmware CI - flash every build to octsim and see if + it still works node: octsimtest - block-downstream: false - block-upstream: false parameters: - string: name: EMAIL_NOTIFICATIONS @@ -12,13 +14,6 @@ cd ./tests mkdir -p sysmo-octsim/dl timeout 30m ./run-tests - concurrent: false - description: octsim osmo-ccid-firmware CI - flash every build to octsim and see - if it still works - disabled: false - execution-strategy: - sequential: false - name: octsim_osmo-ccid-firmware scm: - git: url: https://gerrit.osmocom.org/osmo-ccid-firmware @@ -28,25 +23,16 @@ branches: - 'master' properties: - - build-blocker: - block-level: GLOBAL - blocking-jobs: [] - queue-scanning: DISABLED - use-build-blocker: false - build-discarder: days-to-keep: 30 num-to-keep: 120 - - rebuild: - auto-rebuild: false - rebuild-disabled: false publishers: - email: notify-every-unstable-build: true recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: true - retry-count: '3' + retry-count: 3 # scm checkout triggers: - reverse: jobs: master-osmo-ccid-firmware, - timed: H 22 * * * - wrappers: [] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If64787efbe4a1305cd60941b69e9416960d056a2 Gerrit-Change-Number: 42609 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add branch param
by osmith 14 Apr '26

14 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42611?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add branch param ...................................................................... jobs/octsim_osmo-ccid-firmware: add branch param Change-Id: I05321cd2c174060381e099aa49d5932f9cafdd28 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/11/42611/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index f7efa09..07046e0 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -6,6 +6,12 @@ node: octsimtest parameters: - string: + name: BRANCH + description: | + Branch of <code>osmo-ccid-firmware.git</code>, from which the + test code (<code>test</code> directory) gets read. + default: 'master' + - string: name: EMAIL_NOTIFICATIONS description: For failed build notifications, set to empty to disable default: 'jenkins-notifications(a)lists.osmocom.org jsteiger(a)sysmocom.de acouzens(a)sysmocom.de' @@ -21,7 +27,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'master' + - '$BRANCH' properties: - build-discarder: days-to-keep: 30 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I05321cd2c174060381e099aa49d5932f9cafdd28 Gerrit-Change-Number: 42611 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: PYTHONUNBUFFERED=1
by osmith 14 Apr '26

14 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42612?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: PYTHONUNBUFFERED=1 ...................................................................... jobs/octsim_osmo-ccid-firmware: PYTHONUNBUFFERED=1 Ensure that the python output is getting displayed directly when running in jenkins. Change-Id: Iffe74b270f33286f394db1be03e6ce1953aff4bf --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/42612/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 07046e0..79b403e 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -17,6 +17,7 @@ default: 'jenkins-notifications(a)lists.osmocom.org jsteiger(a)sysmocom.de acouzens(a)sysmocom.de' builders: - shell: | + export PYTHONUNBUFFERED=1 cd ./tests mkdir -p sysmo-octsim/dl timeout 30m ./run-tests -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iffe74b270f33286f394db1be03e6ce1953aff4bf Gerrit-Change-Number: 42612 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add email param
by fixeria 14 Apr '26

14 Apr '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42607?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add email param ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifcd580873479fc259119139d47447ba0e21b21f4 Gerrit-Change-Number: 42607 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 08:13:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add email param
by osmith 14 Apr '26

14 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42607?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add email param ...................................................................... jobs/octsim_osmo-ccid-firmware: add email param Allow configuring the email notifications before starting a job, so no notifications can be set while testing changes to the jenkins job. Add jenkins-notifications(a)lists.osmocom.org while at it, as we have it with almost all other jobs. Change-Id: Ifcd580873479fc259119139d47447ba0e21b21f4 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/07/42607/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 599acc1..e64e7ea 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -7,6 +7,11 @@ - octsimtest block-downstream: false block-upstream: false + parameters: + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: 'jenkins-notifications(a)lists.osmocom.org jsteiger(a)sysmocom.de acouzens(a)sysmocom.de' builders: - shell: | cd ./tests @@ -43,7 +48,7 @@ publishers: - email: notify-every-unstable-build: true - recipients: jsteiger(a)sysmocom.de acouzens(a)sysmocom.de + recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: true retry-count: '3' triggers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifcd580873479fc259119139d47447ba0e21b21f4 Gerrit-Change-Number: 42607 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: Check for protocol extension bit in message type at a central location
by jolly 13 Apr '26

13 Apr '26

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Check for protocol extension bit in message type at a central location ...................................................................... Check for protocol extension bit in message type at a central location Bits 8 and 7 of message type can be used as sequence number or have specific default values. The added check will verify the bits according to the prococol descriptor and Release version. The Rules for these bits are described in GSM TS 124.007, clause 11.2.3.2.1 for Release <= 98 and 11.2.3.2.2 for Release >= 99. There is also no need to clear bit 7 in message type for these protocols, as it is done already in gsm48_hdr_msg_type(). Some unit tests fail without fixes that are included in this patch. Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df --- M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_a.c M src/libmsc/msc_vgcs.c M tests/msc_vlr/msc_vlr_test_authen_reuse.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.c M tests/msc_vlr/msc_vlr_tests.h 9 files changed, 64 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/38579/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df Gerrit-Change-Number: 38579 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode
by fixeria 13 Apr '26

13 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email ) Change subject: assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode ...................................................................... assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode Change-Id: I1718994e25ff1349618bdb4660afbe735c5c3977 Related: aa959d74f ("assignment_fsm: check ipaccess channel mode support") --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 54a57aa..cae0425 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -442,7 +442,13 @@ return true; /* unknown channel mode */ } - return (feat->val & flag) != 0; + if (feat->val & flag) + return true; + + LOG_ASSIGNMENT(lchan->conn, LOGL_NOTICE, + "BTS does not support channel mode '%s'\n", + get_value_string(abis_nm_ipacc_chanm_desc, flag)); + return false; } static bool lchan_type_compat_with_mode(const struct gsm_lchan *lchan, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1718994e25ff1349618bdb4660afbe735c5c3977 Gerrit-Change-Number: 42600 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bsc[master]: handover_fsm: send_handover_performed(): check lchan != NULL
by fixeria 13 Apr '26

13 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42599?usp=email ) Change subject: handover_fsm: send_handover_performed(): check lchan != NULL ...................................................................... handover_fsm: send_handover_performed(): check lchan != NULL The target lchan is expected to be valid on HO_RESULT_OK, but it's still safer to check it against NULL before dereferencing. Change-Id: Iee734c98dc79681808e7d75360c208a941cc6821 Related: 107391d8c ("handover_fsm: fix send_handover_performed() using wrong lchan") --- M src/osmo-bsc/handover_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index cddb138..2017637 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -905,6 +905,11 @@ struct gsm0808_speech_codec sc; int rc; + if (lchan == NULL) { + LOG_HO(conn, LOGL_ERROR, "Target lchan is NULL, can't send HANDOVER PERFORMED!\n"); + return; + } + /* Cause 3.2.2.5 */ ho_perf_params.cause = GSM0808_CAUSE_HANDOVER_SUCCESSFUL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee734c98dc79681808e7d75360c208a941cc6821 Gerrit-Change-Number: 42599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bsc[master]: assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode
by fixeria 13 Apr '26

13 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email ) Change subject: assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1718994e25ff1349618bdb4660afbe735c5c3977 Gerrit-Change-Number: 42600 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 12 Apr 2026 22:34:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026