Attention is currently required from: fixeria.
falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email )
Change subject: firmware/se_k2xx: add board specific RF tables
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS2:
> This is already implemented and working. Here's the firmware boot log for K2xx: […]
Done
File src/target/firmware/board/se_k2xx/rf_tables.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/42604/comment/b62b2f2f_642c85bc?u… :
PS2, Line 30: uint8_t apc_offset = 48;
> Just to clarify: `APCOFF = 0x07F` is 127 in decimal, but you suggest 63. […]
Your comment in the new patch iteration is fine. For the structure of APCOFF register, see TWL3025_SWRS021.pdf document, section 5.3.6.5 on page 71. The low 6 bits are the APC offset (the number we are after here, and the field after which the register was named), but bit 0x40 is another, mostly unrelated setting. That other bit setting (ramp slope selection) is not factored out per-target in OBB, but it does not need to be: the current setting of 1 is correct for all currently supported targets.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Gerrit-Change-Number: 42604
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 11 Apr 2026 15:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: falconia.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: firmware/se_k2xx: add board specific AFC params
......................................................................
firmware/se_k2xx: add board specific AFC params
Set afc_slope to 405 and afc_initial_dac_value to -370, derived from
AFC parameter averages computed across TIFFS readings of 7 unique
SE K2xx units (5 x K200i + 1 x K205i + 1 x K220i).
Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Related: OS#5822
---
M src/target/firmware/Makefile
A src/target/firmware/board/se_k2xx/afcparams.c
2 files changed, 45 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/05/42605/3
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Gerrit-Change-Number: 42605
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Attention is currently required from: falconia.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: firmware/se_k2xx: add board specific RF tables
......................................................................
firmware/se_k2xx: add board specific RF tables
SE K2xx phones use a different PA than GTA0x/FCDEV3B, so the
compiled-in Tx ramp templates must match the actual hardware.
Replace the previously copied GTA0x ramps with values extracted
from the SE K2xx official firmware using the calextract tool
from the freecalypso-reveng repository:
https://www.freecalypso.org/hg/freecalypso-reveng/
The Tx levels tables are left unchanged, as they are believed to
be the same TI internal defaults across these designs.
Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Related: OS#5822
---
M src/target/firmware/Makefile
A src/target/firmware/board/se_k2xx/rf_tables.c
2 files changed, 576 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/04/42604/3
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Gerrit-Change-Number: 42604
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Attention is currently required from: falconia.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email )
Change subject: firmware/se_k2xx: add board specific RF tables
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
> You should also add reading of per-unit RF calibration tables from TIFFS, like it is done on gta0x a […]
This is already implemented and working. Here's the firmware boot log for K2xx:
```
Checking TIFFS for the RF calibration records
Found '/gsm/rf/afcdac', applying
Found '/gsm/rf/tx/ramps.900', applying
Found '/gsm/rf/tx/levels.900', applying
Found '/gsm/rf/tx/calchan.900', applying
Found '/gsm/rf/tx/ramps.1800', applying
Found '/gsm/rf/tx/levels.1800', applying
Found '/gsm/rf/tx/calchan.1800', applying
```
File src/target/firmware/board/se_k2xx/rf_tables.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/42604/comment/d39efbe1_224b7bab?u… :
PS2, Line 30: uint8_t apc_offset = 48;
> If you look at `reg-read` file in the same directory where you found rf_XXX. […]
Just to clarify: `APCOFF = 0x07F` is 127 in decimal, but you suggest 63. How did you calculate that value? I assume you used some formula, so I trust you here and modified the patch to use 63 and added a comment that it's derived from `APCOFF`.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Gerrit-Change-Number: 42604
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Sat, 11 Apr 2026 09:06:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Attention is currently required from: falconia.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email )
Change subject: firmware/se_k2xx: add board specific AFC params
......................................................................
Patch Set 2:
(1 comment)
File src/target/firmware/board/se_k2xx/afcparams.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/42605/comment/c0d7030e_ff8a8b70?u… :
PS2, Line 42: int16_t afc_initial_dac_value = -2957;
> DAC center, min and max numbers in TI's afcparams table are written with a left shift of 3 bits! (Mo […]
Done, thanks! I missed that.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Gerrit-Change-Number: 42605
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Sat, 11 Apr 2026 09:06:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Attention is currently required from: fixeria.
falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email )
Change subject: firmware/se_k2xx: add board specific AFC params
......................................................................
Patch Set 2:
(1 comment)
File src/target/firmware/board/se_k2xx/afcparams.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/42605/comment/d9688561_172d5d1d?u… :
PS2, Line 42: int16_t afc_initial_dac_value = -2957;
DAC center, min and max numbers in TI's afcparams table are written with a left shift of 3 bits! (More precisely, it is a fixed point format with 3 digits to the right of the binary point.) Therefore, based on your averages you should set `afc_initial_dac_value` to -369 or -370 instead.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Gerrit-Change-Number: 42605
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 11 Apr 2026 00:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email )
Change subject: firmware/se_k2xx: add board specific RF tables
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
You should also add reading of per-unit RF calibration tables from TIFFS, like it is done on gta0x and fcdev3b targets - K2xx FFS has them present in TI standard format!
File src/target/firmware/board/se_k2xx/rf_tables.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/42604/comment/1c06fc86_96cf8ac1?u… :
PS2, Line 30: uint8_t apc_offset = 48;
If you look at `reg-read` file in the same directory where you found rf_XXX.c table extracts, you will see that the original fw sets APCOFF to 0x7F. Therefore, we know that the correct `apc_offset` is 63 - please change it accordingly. (APCOFF register bit 0x40 is not part of the offset, it is an unrelated bit controlling ramp slope. It has been seen as 1 on all Calypso targets that have been seen so far by FC and OBB projects.)
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Gerrit-Change-Number: 42604
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 11 Apr 2026 00:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No