April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: trx: factor out clock indication handling into helper
by fixeria 27 Apr '26

27 Apr '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42693?usp=email ) Change subject: trx: factor out clock indication handling into helper ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/42693/comment/54024158_71e732c8?usp… : PS2, Line 12: This separates core FN processing from socket-specific code : an I guess the idea here is that this new function will be called from somewhere else, bypassing the UDP sockets completely? Could you elaborate please? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e6b3e25da14ada4d0ef86fd4c4e6bbc12e447d2 Gerrit-Change-Number: 42693 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 27 Apr 2026 10:24:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bts[master]: trx: factor out FN timer processing into common helper
by fixeria 27 Apr '26

27 Apr '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email ) Change subject: trx: factor out FN timer processing into common helper ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/42692/comment/b758c5e9_48910994?usp… : PS2, Line 476: reason Well, there is a functional change here: `reason` is always NULL now. We do want proper shutdown reason/cause in the `bts_shutdown_fsm`, so please keep the current behavior. You could simply pass `&reason` to `trx_fn_timer_process()`, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia28cce57afb3dc97c8655e855ebd5ace7e096648 Gerrit-Change-Number: 42692 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 27 Apr 2026 10:14:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: build: make timerfd usage optional
by fixeria 27 Apr '26

27 Apr '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email ) Change subject: build: make timerfd usage optional ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/f1855870_3c3aa8f7?usp… : PS2, Line 31: #ifdef HAVE_SYS_TIMERFD_H : #include <sys/timerfd.h> : #e I believe this should be done after including `btsconfig.h` (see below)? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a Gerrit-Change-Number: 42689 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 27 Apr 2026 10:06:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-remsim/+/42665/comment/2da18155_945e0f3c?… : PS1, Line 9: IF a client disconnects from a worker thread while the worker is > type: IF -> If Done File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42665/comment/12a0b909_fb08343e?… : PS1, Line 568: /* do nothing */ > Can you copy the comment of DO NOT LOG anything into here too? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 09:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Fix: Prevent bankd from exiting upon SIGPIPE If a client disconnects from a worker thread while the worker is responding to a to a request from that client, the socket is closed and SIGPIPE is sent to the worker, causing the application to exit. To prevent this, all workers have a dummy handler to prevent this. Now the worker can handle the closing of the socket. Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf --- M src/bankd/bankd_main.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/65/42665/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field
by dexter 27 Apr '26

27 Apr '26

Attention is currently required from: fixeria, laforge, lynxis lazus, neels. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42662?usp=email ) Change subject: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field ...................................................................... Patch Set 6: (1 comment) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/42662/comment/9f1bde32_efe69d83?usp=em… : PS5, Line 344: self._construct = Struct('alpha_id'/GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-28))), > maybe add a short comment about COptional can't be used, see comment below. I guess that means that you share my opinion here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ec99b2648b22c56f9145345e4cd8776f9217701 Gerrit-Change-Number: 42662 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 09:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field
by dexter 27 Apr '26

27 Apr '26

Attention is currently required from: fixeria, laforge, lynxis lazus, neels. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42662?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: ts_51_011/EF.SMSP: fix handling of 'alpha_id' field ...................................................................... ts_51_011/EF.SMSP: fix handling of 'alpha_id' field The field 'alpha_id' is technically not an optional field, even though the specification describes it as optional. Once the card manufacturer decides that the field should be present, it must be always present and vice versa. (see code comment for a more detailed description) Related: SYS#7765 Change-Id: I0ec99b2648b22c56f9145345e4cd8776f9217701 --- M pySim/ts_51_011.py 1 file changed, 31 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/42662/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ec99b2648b22c56f9145345e4cd8776f9217701 Gerrit-Change-Number: 42662 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect
by jolly 27 Apr '26

27 Apr '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42646?usp=email ) Change subject: Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect ...................................................................... Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect After each connection (initial connection and reconnect), the test must wait for the bankd connection to be fully established. Previously the IPA/RSPRO emulation failed, because the socket was closed before sending the acknowledgemen, leading to a 'Broken pipe' error. Change-Id: I0a8b339bcc4136442994b8825904df8aaf9aa95d --- M remsim/RemsimClient_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/remsim/RemsimClient_Tests.ttcn b/remsim/RemsimClient_Tests.ttcn index d747eef..5d6db82 100644 --- a/remsim/RemsimClient_Tests.ttcn +++ b/remsim/RemsimClient_Tests.ttcn @@ -170,6 +170,7 @@ /* expect inbound connectClientReq on simulated bankd */ as_connectClientReq(i := 1); + /* Wait for bankd connection to be established. */ f_sleep(1.0); /* configure client to disconnect from [simulated] bankd */ @@ -190,6 +191,9 @@ /* expect inbound connect on simulated bankd */ as_connectClientReq(i := 1); + /* Wait for bankd connection to be established. */ + f_sleep(1.0); + setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a8b339bcc4136442994b8825904df8aaf9aa95d Gerrit-Change-Number: 42646 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Fix access pcscd in various RemsimBankd_Tests
by jolly 27 Apr '26

27 Apr '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42647?usp=email ) Change subject: Fix access pcscd in various RemsimBankd_Tests ...................................................................... Fix access pcscd in various RemsimBankd_Tests Access to pcscd was denied, so that bankd never conneced to the reader. This caused TC_createMapping_exchangeTPDU to fail, because it requires connection to virtual smart card for this test Change-Id: Ibae1c5167daa0157058bc40ce1857c1e6bb9da31 --- M remsim/testenv_bankd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, approved osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg index b8ebaa7..62df381 100644 --- a/remsim/testenv_bankd.cfg +++ b/remsim/testenv_bankd.cfg @@ -5,7 +5,7 @@ [pcscd] prepare=require_vsmartcard_vpcd.sh -program=pcscd -f -d +program=pcscd -f -d --disable-polkit make=no package=pcscd -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibae1c5167daa0157058bc40ce1857c1e6bb9da31 Gerrit-Change-Number: 42647 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: Allow adding extra parameters to podman
by jolly 27 Apr '26

27 Apr '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email ) Change subject: testenv: Allow adding extra parameters to podman ...................................................................... testenv: Allow adding extra parameters to podman Allows to add additional command line parameters to podman, if defined int the testsuite section of testenv.cfg: [testsuite] ... podman_extra=--volume /dev/bus/usb:/dev/bus/usb Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 --- M _testenv/README.md M _testenv/testenv/podman.py M _testenv/testenv/testenv_cfg.py 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/_testenv/README.md b/_testenv/README.md index a973b25..196af94 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -94,6 +94,11 @@ testsuite to avoid consuming the whole RAM and freezing (or possibly getting killed from an out-of-memory daemon). +* `podman_extra=`: optional value that can be set to add extra parameters to + podman. For example, it can be used to mount an additional volume to pass- + through USB devices. Use spaces to separate parameters, use quotes to include + spaces into parameters. + #### Component section * `program=`: executable for starting a test component, may contain arguments. diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 79fc5b9..92dfeb4 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -266,6 +266,10 @@ dest = os.readlink(testenv.custom_kernel_path) cmd += ["--volume", f"{dest}:{dest}:ro"] + podman_extra = testenv.testenv_cfg.get_podman_extra_first_cfg() + if podman_extra: + cmd += shlex.split(podman_extra) + cmd += [ "--volume", f"{testdir_topdir}:{testdir_topdir}", diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py index 9edc102..eb9e030 100644 --- a/_testenv/testenv/testenv_cfg.py +++ b/_testenv/testenv/testenv_cfg.py @@ -207,6 +207,11 @@ return testenv.args.jobs +def get_podman_extra_first_cfg(): + _, cfg = next(iter(cfgs.items())) + return cfg["testsuite"].get("podman_extra", None) + + def verify_qemu_cfgs(): """Check if passed -C or -K args make sense with the testenv configs.""" testsuite = testenv.args.testsuite @@ -255,6 +260,7 @@ "program", "titan_min", "max_jobs_per_gb_ram", + "podman_extra", ] keys_valid_component = [ "clean", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a2be0d60efcd70ea2081e0314927885085bb5e0 Gerrit-Change-Number: 42666 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026