Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: firmware/se_k2xx: add board specific RF tables
......................................................................
firmware/se_k2xx: add board specific RF tables
SE K2xx phones use a different PA than GTA0x/FCDEV3B, so the
compiled-in Tx ramp templates must match the actual hardware.
Replace the previously copied GTA0x ramps with values extracted
from the SE K2xx official firmware using the calextract tool
from the freecalypso-reveng repository:
https://www.freecalypso.org/hg/freecalypso-reveng/
The Tx levels tables are left unchanged, as they are believed to
be the same TI internal defaults across these designs.
Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Related: OS#5822
---
M src/target/firmware/Makefile
A src/target/firmware/board/se_k2xx/rf_tables.c
2 files changed, 579 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/04/42604/2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd
Gerrit-Change-Number: 42604
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email )
Change subject: firmware/se_k2xx: add board specific AFC params
......................................................................
firmware/se_k2xx: add board specific AFC params
Set afc_slope to 405 and afc_initial_dac_value to -2957, derived from
AFC parameter averages computed across TIFFS readings of 7 unique
SE K2xx units (5 x K200i + 1 x K205i + 1 x K220i).
Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Related: OS#5822
---
M src/target/firmware/Makefile
A src/target/firmware/board/se_k2xx/afcparams.c
2 files changed, 43 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/05/42605/1
diff --git a/src/target/firmware/Makefile b/src/target/firmware/Makefile
index f057410..64ed667 100644
--- a/src/target/firmware/Makefile
+++ b/src/target/firmware/Makefile
@@ -113,7 +113,7 @@
BOARD_se_k2xx_OBJS=$(calypso_COMMON_OBJS) board/se_k2xx/init.o \
board/se_k2xx/rffe_k2xx.o \
board/se_k2xx/rf_tables.o \
- board/gta0x/afcparams.o \
+ board/se_k2xx/afcparams.o \
board/common/readcal_tiffs.o battery/dummy.o $(FB_k2xx_OBJS)
BOARD_se_k2xx_ENVIRONMENTS=highram
diff --git a/src/target/firmware/board/se_k2xx/afcparams.c b/src/target/firmware/board/se_k2xx/afcparams.c
new file mode 100644
index 0000000..928354c
--- /dev/null
+++ b/src/target/firmware/board/se_k2xx/afcparams.c
@@ -0,0 +1,42 @@
+/*
+ * (C) 2026 by Vadim Yanitskiy <fixeria(a)osmocom.org>
+ *
+ * All Rights Reserved
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */
+
+#include <stdint.h>
+
+/*
+ * The following AFC Psi parameters are averages computed from TIFFS readings
+ * across 7 unique SE K2xx units (5 x K200 + 1 x K205 + 1 x K220):
+ *
+ * Psi_sta_inv: 3880
+ * Psi_st: 14
+ * Psi_st_32: 885779
+ * Psi_st_inv: 4850
+ *
+ * The following AFC slope number is the closest OsmocomBB-style afc_slope
+ * integer corresponding to these Psi numbers.
+ */
+int16_t afc_slope = 405;
+
+/*
+ * The compiled-in AFC initial DAC value below is the average dac_center
+ * computed from TIFFS readings across the same 7 unique SE K2xx units.
+ * It will normally be overridden by the per-unit factory calibration value
+ * read from the /gsm/rf/afcdac file in FFS.
+ */
+int16_t afc_initial_dac_value = -2957;
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Gerrit-Change-Number: 42605
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42301?usp=email )
Change subject: pySim/transport: fix GET RESPONSE behaviour
......................................................................
Patch Set 6:
(1 comment)
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42301/comment/8725f2b8_d4cb0d82?usp=em… :
PS6, Line 308: if sw is not None:
Quite a lot of nesting here...
Maybe split this into a separate function or even several functions?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I26f0566af0cdd61dcc97f5f502479dc76adc37cc
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Apr 2026 19:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42301?usp=email )
Change subject: pySim/transport: fix GET RESPONSE behaviour
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I26f0566af0cdd61dcc97f5f502479dc76adc37cc
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 09 Apr 2026 16:48:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No