April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: sgsn_libgtp: fix NULL dereference in cb_delete_context()
by fixeria 09 Apr '26

09 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42602?usp=email ) Change subject: sgsn_libgtp: fix NULL dereference in cb_delete_context() ...................................................................... sgsn_libgtp: fix NULL dereference in cb_delete_context() sgsn_pdp_ctx_free() contains an abnormal path (with a backtrace log) for the case where a PDP context is freed while its libgtp handle is still attached. In that path, lib->priv is set to NULL to prevent other callbacks (e.g. cb_data_ind()) from dereferencing the already- freed sgsn_pdp_ctx. When libgtp subsequently calls cb_delete_context() as part of its own teardown, pdp->priv is NULL, causing an immediate NULL dereference at the pctx->lib = NULL assignment. Guard against this by returning early when priv is NULL: the SGSN-side context is already gone, so there is nothing left for the callback to do. Change-Id: I7d800766b08d87b6f2b23a0cd45435925f9998ff --- M src/sgsn/sgsn_libgtp.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/02/42602/1 diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index 4021bbc..e4fc9fd 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -702,6 +702,12 @@ LOGPDPX(DGPRS, LOGL_INFO, pdp, "Context %p was deleted\n", pdp); + /* sgsn_pdp_ctx_free() clears pdp->priv when it has to release a context + * that still has a libgtp handle attached (the "shouldn't happen" path). + * In that case the SGSN side is already gone; nothing to do here. */ + if (!pctx) + return 0; + /* unlink the now non-existing library handle from the pdp context. This way we avoid calling pdp_freepdp() on it, since after returning from cb_delete_context callback, libgtp is already doing so. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7d800766b08d87b6f2b23a0cd45435925f9998ff Gerrit-Change-Number: 42602 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: vlr: Stop silent call before deduping subscribers
by lynxis lazus 09 Apr '26

09 Apr '26

Attention is currently required from: matanp. lynxis lazus has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email ) Change subject: vlr: Stop silent call before deduping subscribers ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > > ... […] I didn't had time to be part of the review. I agree with fixeria, to have it merged to fix the problem. But yes, it's mixing the libvlr with msc. The root problems should be fixed later. And yes the dup paging is also problematic. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd Gerrit-Change-Number: 41131 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Thu, 09 Apr 2026 11:54:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com>

1 0

[XS] Change in osmo-remsim[master]: rspro_server: don't access the msg on error cases
by laforge 09 Apr '26

09 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email ) Change subject: rspro_server: don't access the msg on error cases ...................................................................... Patch Set 2: -Verified Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 Gerrit-Change-Number: 42601 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 09 Apr 2026 10:44:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_server: don't access the msg on error cases
by laforge 09 Apr '26

09 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email ) Change subject: rspro_server: don't access the msg on error cases ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 Gerrit-Change-Number: 42601 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 09 Apr 2026 10:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_server: don't access the msg on error cases
by lynxis lazus 09 Apr '26

09 Apr '26

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email ) Change subject: rspro_server: don't access the msg on error cases ...................................................................... rspro_server: don't access the msg on error cases The msg is NULL on errors. Related: SYS#7930 Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 --- M src/server/rspro_server.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/01/42601/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 Gerrit-Change-Number: 42601 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: rspro_server: don't access the msg on error cases
by lynxis lazus 09 Apr '26

09 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email ) Change subject: rspro_server: don't access the msg on error cases ...................................................................... rspro_server: don't access the msg on error cases The msg is NULL on errors. Related: SYS#7930 Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 --- M src/server/rspro_server.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/01/42601/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 70d59c1..ac10cad 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -712,7 +712,7 @@ /* data was received from one of the client connections to the RSPRO socket */ static int sock_read_cb(struct osmo_stream_srv *peer, int res, struct msgb *msg) { - enum ipaccess_proto ipa_proto = osmo_ipa_msgb_cb_proto(msg); + enum ipaccess_proto ipa_proto; struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); RsproPDU_t *pdu; int rc; @@ -722,6 +722,9 @@ goto err; } + ipa_proto = osmo_ipa_msgb_cb_proto(msg); + conn = osmo_stream_srv_get_data(peer); + switch (ipa_proto) { case IPAC_PROTO_IPACCESS: rc = _ipa_srv_conn_ccm(conn, msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 Gerrit-Change-Number: 42601 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-bsc[master]: handover_fsm: send_handover_performed(): check lchan != NULL
by jolly 09 Apr '26

09 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42599?usp=email ) Change subject: handover_fsm: send_handover_performed(): check lchan != NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee734c98dc79681808e7d75360c208a941cc6821 Gerrit-Change-Number: 42599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Apr 2026 10:13:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode
by jolly 09 Apr '26

09 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email ) Change subject: assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1718994e25ff1349618bdb4660afbe735c5c3977 Gerrit-Change-Number: 42600 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Apr 2026 10:12:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: handover_fsm: fix send_handover_performed() using wrong lchan
by fixeria 09 Apr '26

09 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email ) Change subject: handover_fsm: fix send_handover_performed() using wrong lchan ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42593/comment/38890d9f_87d97cc9?usp… : PS2, Line 901: struct gsm_lchan *lchan = ho->new_lchan; > I should not be NULL in the case of a successful handover, but I'll add a check anyway. See https://gerrit.osmocom.org/c/osmo-bsc/+/42599. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e Gerrit-Change-Number: 42593 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 08 Apr 2026 23:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: handover_fsm: send_handover_performed(): check lchan != NULL
by fixeria 09 Apr '26

09 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42599?usp=email ) Change subject: handover_fsm: send_handover_performed(): check lchan != NULL ...................................................................... handover_fsm: send_handover_performed(): check lchan != NULL The target lchan is expected to be valid on HO_RESULT_OK, but it's still safer to check it against NULL before dereferencing. Change-Id: Iee734c98dc79681808e7d75360c208a941cc6821 Related: 107391d8c ("handover_fsm: fix send_handover_performed() using wrong lchan") --- M src/osmo-bsc/handover_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/42599/1 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index cddb138..2017637 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -905,6 +905,11 @@ struct gsm0808_speech_codec sc; int rc; + if (lchan == NULL) { + LOG_HO(conn, LOGL_ERROR, "Target lchan is NULL, can't send HANDOVER PERFORMED!\n"); + return; + } + /* Cause 3.2.2.5 */ ho_perf_params.cause = GSM0808_CAUSE_HANDOVER_SUCCESSFUL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee734c98dc79681808e7d75360c208a941cc6821 Gerrit-Change-Number: 42599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026