Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email )
Change subject: trx: add JSON stats export for WebSDR API ......................................................................
Patch Set 1:
(32 comments)
File src/osmo-bts-trx/osmo-bts-trx-websdr.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/19c96329_9e174a9d?usp=... : PS1, Line 133: if (!strncmp(group, "stats", 5)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/26867b6a_513d986e?usp=... : PS1, Line 133: if (!strncmp(group, "stats", 5)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/337ae37a_76481a5d?usp=... : PS1, Line 133: if (!strncmp(group, "stats", 5)) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/93c92d58_e7e50e00?usp=... : PS1, Line 134: return stats_to_json(buf, buflen); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/abd46922_8ad0a3ee?usp=... : PS1, Line 134: return stats_to_json(buf, buflen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/432cb769_955ba8f4?usp=... : PS1, Line 135: } else if (!strncmp(group, "rate-counters", 13)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/56122fb2_8084a4b2?usp=... : PS1, Line 135: } else if (!strncmp(group, "rate-counters", 13)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/fde351a0_00f207a7?usp=... : PS1, Line 136: return rate_counters_to_json(buf, buflen); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/99b7f2a6_554b1ec7?usp=... : PS1, Line 136: return rate_counters_to_json(buf, buflen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/db5f49e9_14035384?usp=... : PS1, Line 137: } else if (!strncmp(group, "bts", 3)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/5c0a8771_96772a18?usp=... : PS1, Line 137: } else if (!strncmp(group, "bts", 3)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/a4cb247f_e2c50226?usp=... : PS1, Line 138: return bts_to_json(buf, buflen); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/8243ca93_c5a46123?usp=... : PS1, Line 138: return bts_to_json(buf, buflen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/4382a37a_7025850a?usp=... : PS1, Line 139: } else if (!strncmp(group, "trx", 3)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/0739f9d5_46745b06?usp=... : PS1, Line 139: } else if (!strncmp(group, "trx", 3)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/771b91f9_9dc33066?usp=... : PS1, Line 140: return trx_to_json(buf, buflen); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/fe97ccf1_764c187a?usp=... : PS1, Line 140: return trx_to_json(buf, buflen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/ef321052_54a58ece?usp=... : PS1, Line 141: } else if (!strncmp(group, "transceiver", 11)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/c648d10f_c6218f78?usp=... : PS1, Line 141: } else if (!strncmp(group, "transceiver", 11)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/8195de8e_02042a7c?usp=... : PS1, Line 142: return transceiver_to_json(buf, buflen); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/2582c087_9c5ff2da?usp=... : PS1, Line 142: return transceiver_to_json(buf, buflen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/de71de56_13f48fca?usp=... : PS1, Line 143: } else if (!strncmp(group, "websdr", 6)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/03078793_340e5000?usp=... : PS1, Line 143: } else if (!strncmp(group, "websdr", 6)) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/1ee10bce_49a57447?usp=... : PS1, Line 144: return websdr_to_json(buf, buflen); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/000cd6c3_fa607bae?usp=... : PS1, Line 144: return websdr_to_json(buf, buflen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/9c68f809_f816c65d?usp=... : PS1, Line 145: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/27475ac9_7a0237ee?usp=... : PS1, Line 145: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/7fec8334_c5c0e46c?usp=... : PS1, Line 147: return -EINVAL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/601d0d68_d9d02256?usp=... : PS1, Line 147: return -EINVAL; please, no spaces at the start of a line
File src/osmo-bts-trx/stats_json.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/523c4380_6c18b3a9?usp=... : PS1, Line 353: if (l1h->config.arfcn_valid) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/0ad7272a_8ed92e96?usp=... : PS1, Line 361: if (l1h->config.tsc_valid) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/0f948ce0_efbb9345?usp=... : PS1, Line 369: if (l1h->config.bsic_valid) { braces {} are not necessary for any arm of this statement
-
Jenkins Builder