View Change

32 comments:

• File src/osmo-bts-trx/osmo-bts-trx-websdr.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 133: if (!strncmp(group, "stats", 5)) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 133: if (!strncmp(group, "stats", 5)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 133: if (!strncmp(group, "stats", 5)) {

    braces {} are not necessary for any arm of this statement

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 134: return stats_to_json(buf, buflen);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 134: return stats_to_json(buf, buflen);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 135: } else if (!strncmp(group, "rate-counters", 13)) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 135: } else if (!strncmp(group, "rate-counters", 13)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 136: return rate_counters_to_json(buf, buflen);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 136: return rate_counters_to_json(buf, buflen);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 137: } else if (!strncmp(group, "bts", 3)) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 137: } else if (!strncmp(group, "bts", 3)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 138: return bts_to_json(buf, buflen);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 138: return bts_to_json(buf, buflen);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 139: } else if (!strncmp(group, "trx", 3)) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 139: } else if (!strncmp(group, "trx", 3)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 140: return trx_to_json(buf, buflen);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 140: return trx_to_json(buf, buflen);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 141: } else if (!strncmp(group, "transceiver", 11)) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 141: } else if (!strncmp(group, "transceiver", 11)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 142: return transceiver_to_json(buf, buflen);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 142: return transceiver_to_json(buf, buflen);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 143: } else if (!strncmp(group, "websdr", 6)) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 143: } else if (!strncmp(group, "websdr", 6)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 144: return websdr_to_json(buf, buflen);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 144: return websdr_to_json(buf, buflen);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 145: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 145: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 147: return -EINVAL;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 147: return -EINVAL;

    please, no spaces at the start of a line

• File src/osmo-bts-trx/stats_json.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 353: if (l1h->config.arfcn_valid) {

    braces {} are not necessary for any arm of this statement

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 361: if (l1h->config.tsc_valid) {

    braces {} are not necessary for any arm of this statement

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 369: if (l1h->config.bsic_valid) {

    braces {} are not necessary for any arm of this statement

To view, visit change 42704. To unsubscribe, or for help writing mail filters, visit settings.