Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email ) Change subject: trx: add JSON stats export for WebSDR API ...................................................................... Patch Set 2: (32 comments) File src/osmo-bts-trx/osmo-bts-trx-websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/378b7c14_1fb216d9?usp=... : PS2, Line 133: if (!strncmp(group, "stats", 5)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/fedcbd5d_72360554?usp=... : PS2, Line 133: if (!strncmp(group, "stats", 5)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/2753a805_8c595e3f?usp=... : PS2, Line 133: if (!strncmp(group, "stats", 5)) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/abfe5511_6eca1a4e?usp=... : PS2, Line 134: return stats_to_json(buf, buflen); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/f5782a96_4f452eb3?usp=... : PS2, Line 134: return stats_to_json(buf, buflen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/690c80b0_af4845a5?usp=... : PS2, Line 135: } else if (!strncmp(group, "rate-counters", 13)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/4fd56b0d_1a5fba00?usp=... : PS2, Line 135: } else if (!strncmp(group, "rate-counters", 13)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/3d771da8_b84d1b2c?usp=... : PS2, Line 136: return rate_counters_to_json(buf, buflen); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/0db0419a_98cc0890?usp=... : PS2, Line 136: return rate_counters_to_json(buf, buflen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/aa0c3c9b_ae776a34?usp=... : PS2, Line 137: } else if (!strncmp(group, "bts", 3)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/3fae08e2_69bab85a?usp=... : PS2, Line 137: } else if (!strncmp(group, "bts", 3)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/4d86020b_67053f9d?usp=... : PS2, Line 138: return bts_to_json(buf, buflen); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/55f20ad5_26d0accf?usp=... : PS2, Line 138: return bts_to_json(buf, buflen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/b70a54fb_46e626f7?usp=... : PS2, Line 139: } else if (!strncmp(group, "trx", 3)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/2b2c5760_c45f3d79?usp=... : PS2, Line 139: } else if (!strncmp(group, "trx", 3)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/89fb12ab_87a0dfb2?usp=... : PS2, Line 140: return trx_to_json(buf, buflen); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/79647600_e2157860?usp=... : PS2, Line 140: return trx_to_json(buf, buflen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/32b2ae3b_e908dcbe?usp=... : PS2, Line 141: } else if (!strncmp(group, "transceiver", 11)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/395c25a5_27c83319?usp=... : PS2, Line 141: } else if (!strncmp(group, "transceiver", 11)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/6c9db136_bb0f2856?usp=... : PS2, Line 142: return transceiver_to_json(buf, buflen); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/b9c44e6b_4e6a6afd?usp=... : PS2, Line 142: return transceiver_to_json(buf, buflen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/ba4f5a58_3a36bb38?usp=... : PS2, Line 143: } else if (!strncmp(group, "websdr", 6)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/f5300dc5_a8138f2f?usp=... : PS2, Line 143: } else if (!strncmp(group, "websdr", 6)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/4a7d00d3_ffc13a9a?usp=... : PS2, Line 144: return websdr_to_json(buf, buflen); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/12f5922c_b10b58c4?usp=... : PS2, Line 144: return websdr_to_json(buf, buflen); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/1422c714_b34678a9?usp=... : PS2, Line 145: } code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/86434e3c_52f95127?usp=... : PS2, Line 145: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/9a30fe26_0af1bf94?usp=... : PS2, Line 147: return -EINVAL; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/70d9ef58_033211fa?usp=... : PS2, Line 147: return -EINVAL; please, no spaces at the start of a line File src/osmo-bts-trx/stats_json.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/57a69e63_055c3eeb?usp=... : PS2, Line 353: if (l1h->config.arfcn_valid) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/1082966a_7cf5e060?usp=... : PS2, Line 361: if (l1h->config.tsc_valid) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42704/comment/0dff45ca_ae3feca5?usp=... : PS2, Line 369: if (l1h->config.bsic_valid) { braces {} are not necessary for any arm of this statement -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifb82adfab879a65ecd222c45e06551983aa90a0f Gerrit-Change-Number: 42704 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 27 Apr 2026 00:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No