Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email ) Change subject: trx: factor out FN timer processing into common helper ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/42692/comment/b758c5e9_48910994?usp=... : PS2, Line 476: reason Well, there is a functional change here: `reason` is always NULL now. We do want proper shutdown reason/cause in the `bts_shutdown_fsm`, so please keep the current behavior. You could simply pass `&reason` to `trx_fn_timer_process()`, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia28cce57afb3dc97c8655e855ebd5ace7e096648 Gerrit-Change-Number: 42692 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp@gmail.com> Gerrit-Comment-Date: Mon, 27 Apr 2026 10:14:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes