Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/rspro_util.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/33adbc64_e7d3b295?u... : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); You decided to free pdu here in case of encoding failure. Look inside the users worker_send_rspro(), cli_conn_send_rspro() and client_conn_send(), they will double free in case of a failure. https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/3a1ea97e_9a0852a2?u... : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); Same issue here. This casues a double free. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes