Attention is currently required from: laforge, lynxis lazus.
jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email )
Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/rspro_util.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/33adbc64_e7d3b295?u... : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); You decided to free pdu here in case of encoding failure. Look inside the users worker_send_rspro(), cli_conn_send_rspro() and client_conn_send(), they will double free in case of a failure.
https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/3a1ea97e_9a0852a2?u... : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); Same issue here. This casues a double free.