April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes
by lynxis lazus 14 Apr '26

14 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email ) Change subject: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes ...................................................................... octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes The largest message on the endpoint is the 4 byte hardware error. The slot status is 3 bytes for 8 slots. Change-Id: I615ff16d9bc0e8d39156015e41b4abe4502aaca1 --- M sysmoOCTSIM/usb_descriptors.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/19/42619/1 diff --git a/sysmoOCTSIM/usb_descriptors.c b/sysmoOCTSIM/usb_descriptors.c index d3084cc..c4fa5ea 100644 --- a/sysmoOCTSIM/usb_descriptors.c +++ b/sysmoOCTSIM/usb_descriptors.c @@ -211,7 +211,7 @@ .bDescriptorType = USB_DT_ENDPOINT, .bEndpointAddress = 0x84, .bmAttributes = USB_EP_TYPE_INTERRUPT, - .wMaxPacketSize = 64, + .wMaxPacketSize = 4, .bInterval = 0x10, }, }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I615ff16d9bc0e8d39156015e41b4abe4502aaca1 Gerrit-Change-Number: 42619 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ccid-firmware[master]: octsim: usb_descriptors: use LE16/LE32 for consistancy
by lynxis lazus 14 Apr '26

14 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42621?usp=email ) Change subject: octsim: usb_descriptors: use LE16/LE32 for consistancy ...................................................................... octsim: usb_descriptors: use LE16/LE32 for consistancy Even this is ran on ARM and most likely on x86, add byte ordering function (LE16/LE32) to 16 bit and 32 bit fields as the remaining usb descriptor does. Change-Id: Ia77d65faf56c5d3c57cc76c91af33fce4fbbff5c --- M sysmoOCTSIM/usb_descriptors.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/21/42621/1 diff --git a/sysmoOCTSIM/usb_descriptors.c b/sysmoOCTSIM/usb_descriptors.c index c4fa5ea..fec95fc 100644 --- a/sysmoOCTSIM/usb_descriptors.c +++ b/sysmoOCTSIM/usb_descriptors.c @@ -45,13 +45,13 @@ .cfg = { .bLength = sizeof(struct usb_config_desc), .bDescriptorType = USB_DT_CONFIG, - .wTotalLength = sizeof(usb_fs_descs.cfg) + + .wTotalLength = LE32(sizeof(usb_fs_descs.cfg) + #ifdef WITH_DEBUG_CDC sizeof(usb_fs_descs.cdc) + #endif sizeof(usb_fs_descs.ccid) + sizeof(usb_fs_descs.dfu_rt) + - sizeof(usb_fs_descs.func_dfu), + sizeof(usb_fs_descs.func_dfu)), #ifdef WITH_DEBUG_CDC .bNumInterfaces = 4, #else @@ -165,7 +165,7 @@ .bcdCCID = LE16(0x0110), .bMaxSlotIndex = 7, .bVoltageSupport = 0x07, /* 5/3/1.8V */ - .dwProtocols = 0x01, /* only t0 */ + .dwProtocols = LE16(0x01), /* only t0 */ .dwDefaultClock = LE32(2500), .dwMaximumClock = LE32(20000), .bNumClockSupported = CCID_NUM_CLK_SUPPORTED, @@ -182,7 +182,7 @@ * 0x10 Automatic ICC clock frequency change according to active parameters * provided by the Host or self determined */ .dwFeatures = LE32(0x10 | 0x20 | 0x80 | 0x00010000), - .dwMaxCCIDMessageLength = 272, + .dwMaxCCIDMessageLength = LE16(272), .bClassGetResponse = 0xff, .bClassEnvelope = 0xff, .wLcdLayout = LE16(0), @@ -195,7 +195,7 @@ .bDescriptorType = USB_DT_ENDPOINT, .bEndpointAddress = 0x02, .bmAttributes = USB_EP_TYPE_BULK, - .wMaxPacketSize = 64, + .wMaxPacketSize = LE16(64), .bInterval = 0, }, { /* Bulk-IN descriptor */ @@ -203,7 +203,7 @@ .bDescriptorType = USB_DT_ENDPOINT, .bEndpointAddress = 0x83, .bmAttributes = USB_EP_TYPE_BULK, - .wMaxPacketSize = 64, + .wMaxPacketSize = LE16(64), .bInterval = 0, }, { /* Interrupt dscriptor */ @@ -211,7 +211,7 @@ .bDescriptorType = USB_DT_ENDPOINT, .bEndpointAddress = 0x84, .bmAttributes = USB_EP_TYPE_INTERRUPT, - .wMaxPacketSize = 4, + .wMaxPacketSize = LE16(4), .bInterval = 0x10, }, }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia77d65faf56c5d3c57cc76c91af33fce4fbbff5c Gerrit-Change-Number: 42621 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: octsim: main: reduce msgb_alloc for irqs to 8 bytes
by lynxis lazus 14 Apr '26

14 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42620?usp=email ) Change subject: octsim: main: reduce msgb_alloc for irqs to 8 bytes ...................................................................... octsim: main: reduce msgb_alloc for irqs to 8 bytes The message itself is only 3 bytes, but the usb stack might benefit from 8 byte buffers. Change-Id: I33809d2c1973231627f6da5d9b01e9525f2b38c1 --- M sysmoOCTSIM/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/20/42620/1 diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 7873c86..ea34827 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -330,7 +330,7 @@ { uint8_t statusbytes[2] = {0}; //struct msgb *msg = ccid_msgb_alloc(); - struct msgb *msg = msgb_alloc(300,"IRQ"); + struct msgb *msg = msgb_alloc(8, "IRQ"); struct ccid_rdr_to_pc_notify_slot_change *nsc = (struct ccid_rdr_to_pc_notify_slot_change *)msgb_put(msg, sizeof(*nsc) + sizeof(statusbytes)); nsc->bMessageType = RDR_to_PC_NotifySlotChange; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I33809d2c1973231627f6da5d9b01e9525f2b38c1 Gerrit-Change-Number: 42620 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: Check for protocol extension bit in message type at a central location
by laforge 14 Apr '26

14 Apr '26

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email ) Change subject: Check for protocol extension bit in message type at a central location ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df Gerrit-Change-Number: 38579 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 18:47:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: cosmetic: fix missing spaces in string_req_h
by laforge 14 Apr '26

14 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42618?usp=email ) Change subject: cosmetic: fix missing spaces in string_req_h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia92ac605d83718399f19db67057e740ceaa8c37f Gerrit-Change-Number: 42618 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Apr 2026 18:46:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: Rework default IRQ handler and osmo panic handler
by laforge 14 Apr '26

14 Apr '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email ) Change subject: Rework default IRQ handler and osmo panic handler ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ibcabe0c58ff14ebe76159470dd90fdef064febea Gerrit-Change-Number: 42616 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Apr 2026 18:45:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: cosmetic: fix missing spaces in string_req_h
by lynxis lazus 14 Apr '26

14 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42618?usp=email ) Change subject: cosmetic: fix missing spaces in string_req_h ...................................................................... cosmetic: fix missing spaces in string_req_h Change-Id: Ia92ac605d83718399f19db67057e740ceaa8c37f --- M sysmoOCTSIM/usb_start.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/18/42618/1 diff --git a/sysmoOCTSIM/usb_start.c b/sysmoOCTSIM/usb_start.c index 6946126..3ccfb32 100644 --- a/sysmoOCTSIM/usb_start.c +++ b/sysmoOCTSIM/usb_start.c @@ -121,7 +121,7 @@ } -static struct usbdc_handler string_req_h = {NULL, (FUNC_PTR)string_req_cb}; +static struct usbdc_handler string_req_h = { NULL, (FUNC_PTR)string_req_cb }; /** * \brief CDC ACM Init -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia92ac605d83718399f19db67057e740ceaa8c37f Gerrit-Change-Number: 42618 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: scripts: fix deprecation warnings
by pespin 14 Apr '26

14 Apr '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42615?usp=email ) Change subject: scripts: fix deprecation warnings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie78b84dd556266f96780a4232f95b58e0e3eabc0 Gerrit-Change-Number: 42615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 16:24:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: osmo_git_clone_url(): add Gitea mirrors for libnftnl and nftables
by pespin 14 Apr '26

14 Apr '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42614?usp=email ) Change subject: osmo_git_clone_url(): add Gitea mirrors for libnftnl and nftables ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I830a16c8bf7f595b16113bf2ba5e81bae56533dd Gerrit-Change-Number: 42614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 16:23:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: Check for protocol extension bit in message type at a central location
by pespin 14 Apr '26

14 Apr '26

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email ) Change subject: Check for protocol extension bit in message type at a central location ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File tests/msc_vlr/msc_vlr_test_gsm_ciph.c: https://gerrit.osmocom.org/c/osmo-msc/+/38579/comment/15164789_f381981d?usp… : PS5, Line 1058: release_99 = false; Can we have this reset in in comment_start() or similar? Or rename it to "test_setup()" or alike. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df Gerrit-Change-Number: 38579 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 16:22:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026