April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: sgsn_libgtp: fix NULL dereference in cb_delete_context()
by pespin 14 Apr '26

14 Apr '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42602?usp=email ) Change subject: sgsn_libgtp: fix NULL dereference in cb_delete_context() ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Is there some ticket related to this scenario? File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/42602/comment/e7107333_043cfb46?us… : PS1, Line 708: if (!pctx) So iiuc this patch fixes a crash happening after a condition which shouldn't have happened in first place? Maybe Try to understand why this condition is happening and add in that place an ASSERT or panic so it can be noticed and debugged further? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7d800766b08d87b6f2b23a0cd45435925f9998ff Gerrit-Change-Number: 42602 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 16:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ccid-firmware[master]: Implement vendor requests to set debug/break_on_panic
by lynxis lazus 14 Apr '26

14 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42617?usp=email ) Change subject: Implement vendor requests to set debug/break_on_panic ...................................................................... Implement vendor requests to set debug/break_on_panic Use vendor request in to read and set the break_on_panic. In the future this vendor request could be also used to set other debug related options. Change-Id: Ia2bffa05b96e3857610cb3ad2f9122fa75a90780 --- M sysmoOCTSIM/usb_start.c 1 file changed, 63 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/17/42617/1 diff --git a/sysmoOCTSIM/usb_start.c b/sysmoOCTSIM/usb_start.c index 6946126..6a5d7bf 100644 --- a/sysmoOCTSIM/usb_start.c +++ b/sysmoOCTSIM/usb_start.c @@ -121,7 +121,69 @@ } +enum usb_vendor_req_code { + USB_VENDOR_REQ_GET = 0, + USB_VENDOR_REQ_SET = 1, +}; + +enum usb_vendor_get_set { + GET_SET_DEBUG = 0, +}; + +extern volatile bool break_on_panic; + +/* call-back for every control EP request */ +static int32_t vendor_req_cb(uint8_t ep, struct usb_req *req, enum usb_ctrl_stage stage) +{ + /* must be at least 8 byte and aligned to allow USB xfers */ + static uint8_t __attribute__((aligned(4))) buf[8]; + uint8_t index, type, ret; + + if (stage != USB_SETUP_STAGE) + return ERR_NOT_FOUND; + + /* currently only IN transfers */ + if ((req->bmRequestType & (USB_REQT_TYPE_MASK | USB_REQT_DIR_IN)) != + (USB_REQT_TYPE_VENDOR | USB_REQT_DIR_IN)) + return ERR_NOT_FOUND; + + switch (req->bRequest) { + case USB_VENDOR_REQ_GET: + switch (LE16(req->wIndex)) { + case GET_SET_DEBUG: + memset(buf, 0, sizeof(buf)); + buf[0] = break_on_panic; + ret = usbdc_xfer(ep, buf, sizeof(buf), false); + if (ret >= 0 || ret != ERR_NOT_FOUND) + return ERR_NONE; + else + return ret; + break; + } + break; + case USB_VENDOR_REQ_SET: + switch (LE16(req->wIndex)) { + case GET_SET_DEBUG: + memset(buf, 0, sizeof(buf)); + break_on_panic = LE16(req->wValue) & 0x1; + buf[0] = break_on_panic; + ret = usbdc_xfer(ep, buf, 8, false); + if (ret >= 0 || ret != ERR_NOT_FOUND) + return ERR_NONE; + else + return ret; + break; + } + break; + default: + break; + } + + return ERR_NOT_FOUND; +} + static struct usbdc_handler string_req_h = {NULL, (FUNC_PTR)string_req_cb}; +static struct usbdc_handler vendor_req_h = {NULL, (FUNC_PTR)vendor_req_cb}; /** * \brief CDC ACM Init @@ -131,6 +193,7 @@ /* usb stack init */ usbdc_init(ctrl_buffer); usbdc_register_handler(USBDC_HDL_REQ, &string_req_h); + usbdc_register_handler(USBDC_HDL_REQ, &vendor_req_h); #ifdef WITH_DEBUG_CDC /* usbdc_register_funcion inside */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia2bffa05b96e3857610cb3ad2f9122fa75a90780 Gerrit-Change-Number: 42617 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-netif[master]: .gitignore: add missing osmux_{input,output}_test
by fixeria 14 Apr '26

14 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42606?usp=email ) Change subject: .gitignore: add missing osmux_{input,output}_test ...................................................................... .gitignore: add missing osmux_{input,output}_test Take a chance to group test binaries and specify their full paths. Change-Id: Icb9014fe3c501940cef2d599403aa102135dd384 --- M .gitignore 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 38e35c8..2afea7f 100644 --- a/.gitignore +++ b/.gitignore @@ -34,9 +34,16 @@ tests/atconfig tests/package.m4 tests/testsuite -tests/osmux/osmux_test tests/testsuite.log +tests/amr/amr_test +tests/jibuf/jibuf_test +tests/jibuf/jibuf_tool +tests/osmux/osmux_input_test +tests/osmux/osmux_output_test +tests/osmux/osmux_test +tests/stream/stream_test + doc/twrtp/twrtp-guide.pdf examples/ipa-stream-client @@ -59,11 +66,6 @@ /examples/udp-test-server .*.sw? -jibuf_test -jibuf_tool -osmux_test2 -stream_test -amr_test contrib/libosmo-netif.spec include/osmocom/netif/version.h -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icb9014fe3c501940cef2d599403aa102135dd384 Gerrit-Change-Number: 42606 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: .gitignore: add missing osmux_{input,output}_test
by pespin 14 Apr '26

14 Apr '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42606?usp=email ) Change subject: .gitignore: add missing osmux_{input,output}_test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icb9014fe3c501940cef2d599403aa102135dd384 Gerrit-Change-Number: 42606 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 16:10:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: Rework default IRQ handler and osmo panic handler
by lynxis lazus 14 Apr '26

14 Apr '26

Attention is currently required from: Hoernchen, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email ) Change subject: Rework default IRQ handler and osmo panic handler ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is an alternative to the other IRQ patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ibcabe0c58ff14ebe76159470dd90fdef064febea Gerrit-Change-Number: 42616 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Apr 2026 15:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ccid-firmware[master]: Rework default IRQ handler and osmo panic handler
by lynxis lazus 14 Apr '26

14 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email ) Change subject: Rework default IRQ handler and osmo panic handler ...................................................................... Rework default IRQ handler and osmo panic handler Don't break on panic by default. Using a variable allows to set it by SWD or later by a usb message. Use the same handler for osmo panics as well as unknown IRQ. Including faults (bus, hard). Change-Id: Ibcabe0c58ff14ebe76159470dd90fdef064febea --- M sysmoOCTSIM/gcc/gcc/startup_same54.c M sysmoOCTSIM/include/same54.h M sysmoOCTSIM/main.c 3 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/16/42616/1 diff --git a/sysmoOCTSIM/gcc/gcc/startup_same54.c b/sysmoOCTSIM/gcc/gcc/startup_same54.c index 097a1c4..943c965 100644 --- a/sysmoOCTSIM/gcc/gcc/startup_same54.c +++ b/sysmoOCTSIM/gcc/gcc/startup_same54.c @@ -668,11 +668,18 @@ ; } +volatile bool break_on_panic = false; + /** * \brief Default interrupt handler for unused IRQs. */ void Dummy_Handler(void) { - while (1) { + if (break_on_panic) + __asm("BKPT #0"); /* wait for JTAG/SWD */ + else { + NVIC_SystemReset(); + while (1) + ; } } diff --git a/sysmoOCTSIM/include/same54.h b/sysmoOCTSIM/include/same54.h index 7da756e..c99d91f 100644 --- a/sysmoOCTSIM/include/same54.h +++ b/sysmoOCTSIM/include/same54.h @@ -47,4 +47,10 @@ #error Library does not support the specified device. #endif +#include <stdbool.h> + +/* Either reset or break on panic/unknown irq. Default is reset. */ +extern volatile bool break_on_panic; +void Dummy_Handler(void); + #endif /* _SAME54_ */ diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 7873c86..02feeb6 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -38,9 +38,9 @@ #include "ccid_device.h" #include "usb_descriptors.h" -static void bdg_bkptpanic(const char *fmt, va_list args) +static void panic_handler(const char *fmt, va_list args) { - __asm("BKPT #0"); + Dummy_Handler(); } extern struct ccid_slot_ops iso_fsm_slot_ops; @@ -600,7 +600,7 @@ int main(void) { - osmo_set_panic_handler(&bdg_bkptpanic); + osmo_set_panic_handler(&panic_handler); #if 0 CoreDebug->DEMCR |= CoreDebug_DEMCR_TRCENA_Msk ; //| /* tracing*/ ////CoreDebug_DEMCR_MON_EN_Msk; /* mon interupt catcher */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ibcabe0c58ff14ebe76159470dd90fdef064febea Gerrit-Change-Number: 42616 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: remove timer
by lynxis lazus 14 Apr '26

14 Apr '26

Attention is currently required from: osmith. lynxis lazus has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42610?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: remove timer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42610?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4fdb6d504c7a08cf258e82436627894602f7301 Gerrit-Change-Number: 42610 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 13:51:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: various tweaks
by lynxis lazus 14 Apr '26

14 Apr '26

Attention is currently required from: osmith. lynxis lazus has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42609?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: various tweaks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If64787efbe4a1305cd60941b69e9416960d056a2 Gerrit-Change-Number: 42609 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Apr 2026 13:51:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add email param
by osmith 14 Apr '26

14 Apr '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42607?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add email param ...................................................................... jobs/octsim_osmo-ccid-firmware: add email param Allow configuring the email notifications before starting a job, so no notifications can be set while testing changes to the jenkins job. Add jenkins-notifications(a)lists.osmocom.org while at it, as we have it with almost all other jobs. Change-Id: Ifcd580873479fc259119139d47447ba0e21b21f4 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 599acc1..e64e7ea 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -7,6 +7,11 @@ - octsimtest block-downstream: false block-upstream: false + parameters: + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: 'jenkins-notifications(a)lists.osmocom.org jsteiger(a)sysmocom.de acouzens(a)sysmocom.de' builders: - shell: | cd ./tests @@ -43,7 +48,7 @@ publishers: - email: notify-every-unstable-build: true - recipients: jsteiger(a)sysmocom.de acouzens(a)sysmocom.de + recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: true retry-count: '3' triggers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifcd580873479fc259119139d47447ba0e21b21f4 Gerrit-Change-Number: 42607 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: don't use axis
by osmith 14 Apr '26

14 Apr '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42608?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: don't use axis ...................................................................... jobs/octsim_osmo-ccid-firmware: don't use axis There is only one node, so we can specify it directly instead of using a build axis. Change-Id: I552c8f1b244c8e8b0f902720698fbb6ba660fb72 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index e64e7ea..c777fe0 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -1,10 +1,5 @@ - job: - axes: - - axis: - name: label - type: slave - values: - - octsimtest + node: octsimtest block-downstream: false block-upstream: false parameters: @@ -24,7 +19,6 @@ execution-strategy: sequential: false name: octsim_osmo-ccid-firmware - project-type: matrix scm: - git: url: https://gerrit.osmocom.org/osmo-ccid-firmware -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I552c8f1b244c8e8b0f902720698fbb6ba660fb72 Gerrit-Change-Number: 42608 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026