Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 1: (2 comments) File src/rspro_util.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/a22eedfa_54138a91?u... : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu);

You decided to free pdu here in case of encoding failure. […] Acknowledged

https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/be903414_8bb96dc5?u... : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu);

Same issue here. This casues a double free. No this is different, as it returns NULL.

-- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas@eversberg.eu>