Attention is currently required from: jolly, laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email )
Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ......................................................................
Patch Set 1:
(2 comments)
File src/rspro_util.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/a22eedfa_54138a91?u... : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu);
You decided to free pdu here in case of encoding failure. […]
Acknowledged
https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/be903414_8bb96dc5?u... : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu);
Same issue here. This casues a double free.
No this is different, as it returns NULL.