March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: testenv: do not install/check-for libfftranscode
by laforge 13 Mar '26

13 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42334?usp=email ) Change subject: testenv: do not install/check-for libfftranscode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42334?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I410deedd1d4671496a8a784690bf630f2bdf6b53 Gerrit-Change-Number: 42334 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Mar 2026 20:24:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/ngap: do not link against libfftranscode
by laforge 13 Mar '26

13 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42333?usp=email ) Change subject: library/ngap: do not link against libfftranscode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ea63993278a5e0ca22fc4217c2c3c5f8f9dc0a6 Gerrit-Change-Number: 42333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Mar 2026 20:24:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: fix msgb/list mixed irq access handling
by laforge 13 Mar '26

13 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42319?usp=email ) Change subject: firmware: fix msgb/list mixed irq access handling ...................................................................... firmware: fix msgb/list mixed irq access handling This fixes the mishandling of in_progress and the queues in the submit functions that are in part irq driven, too, and ensures nothing breaks by preventing concurrent access from irqs to the queues. Applying the same pattern to all functions/cases is fine either way. On top of all of tha the out ep was irq driven, so if submit_next_out fails it was stuck, now fixed by attempted submit from main loop, and of course the queue manipulation should be irq safe here as well. Change-Id: I9212bfa7688cb4d3161ba963b854225744128632 --- M sysmoOCTSIM/main.c 1 file changed, 43 insertions(+), 30 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 92c5bbd..e1e83c7 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -159,19 +159,26 @@ static int submit_next_in(void) { struct usb_ep_q *ep_q = &g_ccid_s.in_ep; - struct msgb *msg; + struct msgb *msg = NULL; int rc; - if (ep_q->in_progress) - return 0; + CRITICAL_SECTION_ENTER() + if (!ep_q->in_progress) { + msg = msgb_dequeue(&ep_q->list); + if (msg) + ep_q->in_progress = msg; + } + CRITICAL_SECTION_LEAVE() - msg = msgb_dequeue_irqsafe(&ep_q->list); if (!msg) return 0; - ep_q->in_progress = msg; rc = ccid_df_write_in(msgb_data(msg), msgb_length(msg)); if (rc != ERR_NONE) { + CRITICAL_SECTION_ENTER() + ep_q->in_progress = NULL; + msgb_enqueue(&g_ccid_s.free_q, msg); + CRITICAL_SECTION_LEAVE() printf("EP %s failed: %d\r\n", ep_q->name, rc); return -1; } @@ -183,22 +190,27 @@ static int submit_next_irq(void) { struct usb_ep_q *ep_q = &g_ccid_s.irq_ep; - struct msgb *msg; + struct msgb *msg = NULL; int rc; - if (ep_q->in_progress) - return 0; + CRITICAL_SECTION_ENTER() + if (!ep_q->in_progress) { + msg = msgb_dequeue(&ep_q->list); + if (msg) + ep_q->in_progress = msg; + } + CRITICAL_SECTION_LEAVE() - msg = msgb_dequeue_irqsafe(&ep_q->list); if (!msg) return 0; - ep_q->in_progress = msg; rc = ccid_df_write_irq(msgb_data(msg), msgb_length(msg)); /* may return HALTED/ERROR/DISABLED/BUSY/ERR_PARAM/ERR_FUNC/ERR_DENIED */ if (rc != ERR_NONE) { - // ep_q->in_progress = msg; - // msgb_enqueue_irqsafe(&ep_q->list, msg); + CRITICAL_SECTION_ENTER() + ep_q->in_progress = NULL; + msgb_enqueue(&g_ccid_s.free_q, msg); + CRITICAL_SECTION_LEAVE() printf("EP %s failed: %d\r\n", ep_q->name, rc); return -1; } @@ -208,22 +220,29 @@ static int submit_next_out(void) { struct usb_ep_q *ep_q = &g_ccid_s.out_ep; - struct msgb *msg; + struct msgb *msg = NULL; int rc; - if (ep_q->in_progress) - return 0; + CRITICAL_SECTION_ENTER() + if (!ep_q->in_progress) { + msg = msgb_dequeue(&g_ccid_s.free_q); + if (msg) { + msgb_reset(msg); + ep_q->in_progress = msg; + } + } + CRITICAL_SECTION_LEAVE() - msg = msgb_dequeue_irqsafe(&g_ccid_s.free_q); if (!msg) - return -1; - msgb_reset(msg); - ep_q->in_progress = msg; + return 0; rc = ccid_df_read_out(msgb_data(msg), msgb_tailroom(msg)); if (rc != ERR_NONE) { + CRITICAL_SECTION_ENTER() + ep_q->in_progress = NULL; /* re-add to the list of free msgb's */ - llist_add_tail_at(&msg->list, &g_ccid_s.free_q); + msgb_enqueue(&g_ccid_s.free_q, msg); + CRITICAL_SECTION_LEAVE() return 0; } return 1; @@ -494,7 +513,7 @@ OSMO_ASSERT(msg); /* append to list of pending-to-be-handed messages */ - llist_add_tail_at(&msg->list, &g_ccid_s.in_ep.list); + msgb_enqueue_irqsafe(&g_ccid_s.in_ep.list, msg); submit_next_in(); return 0; } @@ -557,19 +576,12 @@ msgb_reset(msg); llist_add_tail_at(&msg->list, &g_ccid_s.free_q); } -#if 0 struct msgb *cur_msg = cur_epq->in_progress; if (cur_msg) { - /* - if (i == 2 && usb_d_ep_get_status(/*_ccid_df_funcd.func_ep_out*/ 2, 0) == USB_BUSY) - continue; - */ - msgb_reset(cur_msg); - llist_add_tail_at(&cur_msg->list, &g_ccid_s.free_q); + msgb_enqueue(&g_ccid_s.free_q, cur_msg); cur_epq->in_progress = NULL; } -#endif } SysTick->CTRL |= SysTick_CTRL_ENABLE_Msk; @@ -715,7 +727,8 @@ struct msgb *msg = msgb_alloc(300, "ccid"); OSMO_ASSERT(msg); /* return the message back to the queue of free message buffers */ - llist_add_tail_at(&msg->list, &g_ccid_s.free_q); + msgb_enqueue_irqsafe(&g_ccid_s.free_q, msg); } + submit_next_out(); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9212bfa7688cb4d3161ba963b854225744128632 Gerrit-Change-Number: 42319 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: generate proper error for short messages
by laforge 13 Mar '26

13 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42318?usp=email ) Change subject: ccid: generate proper error for short messages ...................................................................... ccid: generate proper error for short messages Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf --- M ccid_common/ccid_device.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid_common/ccid_device.c b/ccid_common/ccid_device.c index 8a53860..7866d9f 100644 --- a/ccid_common/ccid_device.c +++ b/ccid_common/ccid_device.c @@ -836,8 +836,10 @@ short_msg: LOGP(DCCID, LOGL_ERROR, "Short CCID message received: %s; ignoring\n", msgb_hexdump(msg)); + resp = gen_err_resp(ch->bMessageType, ch->bSlot, get_icc_status(cs), ch->bSeq, + CCID_ERR_CMD_NOT_SUPPORTED); msgb_free(msg); - return -1; + return ccid_slot_send_unbusy(cs, resp); } /* Section 5.3.1 ABORT */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf Gerrit-Change-Number: 42318 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: fix msgb/list mixed irq access handling
by laforge 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42319?usp=email ) Change subject: firmware: fix msgb/list mixed irq access handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9212bfa7688cb4d3161ba963b854225744128632 Gerrit-Change-Number: 42319 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Mar 2026 20:17:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: generate proper error for short messages
by laforge 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42318?usp=email ) Change subject: ccid: generate proper error for short messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf Gerrit-Change-Number: 42318 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Mar 2026 20:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: fw: add git blame ignore file
by laforge 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42331?usp=email ) Change subject: fw: add git blame ignore file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I35b86f52d491c9e28ab0af9e3e3d4fd5f6dbd119 Gerrit-Change-Number: 42331 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Mar 2026 20:16:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ensure libosmocore logging is properly disabled for builds
by laforge 13 Mar '26

13 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email ) Change subject: ensure libosmocore logging is properly disabled for builds ...................................................................... ensure libosmocore logging is properly disabled for builds Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 --- M sysmoOCTSIM/gcc/Makefile 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index 0f2a909..461b313 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -164,7 +164,7 @@ vpath %.S ../ # All Target -all: $(SUB_DIRS) elf bin ihex eep lss +all: $(SUB_DIRS) elf bin ihex eep lss check-no-logging elf: $(OUTPUT_FILE_NAME).elf sysmoOCTSIM.elf bin: $(OUTPUT_FILE_NAME).bin sysmoOCTSIM.bin @@ -246,5 +246,12 @@ $(OUTPUT_FILE_NAME).lss $(OUTPUT_FILE_NAME).eep $(OUTPUT_FILE_NAME).map \ $(OUTPUT_FILE_NAME).srec +check-no-logging: $(OUTPUT_FILE_PATH) + @if $(NM) $< | grep -q ' T logp2'; then \ + echo "FAIL: logging symbols linked into release ELF (libosmocore --disable-log-macros missing/broken?)"; \ + $(NM) $< | grep ' T $logp2\|osmo_vlogp\|log_check_level\|logp_stub$'; \ + exit 1; \ + fi + mrproper: clean rm -f *.o *.d *.a *.elf *.bin *.ihex *.eep *.lss *.map *.srec -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 Gerrit-Change-Number: 42208 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: ensure libosmocore logging is properly disabled for builds
by laforge 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email ) Change subject: ensure libosmocore logging is properly disabled for builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 Gerrit-Change-Number: 42208 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Mar 2026 20:15:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section
by laforge 13 Mar '26

13 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42176?usp=email ) Change subject: dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section ...................................................................... dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section In the MANIFEST state, the IRQ won't move the state, but to prevent incosistency between dfu_manifestation_complete & dfu_state, use a critical section. Change-Id: Idf5fb7d55b4051ba7e235dfa409a4de18a8f208c --- M usb_start.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/usb_start.c b/usb_start.c index 78711f1..0b99746 100644 --- a/usb_start.c +++ b/usb_start.c @@ -189,12 +189,14 @@ case USB_DFU_STATE_DFU_MANIFEST: // we can start manifestation (finish flashing) // in theory every DFU files should have a suffix to with a CRC to check the data // in practice most downloaded files are just the raw binary with DFU suffix + CRITICAL_SECTION_ENTER(); dfu_manifestation_complete = true; // we completed flashing and all checks if (usb_dfu_func_desc->bmAttributes & USB_DFU_ATTRIBUTES_MANIFEST_TOLERANT) { dfu_state = USB_DFU_STATE_DFU_MANIFEST_SYNC; } else { dfu_state = USB_DFU_STATE_DFU_MANIFEST_WAIT_RESET; } + CRITICAL_SECTION_LEAVE(); break; case USB_DFU_STATE_DFU_MANIFEST_WAIT_RESET: if (usb_dfu_func_desc->bmAttributes & USB_DFU_ATTRIBUTES_WILL_DETACH) { -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Idf5fb7d55b4051ba7e235dfa409a4de18a8f208c Gerrit-Change-Number: 42176 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026