Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email )
Change subject: doc/manuals: add overview, document running and configuration
......................................................................
Patch Set 4:
(8 comments)
File README.md:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/4215086b_47ca… :
PS4, Line 131: `make install` deploys a complete ERTS release together with a convenience
the edits in this line until the end of this section don't seem like improvements to me, it just adds more LLM style with mdashes and verbosity IMHO.
File doc/manuals/chapters/overview.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/306782c9_c824… :
PS4, Line 9: , i.e. radio base stations
seems unnecessary, people reading this should be familiar with what an eNodeB is, so I suggest to remove that
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/a43ed260_875d… :
PS4, Line 38: ----
instead of such ascii art diagrams, we typically use graphviz graphs in manuals: https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr/src/commit/459ae…
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/7495f2c9_9736… :
PS4, Line 32: Useful for testing new features or bug fixes before they are formally released.
Given that this is project specific documentation, I would remove above block starting with "Two package feeds are available". This is on the wiki page as well, with additional information, and then we have one less location where we potentially need to update this information, e.g. if we added a third feed at some point.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/f60869db_f2ab… :
PS4, Line 97: | `BINDIR` | Installation directory for executables | `/usr/bin`
side note: other Osmocom programs "make install" to /usr/local by default
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/8b7ba778_4353… :
PS4, Line 107: Running `make install` (typically as root, or with `DESTDIR` set for
This is very verbose. Do we need to explain where every single file goes here? This also means it needs to be updated when we should add additional files. IMHO saying that the user needs to run `make install`, and maybe also describing that there is `DESTDIR`, is enough.
(also this doesn't render properly: https://nextcloud.sysmocom.de/s/FYMZ2rpe3aRKQYm)
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/02186ffd_88a2… :
PS4, Line 128: ==== The `osmo-s1gw` Bootstrap Script
This is also very verbose. Do we need this section at all? We could also briefly refer to running `osmo-s1gw -h` for more information, then we don't need to update the help text in two places when making changes to the arguments.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/1203b10a_0ba6… :
PS4, Line 198: Wireshark and are tagged with the application name `OsmoS1GW`.
why is this worth mentioning? " and are tagged with the application name `OsmoS1GW`."
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb
Gerrit-Change-Number: 42364
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 11:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT
......................................................................
Patch Set 2:
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/f57f2d56_ba8dde0d?usp… :
PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
> why ignore it here? I'd actually propagate the error since it means there was an error, there's no n […]
I've updated it so that an invalid timeslot now results in an error instead of being ignored.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53
Gerrit-Change-Number: 42421
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 11:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 5:
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c33907f7_bdcffb71?usp… :
PS4, Line 913: snprintf(response, response_size, "RSP POWEROFF 0");
> This change to snprintf is welcome but it is definetly a different patch.
I've moved this into a separate patch - https://gerrit.osmocom.org/c/osmo-trx/+/42422
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 11:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: transceiver: return -EINVAL for invalid SETSLOT
......................................................................
transceiver: return -EINVAL for invalid SETSLOT
Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53
---
M Transceiver52M/Transceiver.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/21/42421/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53
Gerrit-Change-Number: 42421
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: transceiver: make control command parsing arguments const
......................................................................
transceiver: make control command parsing arguments const
Change-Id: I2f3aa5363c337791451a388f394d7351d3183908
---
M Transceiver52M/Transceiver.cpp
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/20/42420/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2f3aa5363c337791451a388f394d7351d3183908
Gerrit-Change-Number: 42420
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: transceiver: split control command handling from socket I/O
......................................................................
transceiver: split control command handling from socket I/O
- move control command parsing/response generation into ctrl_cmd_handle()
- keep ctrl_sock_handle_rx() focused on socket read/write
- switch response formatting from sprintf() to snprintf()
Change-Id: I5413aa511e951522270c75635e89448395fc429e
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
2 files changed, 33 insertions(+), 22 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/42410/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42419?usp=email )
Change subject: NGAP_Templates: Fix wrong IE id in n2_PDUSessionResourceModifyConfirm
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42419?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iddcf4e3081d47f91e3b6ec52186116bf93e28c90
Gerrit-Change-Number: 42419
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 11:00:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42418?usp=email )
Change subject: 5gc: Introduce test TC_secondary_rat_data_usage_report
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42418?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8a82b1a8bcea948356d819af5c4919ae3829e549
Gerrit-Change-Number: 42418
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 10:59:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42415?usp=email )
Change subject: 5gc: Document multiple inter RAT procedures not implemented
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42415?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I71cee40c79d7266ca46fa9757df18605646b320f
Gerrit-Change-Number: 42415
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 10:50:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes