March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42347?usp=email ) Change subject: s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param ...................................................................... s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param On timeout pdu was never assigned (it's an out parameter), so TITAN logs <unbound>. The useful diagnostic is the expected template, not the received value. Change-Id: Idceefa82ec1b5fc71228b3847c7a22f419c9675e Fixes: 325d07697 ("s1gw: add TC_uemux_uldl_nas_release") --- M s1gw/S1GW_UEMux.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/s1gw/S1GW_UEMux.ttcn b/s1gw/S1GW_UEMux.ttcn index baecaff..977ceb1 100644 --- a/s1gw/S1GW_UEMux.ttcn +++ b/s1gw/S1GW_UEMux.ttcn @@ -65,7 +65,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } [] T.timeout { - setverdict(fail, "Timeout waiting for S1AP PDU (", dir, "): ", pdu); + setverdict(fail, "Timeout waiting for S1AP PDU (", dir, "): ", tr_pdu); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idceefa82ec1b5fc71228b3847c7a22f419c9675e Gerrit-Change-Number: 42347 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_s1ap_setup(): make SupportedTAs configurable
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42348?usp=email ) Change subject: s1gw: f_ConnHdlr_s1ap_setup(): make SupportedTAs configurable ...................................................................... s1gw: f_ConnHdlr_s1ap_setup(): make SupportedTAs configurable Change-Id: Iade1889a702ef75859c5f847961ee4ca2398d4e1 Related: SYS#7052 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 615f13e..d1f830b 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -72,6 +72,14 @@ iE_Extensions := omit } +const SupportedTAs c_SupportedTAs := { + { + tAC := '0000'O, + broadcastPLMNs := { '00f110'O }, + iE_Extensions := omit + } +}; + const TargetID c_TargetID := { targeteNB_ID := { global_ENB_ID := { @@ -245,21 +253,13 @@ } } -function f_ConnHdlr_s1ap_setup(Global_ENB_ID genb_id, float Tval := 5.0) runs on ConnHdlr { +function f_ConnHdlr_s1ap_setup(Global_ENB_ID genb_id, + in SupportedTAs supported_tas := c_SupportedTAs, + float Tval := 5.0) runs on ConnHdlr { var S1AP_PDU pdu; timer T; - var SupportedTAs supported_tas_dummy := { - { - tAC := '0000'O, - broadcastPLMNs := { '00f000'O }, - iE_Extensions := omit - } - }; - - f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_SetupReq(genb_id, - supported_tas_dummy, - v32)); + f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_SetupReq(genb_id, supported_tas, v32)); T.start(Tval); alt { [] S1AP_CONN.receive(S1APSRV_Event:S1APSRV_EVENT_CONN_UP) { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iade1889a702ef75859c5f847961ee4ca2398d4e1 Gerrit-Change-Number: 42348 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: make S1AP_Server.f_conn_add() return nothing
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42350?usp=email ) Change subject: s1gw: make S1AP_Server.f_conn_add() return nothing ...................................................................... s1gw: make S1AP_Server.f_conn_add() return nothing The index of a new entry is not used anywhere, so do not return it. Change-Id: I8df3985a665ae919849559ea8cf0fd33b5b22df8 --- M s1gw/S1AP_Server.ttcn 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1AP_Server.ttcn b/s1gw/S1AP_Server.ttcn index 5bd83a4..df91eaa 100644 --- a/s1gw/S1AP_Server.ttcn +++ b/s1gw/S1AP_Server.ttcn @@ -128,9 +128,9 @@ return -1; } -/* add a new connection, return its index */ +/* add a new connection */ private function f_conn_add(ConnectionId conn_id) -runs on S1AP_Server_CT return integer { +runs on S1AP_Server_CT { var ConnData conn := { conn_id, - }; var integer idx; @@ -139,11 +139,8 @@ mtc.stop; } - idx := lengthof(g_conn_list); g_conn_list := g_conn_list & { conn }; log("Connection (id=", conn_id, ") is registered"); - - return idx; } /* del an existing connection */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8df3985a665ae919849559ea8cf0fd33b5b22df8 Gerrit-Change-Number: 42350 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: remove unused mp_s1gw_mme_ip
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42349?usp=email ) Change subject: s1gw: remove unused mp_s1gw_mme_ip ...................................................................... s1gw: remove unused mp_s1gw_mme_ip We don't really care what address the S1GW is using when connecting to our virtual MME. This is why this parameter is not used anywhere. Change-Id: I4fff3954c005ac3df34d00c3b0312300ba4f49a1 --- M s1gw/S1GW_Tests.cfg M s1gw/S1GW_Tests.ttcn 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_Tests.cfg b/s1gw/S1GW_Tests.cfg index 69e893f..8174b9e 100644 --- a/s1gw/S1GW_Tests.cfg +++ b/s1gw/S1GW_Tests.cfg @@ -13,7 +13,6 @@ [MODULE_PARAMETERS] S1GW_Tests.mp_s1gw_enb_ip := "127.0.1.1"; S1GW_Tests.mp_enb_bind_ip := "127.0.1.10"; -S1GW_Tests.mp_s1gw_mme_ip := "127.0.2.1"; S1GW_Tests.mp_mme_bind_ip := "127.0.2.10"; S1GW_Tests.mp_s1gw_upf_ip := "127.0.3.1"; S1GW_Tests.mp_upf_bind_ip := "127.0.3.10"; diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 43cbe74..ff4734d 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -54,7 +54,6 @@ modulepar { charstring mp_s1gw_enb_ip := "127.0.1.1"; /* eNB facing address of the S1GW */ charstring mp_enb_bind_ip := "127.0.1.10"; /* eNB address to use locally when connecting to S1GW */ - charstring mp_s1gw_mme_ip := "127.0.2.1"; /* MME facing address of the S1GW */ charstring mp_mme_bind_ip := "127.0.2.10"; /* MME address on which we get connections from S1GW */ charstring mp_s1gw_upf_ip := "127.0.3.1"; /* UPF facing address of the S1GW */ charstring mp_upf_bind_ip := "127.0.3.10"; /* UPF address on which we get connections from S1GW */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fff3954c005ac3df34d00c3b0312300ba4f49a1 Gerrit-Change-Number: 42349 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: improve conn established/closed logging
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42351?usp=email ) Change subject: s1gw: improve conn established/closed logging ...................................................................... s1gw: improve conn established/closed logging Change-Id: Iacda25ac9b34fc55217e2681e434c68eef2d3445 --- M s1gw/S1AP_Server.ttcn 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1AP_Server.ttcn b/s1gw/S1AP_Server.ttcn index df91eaa..6d5d254 100644 --- a/s1gw/S1AP_Server.ttcn +++ b/s1gw/S1AP_Server.ttcn @@ -398,16 +398,18 @@ /* connection opened/closed events */ [] S1AP.receive(PortEvent:{connOpened := ?}) -> value pev { - log("eNB connection (id=", pev.connOpened.connId, ", ", - pev.connOpened.remName, ":", pev.connOpened.remPort, ") ", - "established"); - f_conn_add(pev.connOpened.connId); + var ConnectionOpenedEvent ev := pev.connOpened; + log("eNB connection (id=", ev.connId, ", ", + "r=", ev.remName, ":", ev.remPort, "<->", + "l=", ev.locName, ":", ev.locPort, ") established"); + f_conn_add(ev.connId); } [] S1AP.receive(PortEvent:{connClosed := ?}) -> value pev { - log("eNB connection (id=", pev.connClosed.connId, ", ", - pev.connClosed.remName, ":", pev.connClosed.remPort, ") ", - "closed"); - f_conn_del(pev.connClosed.connId); + var ConnectionOpenedEvent ev := pev.connClosed; + log("eNB connection (id=", ev.connId, ", ", + "r=", ev.remName, ":", ev.remPort, "<->", + "l=", ev.locName, ":", ev.locPort, ") closed"); + f_conn_del(ev.connId); } /* SCTP events we don't care about */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacda25ac9b34fc55217e2681e434c68eef2d3445 Gerrit-Change-Number: 42351 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: fix TC_uemux_e_rab_release_ind: pass release_ind := true
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42341?usp=email ) Change subject: s1gw: fix TC_uemux_e_rab_release_ind: pass release_ind := true ...................................................................... s1gw: fix TC_uemux_e_rab_release_ind: pass release_ind := true TC_uemux_e_rab_release_ind never actually tests the release indication because release_ind is false instead of true. The test body becomes identical to TC_uemux_e_rab_setup - no release indication is ever sent. Change-Id: Ieed5d8a2bf4f696efc1071569090facc7b731f96 Fixes: cdc149a6 ("s1gw: add UEMux TCs for E-RAB SETUP and RELEASE") --- M s1gw/S1GW_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index a498995..6623b1f 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -822,7 +822,7 @@ var ERabList erabs := { pars.erabs[i] }; vc_ues[i] := f_UEMuxUE_create(vc_uemux, pars, i, i); - vc_ues[i].start(f_TC_uemux_e_rab_setup_release(erabs, release_ind := false)); + vc_ues[i].start(f_TC_uemux_e_rab_setup_release(erabs, release_ind := true)); } f_UEMuxUEList_all_done(vc_ues); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieed5d8a2bf4f696efc1071569090facc7b731f96 Gerrit-Change-Number: 42341 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: fix f_ConnHdlr_erab_release_cmd_(): do not discard cause
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42343?usp=email ) Change subject: s1gw: fix f_ConnHdlr_erab_release_cmd_(): do not discard cause ...................................................................... s1gw: fix f_ConnHdlr_erab_release_cmd_(): do not discard cause Change-Id: I8c75e08dd041ce805aa232984445ba1e2bde40fa Fixes: 64db5053 ("s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID") --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index b850f55..1301bbd 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1550,7 +1550,7 @@ function f_ConnHdlr_erab_release_cmd_(S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) runs on ConnHdlr { - f_ConnHdlr_erab_release_cmd(g_pars.erabs, g_pars.mme_ue_id, g_pars.idx); + f_ConnHdlr_erab_release_cmd(g_pars.erabs, g_pars.mme_ue_id, g_pars.idx, cause); } function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c75e08dd041ce805aa232984445ba1e2bde40fa Gerrit-Change-Number: 42343 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42342?usp=email ) Change subject: s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU ...................................................................... s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU setup_rsp is carefully constructed, but is not actually used. The f_ConnHdlr_rx_s1ap_from_enb() call falls through to the ? default, so the test accepts any S1AP PDU and never validates that the S1GW actually populated the failed-items list correctly. Change-Id: I6dbe272af4302c83ac26db9b7da5a7f7bc96daa7 Fixes: 47544443 ("s1gw: add TC_e_rab_setup_failure") --- M s1gw/S1GW_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 6623b1f..43cbe74 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -507,7 +507,7 @@ setup_rsp := tr_S1AP_RABSetupRsp(g_pars.mme_ue_id, g_pars.idx, rab_setup_items := omit, rab_failed_items := tr_E_RABList(item)); - f_ConnHdlr_rx_s1ap_from_enb(s1ap_pdu); + f_ConnHdlr_rx_s1ap_from_enb(s1ap_pdu, setup_rsp); f_ConnHdlr_s1ap_disconnect(); f_ConnHdlr_s1ap_unregister(g_pars.genb_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dbe272af4302c83ac26db9b7da5a7f7bc96daa7 Gerrit-Change-Number: 42342 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email ) Change subject: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null ...................................................................... s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null After deactivate, conn_track still holds the now-dead reference. A second call (which can happen if any test explicitly calls this before f_ConnHdlr_s1ap_disconnect()) will attempt to deactivate an already-inactive default, which is a TTCN-3 runtime error. Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b Fixes: adc942a94 ("s1gw: track eNB connection, fail immediately on loss") --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 3decbcf..298a983 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -113,6 +113,7 @@ function f_ConnHdlr_conn_track_disable() runs on ConnHdlr { if (conn_track != null) { deactivate(conn_track); + conn_track := null; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b Gerrit-Change-Number: 42345 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList
by fixeria 14 Mar '26

14 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42346?usp=email ) Change subject: s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList ...................................................................... s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList Change-Id: If471e9f8daba918d1de90725db34e1930fd2e4d5 Fixes: 8eba9aada ("S1GW tests: Add test cases for S1 handover procedure") --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 298a983..615f13e 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1776,11 +1776,10 @@ function f_ConnHdlr_handover_rqd_() runs on ConnHdlr { - f_ConnHdlr_handover_rqd(g_pars.erabs, g_pars.mme_ue_id, g_pars.idx); + f_ConnHdlr_handover_rqd(g_pars.mme_ue_id, g_pars.idx); } -function f_ConnHdlr_handover_rqd(in ERabList erabs, - MME_UE_S1AP_ID mme_ue_id, +function f_ConnHdlr_handover_rqd(MME_UE_S1AP_ID mme_ue_id, ENB_UE_S1AP_ID enb_ue_id) runs on ConnHdlr { log("[eNB -> S1GW] -> MME: HANDOVER REQUIRED"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If471e9f8daba918d1de90725db34e1930fd2e4d5 Gerrit-Change-Number: 42346 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026