Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email )
Change subject: fw source: force reformat once and for all
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is the result of clang-format-20 --verbose -style=file:.clang-format -i {sysmoOCTSIM,ccid_common}/*{.c,.h} and the linter disagrees, so at this point I don't even know what rules are being enforced, apparently not the rules specified by the .clang-format file.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f
Gerrit-Change-Number: 42330
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 12 Mar 2026 16:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hoernchen.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email )
Change subject: fw source: force reformat once and for all
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Clearly the formatting rules expected by the linter disagree a lot with all of the existing code. Either the rules need to be adjusted, or the code, either way, one of these has to happen to put this topic to rest after years of formatting misadventures.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f
Gerrit-Change-Number: 42330
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Mar 2026 16:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42329?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: 5gc: parametrize RequestType in f_pdu_sess_establish()
......................................................................
5gc: parametrize RequestType in f_pdu_sess_establish()
Change-Id: I69d6be5e581565720a21c719b0f982eb31ec2adf
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M library/NG_NAS_Osmo_Types.ttcn
3 files changed, 19 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/42329/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42329?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I69d6be5e581565720a21c719b0f982eb31ec2adf
Gerrit-Change-Number: 42329
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages
......................................................................
Patch Set 3:
(1 comment)
File ccid_common/iso7816_fsm.h:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/e523903a_3a… :
PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
> I don't understant why it's so hard to first reformat the code, and then add your changes on top of […]
yes, really interesting, i wonder why that is? interestingly I rarely see any other developer even submitting any kind of "formatting first then changes" commits for review in the first place, maybe because no one touches those code parts with artisanal formatting that are impossible to modify without reformatting or adjusting the linter? Its really weird how I'm apaprently supposed to take shit for touching these parts, as usual.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70
Gerrit-Change-Number: 42306
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 15:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42328?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: 5gc: Introduce TC_handover_inter_ngran_n2_cancel
......................................................................
5gc: Introduce TC_handover_inter_ngran_n2_cancel
Change-Id: I1137c9a82478cca0372678d3c3299e9eebc79bd5
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
M library/NGAP_Emulation.ttcn
M library/NGAP_Functions.ttcn
5 files changed, 88 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/42328/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42328?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1137c9a82478cca0372678d3c3299e9eebc79bd5
Gerrit-Change-Number: 42328
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder