Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
Patch Set 1:
(1 comment)
File rebar.lock:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413/comment/17d7cf32_a64b… :
PS1, Line 21: {ref,"bfd6c095bfc404e5fab5c07f5ebe0fe305e58830"}},
> The branch is already named in the repo, are you suggesting to rename it?
yeah, or leave the "counter" one but create a new "osmocom/master" one.
Otherwise it's not obvious which branch should be picked when looking at the repo. "counter" may be just a WIP branch, a feature branch, etc.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 12:09:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
Patch Set 1:
(1 comment)
File rebar.lock:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413/comment/3347f111_1bca… :
PS1, Line 21: {ref,"bfd6c095bfc404e5fab5c07f5ebe0fe305e58830"}},
> That's why I wrote "in that repo", and not "here" :)
The branch is already named in the repo, are you suggesting to rename it?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 12:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
Patch Set 1:
(1 comment)
File rebar.lock:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413/comment/33a3be91_9404… :
PS1, Line 21: {ref,"bfd6c095bfc404e5fab5c07f5ebe0fe305e58830"}},
> `rebar.lock` is not supposed to contain branch names (they're in `rebar. […]
That's why I wrote "in that repo", and not "here" :)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 12:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
Patch Set 1:
(1 comment)
File rebar.lock:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413/comment/e4b529b8_0ec5… :
PS1, Line 21: {ref,"bfd6c095bfc404e5fab5c07f5ebe0fe305e58830"}},
> can we maybe name the branch "osmocom/master" in that repo?
`rebar.lock` is not supposed to contain branch names (they're in `rebar.config` instead); it pins the exact commit hashes for each repository.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 11:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
Patch Set 1:
(1 comment)
File rebar.lock:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413/comment/fca53a76_3ade… :
PS1, Line 21: {ref,"bfd6c095bfc404e5fab5c07f5ebe0fe305e58830"}},
can we maybe name the branch "osmocom/master" in that repo?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 11:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 11:46:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email )
Change subject: rebar.lock: bump exometer_report_statsd version
......................................................................
rebar.lock: bump exometer_report_statsd version
The new version is using ETS instead of dict for counter lookups.
This significantly reduces performance impact when multiple eNBs
are registered, since the ETS provides O(1) average-case hash
lookups and in-place mutation.
Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
---
M rebar.lock
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/13/42413/1
diff --git a/rebar.lock b/rebar.lock
index 1efe90b..439ea74 100644
--- a/rebar.lock
+++ b/rebar.lock
@@ -18,7 +18,7 @@
0},
{<<"exometer_report_statsd">>,
{git,"https://github.com/osmocom/exometer_report_statsd.git",
- {ref,"d35a98edf87996f2ab9ef0feda93b38677b0d063"}},
+ {ref,"bfd6c095bfc404e5fab5c07f5ebe0fe305e58830"}},
0},
{<<"hut">>,{pkg,<<"hut">>,<<"1.3.0">>},1},
{<<"jiffy">>,
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I931321a831215012aa8186d851d9a8d38908a4bf
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 3:
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/1868fef0_a0478afb?usp… :
PS3, Line 1026: return -EINVAL;
> The logic is preserved here. […]
My point is that I don't see why do you decided to move the "return EINVAL here instead of 0 and decide to convert EINVAl to o 0 in other function" logic.
I see no good reason to do that in this patch.
If you consider that this path should return an error instead of 0 (which may be correct) then please submit a different patch changing this.
It seems the diferentiation for this path returning non-error was made in 76ff96e21079db2cd7123ff9ca33fa7d2fb0cb01 (by me) but there's no real description on why was that, and I think we should indeed fail if timeslot reading fails.
So please, if you want to change the logic, submit a patch before or after this one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 11:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>