March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to...
by pespin 11 Mar '26

11 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42320?usp=email ) Change subject: NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverCommand ...................................................................... NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverCommand That IE is mandatory in HandoverCommand. Change-Id: I59be738e8143ca1b9fee91c1bb377970e741efc5 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/42320/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 46e55bf..f1573a5 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -3939,7 +3939,8 @@ in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, in template (value) HandoverType p_handoverType := PX_HANDOVER_TYPE, - in template (value) PDUSessionResourceHandoverList p_pDUSessionResourceHandoverList + in template (value) PDUSessionResourceHandoverList p_pDUSessionResourceHandoverList, + in template (value) TargetToSource_TransparentContainer p_TargetToSource_TransparentContainer ) := { procedureCode := id_HandoverPreparation, criticality := reject, @@ -3965,6 +3966,11 @@ id := id_PDUSessionResourceHandoverList, criticality := ignore, value_ := { PDUSessionResourceHandoverList := p_pDUSessionResourceHandoverList } + }, + { + id := id_TargetToSource_TransparentContainer, + criticality := reject, + value_ := { TargetToSource_TransparentContainer := p_TargetToSource_TransparentContainer } } } } @@ -3982,7 +3988,8 @@ template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, template (present) HandoverType p_handoverType := ?, - template (present) PDUSessionResourceHandoverList p_pDUSessionResourceHandoverList := ? + template (present) PDUSessionResourceHandoverList p_pDUSessionResourceHandoverList := ?, + template (present) TargetToSource_TransparentContainer p_TargetToSource_TransparentContainer := ? ) := { procedureCode := id_HandoverPreparation, criticality := reject, @@ -4008,6 +4015,11 @@ id := id_PDUSessionResourceHandoverList, criticality := ignore, value_ := { PDUSessionResourceHandoverList := p_pDUSessionResourceHandoverList } + }, + { + id := id_TargetToSource_TransparentContainer, + criticality := reject, + value_ := { TargetToSource_TransparentContainer := p_TargetToSource_TransparentContainer } } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I59be738e8143ca1b9fee91c1bb377970e741efc5 Gerrit-Change-Number: 42320 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong id in HandoverReq template IE
by pespin 11 Mar '26

11 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42314?usp=email ) Change subject: NGAP_Templates: Fix wrong id in HandoverReq template IE ...................................................................... NGAP_Templates: Fix wrong id in HandoverReq template IE Change-Id: I160a319543c32187bc4f2f3f4cf0baa667758f79 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index e36245d..465f577 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -4151,7 +4151,7 @@ value_ := { SecurityContext := p_securityContext } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, @@ -4246,7 +4246,7 @@ value_ := { SecurityContext := p_securityContext } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, @@ -4427,7 +4427,7 @@ value_ := { SecurityContext := p_securityContext } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, @@ -4542,7 +4542,7 @@ value_ := { NAS_PDU := p_nAS_PDU } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I160a319543c32187bc4f2f3f4cf0baa667758f79 Gerrit-Change-Number: 42314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE no...
by pespin 11 Mar '26

11 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42313?usp=email ) Change subject: NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE not appended ...................................................................... NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE not appended Change-Id: I40cff63f3d662fa168b57abe4ef95f347ab74435 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 6626cc1..e36245d 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -3852,6 +3852,11 @@ id := id_PDUSessionResourceListHORqd, criticality := reject, value_ := { PDUSessionResourceListHORqd := p_pDUSessionResourceListHORqd } + }, + { + id := id_SourceToTarget_TransparentContainer, + criticality := reject, + value_ := { SourceToTarget_TransparentContainer := p_SourceToTarget_TransparentContainer } } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cff63f3d662fa168b57abe4ef95f347ab74435 Gerrit-Change-Number: 42313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Expect optional IEs in HandoverRequest templates
by pespin 11 Mar '26

11 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42315?usp=email ) Change subject: NGAP_Templates: Expect optional IEs in HandoverRequest templates ...................................................................... NGAP_Templates: Expect optional IEs in HandoverRequest templates Change-Id: I227d67a589127ccfc5f44950daa3c0d95e425437 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 465f577..e5752ce 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -4426,6 +4426,7 @@ criticality := reject, value_ := { SecurityContext := p_securityContext } }, + *, { id := id_PDUSessionResourceSetupListHOReq, criticality := reject, @@ -4436,11 +4437,13 @@ criticality := reject, value_ := { AllowedNSSAI := p_allowedNSSAI } }, + *, { id := id_SourceToTarget_TransparentContainer, criticality := reject, value_ := { SourceToTarget_TransparentContainer := p_SourceToTarget_TransparentContainer } }, + *, { id := id_GUAMI, criticality := reject, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I227d67a589127ccfc5f44950daa3c0d95e425437 Gerrit-Change-Number: 42315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to...
by pespin 11 Mar '26

11 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42316?usp=email ) Change subject: NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverRequestAcknowledge ...................................................................... NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverRequestAcknowledge Change-Id: I19b0b718021326a64fe3bf1b3508a769a453557d --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index e5752ce..46e55bf 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -4733,7 +4733,8 @@ template (value) SuccessfulOutcome m_n2_HandoverRequestAcknowledge( in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, - in template (value) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList + in template (value) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList, + in template (value) TargetToSource_TransparentContainer p_TargetToSource_TransparentContainer ) := { procedureCode := id_HandoverResourceAllocation, criticality := reject, @@ -4754,6 +4755,11 @@ id := id_PDUSessionResourceAdmittedList, criticality := ignore, value_ := { PDUSessionResourceAdmittedList := p_pDUSessionResourceAdmittedList } + }, + { + id := id_TargetToSource_TransparentContainer, + criticality := reject, + value_ := { TargetToSource_TransparentContainer := p_TargetToSource_TransparentContainer } } } } @@ -4770,7 +4776,8 @@ template (present) SuccessfulOutcome mw_n2_HandoverRequestAcknowledge( template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList := ? + template (present) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList := ?, + template (present) TargetToSource_TransparentContainer p_TargetToSource_TransparentContainer := ? ) := { procedureCode := id_HandoverResourceAllocation, criticality := reject, @@ -4791,6 +4798,11 @@ id := id_PDUSessionResourceAdmittedList, criticality := ignore, value_ := { PDUSessionResourceAdmittedList := p_pDUSessionResourceAdmittedList } + }, + { + id := id_TargetToSource_TransparentContainer, + criticality := reject, + value_ := { TargetToSource_TransparentContainer := p_TargetToSource_TransparentContainer } } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42316?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19b0b718021326a64fe3bf1b3508a769a453557d Gerrit-Change-Number: 42316 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: main: rework panic handler
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42163?usp=email ) Change subject: main: rework panic handler ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: don't reset in the handler, either let it get stuck as before + let the WDT reset it or manually force a immediate wdt reset, because that is a different reset cause than a nvic reset which looks like any other system self reset so it can't be distinguished at the next boot. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I91c732001e848ec5509bf81af8aac1a2a80eb718 Gerrit-Change-Number: 42163 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Mar 2026 11:39:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: irq: make default IRQ handler Dummy_Handler weak
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: irq: make default IRQ handler Dummy_Handler weak ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: you're modifying asf4 code anyway, what's the point having a weak-weak alias chain instead of just replacing the dummy handler and removing the old function from startup_same54.c? This is the one and only firmware, not mysterious code with other users of the dummy handler that might or might not override it... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Mar 2026 11:33:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: build: add --disable-multi-arfcn configure option
by Timur Davydov 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith, pespin. Hello Hoernchen, Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: build: add --disable-multi-arfcn configure option ...................................................................... build: add --disable-multi-arfcn configure option - add configure flag to disable Multi ARFCN support - compile Channelizer, Synthesis, RadioInterfaceMulti and fft.c only when enabled - guard Multi ARFCN-specific code with ENABLE_MULTI_ARFCN - avoid requiring fftw3f when Multi ARFCN support is disabled Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c --- M Transceiver52M/Makefile.am M Transceiver52M/arch/common/Makefile.am M Transceiver52M/osmo-trx.cpp M Transceiver52M/radioBuffer.h M Transceiver52M/radioInterface.h M Transceiver52M/radioInterfaceMulti.cpp A Transceiver52M/radioInterfaceMulti.h M configure.ac 8 files changed, 98 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/43/42243/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 8 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by Timur Davydov 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, laforge, tnt. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email ) Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... Patch Set 6: (1 comment) File Transceiver52M/sigProcLib.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42248/comment/25330fc6_690c8228?usp… : PS5, Line 706: unsigned modulateBits(uint8_t *bits, unsigned bitlen, int16_t *outbuf) > a read-only input paramter "bits" should be marked as "const" Good catch — I've marked `bits` as const. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 11 Mar 2026 11:10:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-trx[master]: build: add --disable-multi-arfcn configure option
by Timur Davydov 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: add --disable-multi-arfcn configure option ...................................................................... Patch Set 7: (3 comments) File Transceiver52M/arch/common/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/fb9e9c46_e48ef71f?usp… : PS6, Line 9: mult.h > fyi, you can usually do this to avoid touching too many lines with each patch: […] Thanks for the tip — I've applied that in the current patch. File Transceiver52M/radioInterface.h: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/4a95ccbd_699461d1?usp… : PS6, Line 165: #ifdef ENABLE_MULTI_ARFCN > What about splitting this subclass into a separate header instead in a previous commit? Good point — I've moved the subclass into a separate header. I also added include guards in `radioInterface.h` and `radioBuffer.h` I didn't use `#pragma once`, since the codebase mostly uses traditional `#ifndef`/`#define` guards. File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/223f009a_e94ccf0c?usp… : PS6, Line 308: AC_DEFINE([ENABLE_MULTI_ARFCN],[1],[Building with enabled Multi ARFCN]) > Please indent these 2 lines. Thanks, fixed the indentation. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Mar 2026 11:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026