Attention is currently required from: laforge, lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42321?usp=email )
Change subject: dfu: flash: protect parsing of rc of flashing
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
To be honest I am losing track of what is going on here. you capture dfu_state to a local last_dfu_state because.. no idea, you want you local copy, but then.. nothing except a switch case and now we need another critical section.. ok.. well ok then, critical sections it is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42321?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: Ifc0d56d779ec31382855d6c367478104bc04e1e7
Gerrit-Change-Number: 42321
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 12 Mar 2026 19:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42322?usp=email )
Change subject: dfu: download: make variables between IRQ and main loop volatile
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
This belongs to the previous umerged patch that has just introduced the variables in the first place..
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42322?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: Ic3dccd77eff7feb164f9f07047680eef3f7c2516
Gerrit-Change-Number: 42322
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 12 Mar 2026 18:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332?usp=email )
Change subject: 5gc: Introduce tests for emergency services
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332/comment/ebc3fc65_3d0f… :
PS1, Line 625: 11
From the comment above it looks like you expect '00'B?
File 5gc/expected-results.xml:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332/comment/df7e3558_7933… :
PS1, Line 27: DTE
Why DTE? Can you make the testcases set a more meaningful verdict?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie853b184da7ac8026bb0c360baabba762a7942e0
Gerrit-Change-Number: 42332
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Mar 2026 17:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42329?usp=email )
Change subject: 5gc: parametrize RequestType in f_pdu_sess_establish()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42329?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I69d6be5e581565720a21c719b0f982eb31ec2adf
Gerrit-Change-Number: 42329
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Mar 2026 17:37:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42333?usp=email )
Change subject: library/ngap: do not link against libfftranscode
......................................................................
library/ngap: do not link against libfftranscode
TITAN has built-in ASN.1 PER codec since version 10.0.0.
We're already using it for NGAP, so libfftranscode is no longer needed.
Change-Id: I7ea63993278a5e0ca22fc4217c2c3c5f8f9dc0a6
Related: OS#6490
---
M library/ngap/regen_makefile.sh
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/42333/1
diff --git a/library/ngap/regen_makefile.sh b/library/ngap/regen_makefile.sh
index d630ab9..6a607bf 100755
--- a/library/ngap/regen_makefile.sh
+++ b/library/ngap/regen_makefile.sh
@@ -3,7 +3,3 @@
FILES="*.asn *.ttcn NGAP_EncDec.cc"
../../_buildsystem/regen-makefile.sh $FILES
-
-sed -i -e '/^CPPFLAGS/ s/$/ `pkg-config --cflags libfftranscode`/' Makefile
-sed -i -e '/^LDFLAGS/ s/$/ `pkg-config --libs libfftranscode`/' Makefile
-sed -i -e '/^LINUX_LIBS/ s/$/ `pkg-config --libs libfftranscode`/' Makefile
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42333?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7ea63993278a5e0ca22fc4217c2c3c5f8f9dc0a6
Gerrit-Change-Number: 42333
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>