March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim-read: remove import random
by laforge 31 Mar '26

31 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42557?usp=email ) Change subject: pySim-read: remove import random ...................................................................... pySim-read: remove import random In pySim-read we do not have to compute any random numbers, so we may remove random from the imports Change-Id: Iae4ee6aafb339cc682345299b92b4ecd0bbca14e --- M pySim-read.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-read.py b/pySim-read.py index 481e9da..6fc36a8 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -25,7 +25,6 @@ import hashlib import argparse import os -import random import re import sys -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iae4ee6aafb339cc682345299b92b4ecd0bbca14e Gerrit-Change-Number: 42557 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-read: remove import random
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42557?usp=email ) Change subject: pySim-read: remove import random ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iae4ee6aafb339cc682345299b92b4ecd0bbca14e Gerrit-Change-Number: 42557 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 10:29:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: sigtran_sap.h: Document spec specifying xUA<->LM primitive
by laforge 31 Mar '26

31 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42560?usp=email ) Change subject: sigtran_sap.h: Document spec specifying xUA<->LM primitive ...................................................................... sigtran_sap.h: Document spec specifying xUA<->LM primitive Change-Id: I14c3092a3feac5661d03b9b9114889b348b11bb1 --- M include/osmocom/sigtran/sigtran_sap.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/sigtran/sigtran_sap.h b/include/osmocom/sigtran/sigtran_sap.h index 610c711..f0e623d 100644 --- a/include/osmocom/sigtran/sigtran_sap.h +++ b/include/osmocom/sigtran/sigtran_sap.h @@ -10,6 +10,7 @@ MTP_SAP_USER, }; +/* RFC4666 1.6.3 (M3UA), RFC3868 1.6.3 (SUA) */ enum osmo_xlm_prim_type { OSMO_XLM_PRIM_M_SCTP_ESTABLISH, OSMO_XLM_PRIM_M_SCTP_RELEASE, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I14c3092a3feac5661d03b9b9114889b348b11bb1 Gerrit-Change-Number: 42560 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: sigtran_sap.h: Document spec specifying xUA<->LM primitive
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42560?usp=email ) Change subject: sigtran_sap.h: Document spec specifying xUA<->LM primitive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I14c3092a3feac5661d03b9b9114889b348b11bb1 Gerrit-Change-Number: 42560 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 10:27:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: sigtran_sap.h: Document spec specifying xUA<->LM primitive
by pespin 31 Mar '26

31 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42560?usp=email ) Change subject: sigtran_sap.h: Document spec specifying xUA<->LM primitive ...................................................................... sigtran_sap.h: Document spec specifying xUA<->LM primitive Change-Id: I14c3092a3feac5661d03b9b9114889b348b11bb1 --- M include/osmocom/sigtran/sigtran_sap.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/42560/1 diff --git a/include/osmocom/sigtran/sigtran_sap.h b/include/osmocom/sigtran/sigtran_sap.h index 610c711..f0e623d 100644 --- a/include/osmocom/sigtran/sigtran_sap.h +++ b/include/osmocom/sigtran/sigtran_sap.h @@ -10,6 +10,7 @@ MTP_SAP_USER, }; +/* RFC4666 1.6.3 (M3UA), RFC3868 1.6.3 (SUA) */ enum osmo_xlm_prim_type { OSMO_XLM_PRIM_M_SCTP_ESTABLISH, OSMO_XLM_PRIM_M_SCTP_RELEASE, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I14c3092a3feac5661d03b9b9114889b348b11bb1 Gerrit-Change-Number: 42560 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: docs/conf.py: add autodoc_mock_imports for klein and twisted
by osmith 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42546?usp=email ) Change subject: docs/conf.py: add autodoc_mock_imports for klein and twisted ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71650466f02a6a6d150650deed167c05d2cb6e64 Gerrit-Change-Number: 42546 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 10:08:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: docs/conf.py: silence autosectionlabel duplicate-label warnings
by osmith 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42543?usp=email ) Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/42543/comment/83ddc73f_177ae83d?usp=em… : PS2, Line 12: trigger large numbers of autosectionlabel duplicate-label warnings. listing which exact warnings this patch fixes would be more useful than summarizing them File docs/conf.py: https://gerrit.osmocom.org/c/pysim/+/42543/comment/58ec306b_f95fad3e?usp=em… : PS2, Line 77: # use-case. Instead of this verbose (llm generated?) comment block I suggest: ``` # Workaround for duplicate label warnings: # https://github.com/sphinx-doc/sphinx-argparse/issues/14 ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 Gerrit-Change-Number: 42543 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 10:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_after_act
by pespin 31 Mar '26

31 Mar '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: stp: m3ua: Introduce test TC_adm_block_after_act ...................................................................... stp: m3ua: Introduce test TC_adm_block_after_act Related: libosmo-sigtran.git Change-Id If8e34cfb05b8b63173b8bb01a520c058daf1fe39 Related: OS#6752 Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 --- M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/42550/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 Gerrit-Change-Number: 42550 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_as_fsm: Remove FIXME regarding queueing of msgs during state PENDING
by pespin 31 Mar '26

31 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42558?usp=email ) Change subject: xua_as_fsm: Remove FIXME regarding queueing of msgs during state PENDING ...................................................................... xua_as_fsm: Remove FIXME regarding queueing of msgs during state PENDING Queueing of messags during T(r) (state PENDING) is already implemented, see xua_as_fsm_pending() further below in the same file. Change-Id: Ie572367493066039f7022250d94b815a4da5bd16 --- M src/xua_as_fsm.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/58/42558/1 diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 6828989..568834e 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -585,8 +585,6 @@ osmo_fsm_inst_state_chg(fi, XUA_AS_S_PENDING, 0, 0); /* Start T(r) */ osmo_timer_schedule(&xafp->recovery.t_r, MSEC_TO_S_US(recovery_msec)); - /* FIXME: Queue all signalling messages until - * recovery or T(r) expiry */ } break; case XUA_ASPAS_ASP_INACTIVE_IND: @@ -596,8 +594,6 @@ osmo_fsm_inst_state_chg(fi, XUA_AS_S_PENDING, 0, 0); /* Start T(r) */ osmo_timer_schedule(&xafp->recovery.t_r, MSEC_TO_S_US(recovery_msec)); - /* FIXME: Queue all signalling messages until - * recovery or T(r) expiry */ } else if (inact_ind_pars->asp_requires_notify) { fill_notify_statchg_pars(fi, &npar); tx_notify(inact_ind_pars->asp, &npar); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie572367493066039f7022250d94b815a4da5bd16 Gerrit-Change-Number: 42558 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua asp block: SG: turn asp inactive when administratively blocked
by pespin 31 Mar '26

31 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42559?usp=email ) Change subject: xua asp block: SG: turn asp inactive when administratively blocked ...................................................................... xua asp block: SG: turn asp inactive when administratively blocked This commit intentionally leaves aside implementing active->inactive transition for asps with role ASP/(active) IPSP. Change-Id: If8e34cfb05b8b63173b8bb01a520c058daf1fe39 --- M src/ss7_asp.c M src/xua_asp_fsm.c M src/xua_asp_fsm.h 3 files changed, 48 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/59/42559/1 diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 96e8759..23a9b66 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -1540,6 +1540,9 @@ asp->cfg.adm_state.blocked ? "" : "no ", blocked ? "" : "no "); asp->cfg.adm_state.blocked = blocked; + + if (asp->cfg.adm_state.blocked) + osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_ADM_BLOCKED, NULL); } /* Apply sane configs for unconfigured options and restart the ASP. */ diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 7ee3fd1..e9d682a 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -74,6 +74,7 @@ { XUA_ASP_E_ASPSM_BEAT_ACK, "ASPSM_BEAT_ACK" }, { XUA_ASP_E_AS_ASSIGNED, "AS_ASSIGNED" }, + { XUA_ASP_E_ADM_BLOCKED, "ADM_BLOCKED" }, { IPA_ASP_E_ID_RESP, "IPA_CCM_ID_RESP" }, { IPA_ASP_E_ID_GET, "IPA_CCM_ID_GET" }, @@ -212,6 +213,24 @@ return cnt; } +static int xua_asp_tx_unsolicited_aspia_ack(struct osmo_ss7_asp *asp) +{ + struct msgb *msg; + struct xua_msg *xua = xua_msg_alloc(); + + OSMO_ASSERT(xua); + + xua->hdr = XUA_HDR(SUA_MSGC_ASPTM, SUA_ASPTM_INACTIVE_ACK); + xua_msg_add_asp_rctx(xua, asp); + + msg = xua_to_msg(SUA_VERSION, xua); + xua_msg_free(xua); + if (!msg) + return -1; + + return osmo_ss7_asp_send(asp, msg); +} + /* ask the xUA implementation to transmit a specific message */ static int peer_send(struct osmo_fsm_inst *fi, int out_event, struct xua_msg *in) { @@ -893,6 +912,7 @@ static void xua_asp_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct xua_asp_fsm_priv *xafp = fi->priv; + struct osmo_ss7_asp *asp = xafp->asp; struct xua_msg *xua; switch (event) { @@ -914,6 +934,26 @@ case XUA_ASP_E_AS_ASSIGNED: /* Ignore, only used in IPA asps so far. */ break; + case XUA_ASP_E_ADM_BLOCKED: + if (fi->state != XUA_ASP_S_ACTIVE) { + /* nothing to be done, ASPAC will be rejected when received. */ + return; + } + if (asp->cfg.role == OSMO_SS7_ASP_ROLE_SG) { + /* RFC4666 4.3.4.4: Transmit unsolicited ASPIA ACK no tnotify peer. + * "If the ASP receives an ASP Inactive Ack without having sent an + * ASP Inactive message, the ASP should now consider itself to be + * in the ASP-INACTIVE state. If the ASP was previously in the + * ASP-ACTIVE state, the ASP should then initiate procedures to + * return itself to its previous state." + */ + xua_asp_tx_unsolicited_aspia_ack(asp); + /* transition state and inform layer manager */ + osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0); + send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_INACTIVE, PRIM_OP_INDICATION); + } + /* TODO: implement ASP and IPSP roles. */ + break; default: break; } @@ -999,7 +1039,8 @@ S(XUA_ASP_E_SCTP_RESTART_IND) | S(XUA_ASP_E_ASPSM_BEAT) | S(XUA_ASP_E_ASPSM_BEAT_ACK) | - S(XUA_ASP_E_AS_ASSIGNED), + S(XUA_ASP_E_AS_ASSIGNED) | + S(XUA_ASP_E_ADM_BLOCKED), .allstate_action = xua_asp_allstate, .cleanup = xua_asp_fsm_cleanup, }; diff --git a/src/xua_asp_fsm.h b/src/xua_asp_fsm.h index 61a43a1..52d5f4b 100644 --- a/src/xua_asp_fsm.h +++ b/src/xua_asp_fsm.h @@ -31,6 +31,9 @@ /* The ASP was added to an AS. data: (struct osmo_ss7_as *) */ XUA_ASP_E_AS_ASSIGNED, + /* The ASP became administratively blocked */ + XUA_ASP_E_ADM_BLOCKED, + /* IPA specific */ IPA_ASP_E_ID_RESP, IPA_ASP_E_ID_ACK, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If8e34cfb05b8b63173b8bb01a520c058daf1fe39 Gerrit-Change-Number: 42559 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026