Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/42455?usp=email )
Change subject: cups_client: SPlit Tx of json str into its own function
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42455?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I505bf2eeea998a749e55f8f3b05c5013b5761297
Gerrit-Change-Number: 42455
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Mar 2026 09:40:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42459?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: GTPv1U_Emulation: Support IPv6 SLAAC with osmo-uecups
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
I actually need to update the deps/makefile commit hash iirc.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42459?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic368383ea65161297e57a298a12c7b4adc927142
Gerrit-Change-Number: 42459
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 09:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460?usp=email )
Change subject: 5gc: Introduce tests TC_ng_register_ping6(_256)
......................................................................
Patch Set 2:
(2 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460/comment/396f9b8d_1de3… :
PS2, Line 436: f_ping4
shouldn't this be ping6?
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460/comment/fa9386f5_6dc2… :
PS2, Line 1327: //user_addr := g_pars.ue_pars.sess_pars.ipv6_interface_id;
do you want to keep this commented out line?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iedf3697265b91bdda85e8d32402345ea8d58dc9f
Gerrit-Change-Number: 42460
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Mar 2026 07:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, laforge, osmith.
Hoernchen has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email )
Change subject: Revert "clang-format: set ColumnLimit: 0"
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335/comment/a50a270c_4f… :
PS1, Line 11: Reason for revert: we don't want clang-format to actively generate arbitrarily long line lengths.
> I see now that this comes from https://gerrit.osmocom. […]
Well we can either have a coding style, see the other proposed formatting patch chain, or we can decide not to have a coding style because every other line has a different lenght for no reason. As the other patchset shows if someone really really wants manually indented and formatted fsm stuff or usb descriptor arrays wrapping that with clang format on/off works just fine.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I49111af334e6967a9c3a63ccb9d179df444d63bb
Gerrit-Change-Number: 42335
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 21 Mar 2026 15:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email )
Change subject: irq: make default IRQ handler Dummy_Handler weak
......................................................................
Patch Set 2: Code-Review-2
(1 comment)
Patchset:
PS2:
I disagree strongly because I do not want a funky error prone chain of redirected symbols pointing to a now weak symbol, we are not writing libraries or frameworks, we are writing emebdded software, and the last thing I need are weak symbols with linker "oopsie woopesies" because due tue some other mishap the weak symbol was silently used and not overridden by something else and no one noticed anything. We want a handler, so either we have a handler, or a compile failure, and not schroedingers mystery firmware that compiles no matter what and that might or might not contain the function we are looking for. I can very well remember a funny parameter that allowed the simtrace firmware to build with missing symbols, that was really not fun to debug at the time because at runtime it called 0.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465
Gerrit-Change-Number: 42224
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 21 Mar 2026 15:50:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes