March 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: docs/conf.py: silence autosectionlabel duplicate-label warnings
by fixeria 31 Mar '26

31 Mar '26

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42543?usp=email ) Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/42543/comment/9d55b450_26a1e057?usp=em… : PS2, Line 12: trigger large numbers of autosectionlabel duplicate-label warnings. > listing which exact warnings this patch fixes would be more useful than summarizing them There's quite a lot of them, see https://jenkins.osmocom.org/jenkins/view/master/job/master-pysim/2075/JOB_T… (grep for `WARNING: duplicate label`). I don't think we really want them in the commit message? File docs/conf.py: https://gerrit.osmocom.org/c/pysim/+/42543/comment/1bd4d127_7284717a?usp=em… : PS2, Line 77: # use-case. > Instead of this verbose (llm generated?) comment block I suggest: […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 Gerrit-Change-Number: 42543 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Mar 2026 12:17:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: docs/conf.py: silence autosectionlabel duplicate-label warnings
by fixeria 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings ...................................................................... docs/conf.py: silence autosectionlabel duplicate-label warnings sphinxarg.ext generates generic sub-headings ("Named arguments", "Positional arguments", "Sub-commands", "General options", ...) for every argparse command and tool. These repeat across many files and trigger large numbers of autosectionlabel duplicate-label warnings. Two-pronged fix: * `autosectionlabel_maxdepth = 3` eliminates the depth-4+ warnings (sub-headings inside each individual command block). * `suppress_warnings` per file silences the residual depth-3 collisions ("serial reader", "decode_hex", "sub-commands", ...) that still appear across tool documentation files. Cross-references into these generic argparse-generated sections are not a supported use-case, so suppressing the warnings is appropriate. Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 --- M docs/conf.py 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/42543/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 Gerrit-Change-Number: 42543 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: docs/conf.py: add autodoc_mock_imports for klein and twisted
by fixeria 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42546?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: docs/conf.py: add autodoc_mock_imports for klein and twisted ...................................................................... docs/conf.py: add autodoc_mock_imports for klein and twisted The eSIM SM-DP+ server modules (`pySim.esim.es2p`, `pySim.esim.es9p`, `pySim.esim.http_json_api`) unconditionally import optional server-side dependencies at module level: pySim.esim.es2p -- from klein import Klein pySim.esim.http_json_api -- from twisted.web.server import Request Both imports fail during a docs build if the packages are absent or broken, causing three "autodoc: failed to import" warnings and three missing chapters in the generated manual. Even when klein and twisted are installed, twisted 23.10.0 (the version pulled in transitively by smpp.twisted3's `Twisted~=23.10.0` constraint) is incompatible with Python 3.13+ because twisted.web.http unconditionally executes `import cgi`, a module that was removed from the standard library in Python 3.13. Fix: add `autodoc_mock_imports = ['klein', 'twisted']` to conf.py. Sphinx inserts mock entries into sys.modules before each autodoc import attempt, so the modules can be imported and documented without requiring the real packages to be importable at build time. Change-Id: I71650466f02a6a6d150650deed167c05d2cb6e64 --- M docs/conf.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/46/42546/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71650466f02a6a6d150650deed167c05d2cb6e64 Gerrit-Change-Number: 42546 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in pysim[master]: docs: auto-generate Card Filesystem Reference
by fixeria 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: docs: auto-generate Card Filesystem Reference ...................................................................... docs: auto-generate Card Filesystem Reference Add a Sphinx extension (docs/pysim_fs_sphinx.py) that hooks into the builder-inited event and generates docs/filesystem.rst before Sphinx reads any source files. The generated page contains a hierarchical listing of all implemented EFs and DFs, organised by application/specification (UICC/TS 102 221, ADF.USIM/TS 31.102, ADF.ISIM/TS 31.103, SIM/TS 51.011). For each file, the class docstring and any _test_de_encode / _test_decode vectors are included as an encoding/decoding example table. docs/filesystem.rst is fully generated at build time and is therefore added to .gitignore. Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Related: OS#6316 --- M .gitignore M docs/conf.py M docs/index.rst A docs/pysim_fs_sphinx.py 4 files changed, 249 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/51/42551/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06ddeefc6c11e04d7c24e116f3f39c8a6635856f Gerrit-Change-Number: 42551 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: docs/conf.py: silence autosectionlabel duplicate-label warnings
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42543?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 Gerrit-Change-Number: 42543 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 11:30:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: docs/conf.py: silence autosectionlabel duplicate-label warnings
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42543?usp=email ) Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 Gerrit-Change-Number: 42543 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 11:30:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: docs/conf.py: add autodoc_mock_imports for klein and twisted
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42546?usp=email ) Change subject: docs/conf.py: add autodoc_mock_imports for klein and twisted ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71650466f02a6a6d150650deed167c05d2cb6e64 Gerrit-Change-Number: 42546 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 11:30:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: PySimLogger: add parameter to set initial log-level/verbosity
by laforge 31 Mar '26

31 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42304?usp=email ) Change subject: PySimLogger: add parameter to set initial log-level/verbosity ...................................................................... PySimLogger: add parameter to set initial log-level/verbosity When we initialize a new PySimLogger, we always call the setup method first and then use the set_verbose and set_level method to configure the initial log level and the initial log verbosity. However, we initialize the PySimLogger in all our programs the same way and we end up with the same boilerplate code every time. Let's add a keyword parameter to the setup method where we can pass our opts.verbose (bool) parameter so that the setup method can do the work for the main program. In case the caller wants a different default configuration he still can call set_verbose and set_level methods as needed. Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 --- M contrib/csv-to-pgsql.py M pySim-shell.py M pySim/log.py 3 files changed, 14 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/csv-to-pgsql.py b/contrib/csv-to-pgsql.py index 416d870..a805ab8 100755 --- a/contrib/csv-to-pgsql.py +++ b/contrib/csv-to-pgsql.py @@ -285,10 +285,7 @@ option_parser.add_argument("--admin", action='store_true', help="perform action as admin", default=False) opts = option_parser.parse_args() - PySimLogger.setup(print, {logging.WARN: "\033[33m"}) - if (opts.verbose): - PySimLogger.set_verbose(True) - PySimLogger.set_level(logging.DEBUG) + PySimLogger.setup(print, {logging.WARN: "\033[33m"}, opts.verbose) # Open CSV file cr = open_csv(opts) diff --git a/pySim-shell.py b/pySim-shell.py index 2bfc720..98c31d8 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -107,12 +107,12 @@ kwargs = {'include_ipy': True} self.verbose = verbose + PySimLogger.setup(self.poutput, {logging.WARN: YELLOW}) self._onchange_verbose('verbose', False, self.verbose); # pylint: disable=unexpected-keyword-arg super().__init__(persistent_history_file='~/.pysim_shell_history', allow_cli_args=False, auto_load_commands=False, startup_script=script, **kwargs) - PySimLogger.setup(self.poutput, {logging.WARN: YELLOW}) self.intro = style(self.BANNER, fg=RED) self.default_category = 'pySim-shell built-in commands' self.card = None @@ -1176,13 +1176,7 @@ opts = option_parser.parse_args() # Ensure that we are able to print formatted warnings from the beginning. - PySimLogger.setup(print, {logging.WARN: YELLOW}) - if opts.verbose: - PySimLogger.set_verbose(True) - PySimLogger.set_level(logging.DEBUG) - else: - PySimLogger.set_verbose(False) - PySimLogger.set_level(logging.INFO) + PySimLogger.setup(print, {logging.WARN: YELLOW}, opts.verbose) # Register csv-file as card data provider, either from specified CSV # or from CSV file in home directory diff --git a/pySim/log.py b/pySim/log.py index 85397b6..801ad69 100644 --- a/pySim/log.py +++ b/pySim/log.py @@ -63,7 +63,7 @@ raise RuntimeError('static class, do not instantiate') @staticmethod - def setup(print_callback = None, colors:dict = {}): + def setup(print_callback = None, colors:dict = {}, verbose_debug:bool = False): """ Set a print callback function and color scheme. This function call is optional. In case this method is not called, default settings apply. @@ -72,10 +72,20 @@ have the following format: print_callback(message:str) colors : An optional dict through which certain log levels can be assigned a color. (e.g. {logging.WARN: YELLOW}) + verbose_debug: Enable verbose logging and set the loglevel DEBUG when set to true. Otherwise the + non-verbose logging is used and the loglevel is set to INFO. This setting can be changed + using the set_verbose and set_level methods at any time. """ PySimLogger.print_callback = print_callback PySimLogger.colors = colors + if (verbose_debug): + PySimLogger.set_verbose(True) + PySimLogger.set_level(logging.DEBUG) + else: + PySimLogger.set_verbose(False) + PySimLogger.set_level(logging.INFO) + @staticmethod def set_verbose(verbose:bool = False): """ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 Gerrit-Change-Number: 42304 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
by laforge 31 Mar '26

31 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42305?usp=email ) Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument ...................................................................... pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument pySim-prog and pySim-read do not integrate the pySimLogger yet. As we may add more debug output that should not be visible on normal use, we should ensure that the pySimLogger is correctly set up. Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 --- M pySim-prog.py M pySim-read.py M tests/pySim-prog_test/Fairwaves-SIM.ok M tests/pySim-prog_test/Wavemobile-SIM.ok M tests/pySim-prog_test/fakemagicsim.ok M tests/pySim-prog_test/sysmoISIM-SJA2.ok M tests/pySim-prog_test/sysmoISIM-SJA5.ok M tests/pySim-prog_test/sysmoUSIM-SJS1.ok M tests/pySim-prog_test/sysmosim-gr1.ok 9 files changed, 26 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-prog.py b/pySim-prog.py index 760a650..3f2bb94 100755 --- a/pySim-prog.py +++ b/pySim-prog.py @@ -44,6 +44,11 @@ from pySim.card_handler import * from pySim.utils import * +from pathlib import Path +import logging +from pySim.log import PySimLogger + +log = PySimLogger.get(Path(__file__).stem) def parse_options(): @@ -185,6 +190,7 @@ default=False, action="store_true") parser.add_argument("--card_handler", dest="card_handler_config", metavar="FILE", help="Use automatic card handling machine") + parser.add_argument("--verbose", help="Enable verbose logging", action='store_true', default=False) options = parser.parse_args() @@ -770,6 +776,9 @@ # Parse options opts = parse_options() + # Setup logger + PySimLogger.setup(print, {logging.WARN: "\033[33m"}, opts.verbose) + # Init card reader driver sl = init_reader(opts) diff --git a/pySim-read.py b/pySim-read.py index 6fc36a8..6984991 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -45,11 +45,17 @@ from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn from pySim.ts_51_011 import EF_SMSP +from pathlib import Path +import logging +from pySim.log import PySimLogger + +log = PySimLogger.get(Path(__file__).stem) + option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) +option_parser.add_argument("--verbose", help="Enable verbose logging", action='store_true', default=False) argparse_add_reader_args(option_parser) - def select_app(adf: str, card: SimCard): """Select application by its AID""" sw = 0 @@ -74,6 +80,9 @@ # Parse options opts = option_parser.parse_args() + # Setup logger + PySimLogger.setup(print, {logging.WARN: "\033[33m"}, opts.verbose) + # Init card reader driver sl = init_reader(opts) diff --git a/tests/pySim-prog_test/Fairwaves-SIM.ok b/tests/pySim-prog_test/Fairwaves-SIM.ok index 303e8ae..42e92e8 100644 --- a/tests/pySim-prog_test/Fairwaves-SIM.ok +++ b/tests/pySim-prog_test/Fairwaves-SIM.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: Fairwaves-SIM ICCID: 8988219000000117833 diff --git a/tests/pySim-prog_test/Wavemobile-SIM.ok b/tests/pySim-prog_test/Wavemobile-SIM.ok index 3c1e62d..86f4830 100644 --- a/tests/pySim-prog_test/Wavemobile-SIM.ok +++ b/tests/pySim-prog_test/Wavemobile-SIM.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: Wavemobile-SIM ICCID: 89445310150011013678 diff --git a/tests/pySim-prog_test/fakemagicsim.ok b/tests/pySim-prog_test/fakemagicsim.ok index 306cef9..45ff082 100644 --- a/tests/pySim-prog_test/fakemagicsim.ok +++ b/tests/pySim-prog_test/fakemagicsim.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: fakemagicsim ICCID: 1122334455667788990 diff --git a/tests/pySim-prog_test/sysmoISIM-SJA2.ok b/tests/pySim-prog_test/sysmoISIM-SJA2.ok index 5e2b45f..b0d4a77 100644 --- a/tests/pySim-prog_test/sysmoISIM-SJA2.ok +++ b/tests/pySim-prog_test/sysmoISIM-SJA2.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: sysmoISIM-SJA2 ICCID: 8988211000000467343 diff --git a/tests/pySim-prog_test/sysmoISIM-SJA5.ok b/tests/pySim-prog_test/sysmoISIM-SJA5.ok index b6d7862..374ad0a 100644 --- a/tests/pySim-prog_test/sysmoISIM-SJA5.ok +++ b/tests/pySim-prog_test/sysmoISIM-SJA5.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: sysmoISIM-SJA5 ICCID: 8949440000001155314 diff --git a/tests/pySim-prog_test/sysmoUSIM-SJS1.ok b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok index c669353..fe2aa03 100644 --- a/tests/pySim-prog_test/sysmoUSIM-SJS1.ok +++ b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: sysmoUSIM-SJS1 ICCID: 8988211320300000028 diff --git a/tests/pySim-prog_test/sysmosim-gr1.ok b/tests/pySim-prog_test/sysmosim-gr1.ok index 3d926e2..e77b8ee 100644 --- a/tests/pySim-prog_test/sysmosim-gr1.ok +++ b/tests/pySim-prog_test/sysmosim-gr1.ok @@ -1,4 +1,4 @@ -Using PC/SC reader interface +INFO: Using PC/SC reader interface Reading ... Autodetected card type: sysmosim-gr1 ICCID: 2222334455667788990 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 Gerrit-Change-Number: 42305 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-shell/cosmetic: remove semicolon
by laforge 31 Mar '26

31 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42311?usp=email ) Change subject: pySim-shell/cosmetic: remove semicolon ...................................................................... pySim-shell/cosmetic: remove semicolon Change-Id: I629bacd432491211b939fcd2bed554b44ef441bc --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim-shell.py b/pySim-shell.py index 98c31d8..29ed3a5 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -108,7 +108,7 @@ self.verbose = verbose PySimLogger.setup(self.poutput, {logging.WARN: YELLOW}) - self._onchange_verbose('verbose', False, self.verbose); + self._onchange_verbose('verbose', False, self.verbose) # pylint: disable=unexpected-keyword-arg super().__init__(persistent_history_file='~/.pysim_shell_history', allow_cli_args=False, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I629bacd432491211b939fcd2bed554b44ef441bc Gerrit-Change-Number: 42311 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026