March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: global_platform: fix s/GET/STORE/ DATA in docs
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42376?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: global_platform: fix s/GET/STORE/ DATA in docs ...................................................................... global_platform: fix s/GET/STORE/ DATA in docs Both `do_store_data` and `store_data` have identical docstrings that incorrectly describe the command as GET DATA. Should be "STORE DATA". Take a chance to fix missing space between `v2.3` and `Section`. Change-Id: I33fc80ab8ca50fadc38217b0005eec6169c8e34e --- M pySim/global_platform/__init__.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 8ed645c..810387b 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -562,14 +562,14 @@ @cmd2.with_argparser(store_data_parser) def do_store_data(self, opts): - """Perform the GlobalPlatform GET DATA command in order to store some card-specific data. - See GlobalPlatform CardSpecification v2.3Section 11.11 for details.""" + """Perform the GlobalPlatform STORE DATA command in order to store some card-specific data. + See GlobalPlatform CardSpecification v2.3 Section 11.11 for details.""" response_permitted = opts.response == 'may_be_returned' self.store_data(h2b(opts.DATA), opts.data_structure, opts.encryption, response_permitted) def store_data(self, data: bytes, structure:str = 'none', encryption:str = 'none', response_permitted: bool = False) -> bytes: - """Perform the GlobalPlatform GET DATA command in order to store some card-specific data. - See GlobalPlatform CardSpecification v2.3Section 11.11 for details.""" + """Perform the GlobalPlatform STORE DATA command in order to store some card-specific data. + See GlobalPlatform CardSpecification v2.3 Section 11.11 for details.""" max_cmd_len = self._cmd.lchan.scc.max_cmd_len # Table 11-89 of GP Card Specification v2.3 remainder = data -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42376?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I33fc80ab8ca50fadc38217b0005eec6169c8e34e Gerrit-Change-Number: 42376 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: global_platform: fix store_data() returning last chunk only
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42375?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: global_platform: fix store_data() returning last chunk only ...................................................................... global_platform: fix store_data() returning last chunk only The loop builds up `response` across multiple STORE DATA blocks, but the function returns only `data` - the response from the *last* block. It should return the accumulated response instead. Change-Id: I3e15c8004d1e366e8c3896e559656622f48bb1a2 --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 6ebaa7b..8ed645c 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -585,7 +585,7 @@ data, _sw = self._cmd.lchan.scc.send_apdu_checksw(hdr + b2h(chunk) + "00") block_nr += 1 response += data - return data + return h2b(response) put_key_parser = argparse.ArgumentParser() put_key_parser.add_argument('--old-key-version-nr', type=auto_uint8, default=0, help='Old Key Version Number') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e15c8004d1e366e8c3896e559656622f48bb1a2 Gerrit-Change-Number: 42375 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: global_platform: fix typo in ApplicationTemplate
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42374?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: global_platform: fix typo in ApplicationTemplate ...................................................................... global_platform: fix typo in ApplicationTemplate The keyword argument should be `nested=`. As written `ApplicationAID` is silently ignored - `ApplicationTemplate` will not descend into its nested TLVs. Change-Id: If45dbb0c9b09fe53560d109957ce339267a9f2b0 --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 7afdbf9..6ebaa7b 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -319,7 +319,7 @@ # GlobalPlatform v2.3.1 Section 11.3.3.1.3 class ApplicationAID(BER_TLV_IE, tag=0x4f): _construct = GreedyBytes -class ApplicationTemplate(BER_TLV_IE, tag=0x61, ntested=[ApplicationAID]): +class ApplicationTemplate(BER_TLV_IE, tag=0x61, nested=[ApplicationAID]): pass class ListOfApplications(BER_TLV_IE, tag=0x2f00, nested=[ApplicationTemplate]): pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If45dbb0c9b09fe53560d109957ce339267a9f2b0 Gerrit-Change-Number: 42374 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: global_platform: fix typo in SupportedTlsCipherSuitesForScp81
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42373?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: global_platform: fix typo in SupportedTlsCipherSuitesForScp81 ...................................................................... global_platform: fix typo in SupportedTlsCipherSuitesForScp81 The attribute name is misspelled. The BER-TLV infrastructure looks for `_construct`; this typo means `SupportedTlsCipherSuitesForScp81` will never decode its content. Change-Id: I0f637951b0eeb7eca2a8b543baa737f216a935ed --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 8a99677..7afdbf9 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -276,7 +276,7 @@ class SupportedKeysForScp03(BER_TLV_IE, tag=0x82): _construct = FlagsEnum(Byte, aes128=0x01, aes192=0x02, aes256=0x04) class SupportedTlsCipherSuitesForScp81(BER_TLV_IE, tag=0x83): - _consuruct = GreedyRange(Int16ub) + _construct = GreedyRange(Int16ub) class ScpInformation(BER_TLV_IE, tag=0xa0, nested=[ScpType, ListOfSupportedOptions, SupportedKeysForScp03, SupportedTlsCipherSuitesForScp81]): pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0f637951b0eeb7eca2a8b543baa737f216a935ed Gerrit-Change-Number: 42373 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: Revert "clang-format: set ColumnLimit: 0"
by laforge 21 Mar '26

21 Mar '26

Attention is currently required from: Hoernchen, fixeria, osmith. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email ) Change subject: Revert "clang-format: set ColumnLimit: 0" ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335/comment/3122322a_c0… : PS1, Line 11: Reason for revert: we don't want clang-format to actively generate arbitrarily long line lengths. > I see now that this comes from https://gerrit.osmocom. […] so, what can we do here to make clang-format do what we want? @ewild@sysmocom.de ? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I49111af334e6967a9c3a63ccb9d179df444d63bb Gerrit-Change-Number: 42335 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Mar 2026 21:36:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: esim/saip: raise an exception properly
by laforge 21 Mar '26

21 Mar '26

Attention is currently required from: dexter, fixeria. laforge has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42389?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: esim/saip: raise an exception properly ...................................................................... esim/saip: raise an exception properly Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/89/42389/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b Gerrit-Change-Number: 42389 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: cdma_ruim: fix inaccurate comment for EF_AD
by laforge 21 Mar '26

21 Mar '26

Attention is currently required from: dexter, fixeria. laforge has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42388?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cdma_ruim: fix inaccurate comment for EF_AD ...................................................................... cdma_ruim: fix inaccurate comment for EF_AD Change-Id: I71ea27fd30e44685ff35f49843072ca392995973 --- M pySim/cdma_ruim.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/42388/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71ea27fd30e44685ff35f49843072ca392995973 Gerrit-Change-Number: 42388 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name
by laforge 21 Mar '26

21 Mar '26

Attention is currently required from: fixeria. laforge has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42387?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name ...................................................................... ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name Change-Id: I460e5ad70f35026d0d794271a4aef17323c14dfb --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/42387/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I460e5ad70f35026d0d794271a4aef17323c14dfb Gerrit-Change-Number: 42387 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ts_31_102: fix description for EF_5GS3GPPLOCI
by laforge 21 Mar '26

21 Mar '26

Attention is currently required from: fixeria. laforge has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42386?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ts_31_102: fix description for EF_5GS3GPPLOCI ...................................................................... ts_31_102: fix description for EF_5GS3GPPLOCI Change-Id: I9cf3adfce65090fedb3f0fd33c9b3d15a2c5fb8c --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/42386/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cf3adfce65090fedb3f0fd33c9b3d15a2c5fb8c Gerrit-Change-Number: 42386 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ts_51_011: EF.EXT[6-7]: fix typo in desc
by laforge 21 Mar '26

21 Mar '26

Attention is currently required from: fixeria. laforge has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42385?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ts_51_011: EF.EXT[6-7]: fix typo in desc ...................................................................... ts_51_011: EF.EXT[6-7]: fix typo in desc Change-Id: I93df1c9fd8a4d588ed7ed19ec2dc1d304412fc3d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/42385/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93df1c9fd8a4d588ed7ed19ec2dc1d304412fc3d Gerrit-Change-Number: 42385 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026