March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim-read: remove import random
by dexter 31 Mar '26

31 Mar '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42557?usp=email ) Change subject: pySim-read: remove import random ...................................................................... pySim-read: remove import random In pySim-read we do not have to compute any random numbers, so we may remove random from the imports Change-Id: Iae4ee6aafb339cc682345299b92b4ecd0bbca14e --- M pySim-read.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/57/42557/1 diff --git a/pySim-read.py b/pySim-read.py index 481e9da..6fc36a8 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -25,7 +25,6 @@ import hashlib import argparse import os -import random import re import sys -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iae4ee6aafb339cc682345299b92b4ecd0bbca14e Gerrit-Change-Number: 42557 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: tlv: Allow control over comprehension bit in COMPR_TLV_IE
by daniel 31 Mar '26

31 Mar '26

Attention is currently required from: laforge, laforge. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email ) Change subject: tlv: Allow control over comprehension bit in COMPR_TLV_IE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I looked at that, but the tag is a property of the (sub-)class and used in the metaclass: […] I could also change the meta class __new__ to accept the {tag, comprehension} style and use that internally, but then we still need a way to control the comprehension bit in the constructor of the class. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I9ca689b9b51152f3907ea470c7b42a0b12208459 Gerrit-Change-Number: 42556 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)gnumonks.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)gnumonks.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Mar 2026 09:04:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: tlv: Allow control over comprehension bit in COMPR_TLV_IE
by daniel 31 Mar '26

31 Mar '26

Attention is currently required from: laforge, laforge. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email ) Change subject: tlv: Allow control over comprehension bit in COMPR_TLV_IE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The function already supports a {tag, comprehension} input syntax for the 'tag' argument. […] I looked at that, but the tag is a property of the (sub-)class and used in the metaclass: ``` python # TS 102 223 Section 8.35 class CApdu(COMPR_TLV_IE, tag=0xA2): _construct = GreedyBytes ``` The metaclass (ComprTlvMeta) constructor __new__ assumes that tag is an int. The constructor of the actual subclass (e.g. CApdu) does not do anything with a tag variable - even if you passed it. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I9ca689b9b51152f3907ea470c7b42a0b12208459 Gerrit-Change-Number: 42556 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)gnumonks.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)gnumonks.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Mar 2026 08:56:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: asp_vty: Fix wrong vty write 'blocked' command
by pespin 31 Mar '26

31 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42527?usp=email ) Change subject: asp_vty: Fix wrong vty write 'blocked' command ...................................................................... asp_vty: Fix wrong vty write 'blocked' command This is not criticial since "block"/"no block" commands are yet to be fully implemented. Change-Id: Ia42a064cfdbba025bc3ae5479e8e6edec4abe770 --- M src/ss7_asp_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index 6b03275..f13cb60 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -1411,7 +1411,7 @@ vty_out(vty, " shutdown%s", VTY_NEWLINE); break; case OSMO_SS7_ASP_ADM_S_BLOCKED: - vty_out(vty, " blocked%s", VTY_NEWLINE); + vty_out(vty, " block%s", VTY_NEWLINE); break; case OSMO_SS7_ASP_ADM_S_ENABLED: /* Default, no need to print: */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42527?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia42a064cfdbba025bc3ae5479e8e6edec4abe770 Gerrit-Change-Number: 42527 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: tlv: Allow control over comprehension bit in COMPR_TLV_IE
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: daniel, laforge. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email ) Change subject: tlv: Allow control over comprehension bit in COMPR_TLV_IE ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: The function already supports a {tag, comprehension} input syntax for the 'tag' argument. That's why there is the 'isinstance/int' check. If you specify the raw tag, where the upper bit determines the comprehension status. If you provide the dict as input, it should doexactly what you want? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I9ca689b9b51152f3907ea470c7b42a0b12208459 Gerrit-Change-Number: 42556 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)gnumonks.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)gnumonks.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 08:33:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: tlv: Remove unused branch
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: daniel. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/42555?usp=email ) Change subject: tlv: Remove unused branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/42555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ia6a0656721a1fcaf5f16526fefe62c30b0ddb664 Gerrit-Change-Number: 42555 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 08:31:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: firmware: werror on missing return
by laforge 31 Mar '26

31 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42545?usp=email ) Change subject: firmware: werror on missing return ...................................................................... firmware: werror on missing return Silently ignoring a missing return just broke all timers, so prevent similar mistakes in the future. Change-Id: I2e25884077af6334c9e9ddace3900b04061fae04 --- M sysmoOCTSIM/gcc/Makefile 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index 461b313..445324e 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -11,7 +11,10 @@ CFLAGS_CPU=-D__SAME54N19A__ -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 CFLAGS=-x c -mthumb -DDEBUG -Os -ffunction-sections -fdata-sections -mlong-calls \ - -fno-omit-frame-pointer -ggdb3 -Wall -c -std=gnu99 $(CFLAGS_CPU) -DOCTSIMFWBUILD -DDISABLE_DFU_DETACH=$(DISABLE_DFU_DETACH) -Wno-discarded-qualifiers -Werror=strict-prototypes -fno-common -Wno-unused-variable -Wno-unused-function -Wlarger-than=512 -Wstack-usage=255 + -fno-omit-frame-pointer -ggdb3 -Wall -c -std=gnu99 $(CFLAGS_CPU) -DOCTSIMFWBUILD \ + -DDISABLE_DFU_DETACH=$(DISABLE_DFU_DETACH) -Wno-discarded-qualifiers -Werror=strict-prototypes \ + -fno-common -Wno-unused-variable -Wno-unused-function -Wlarger-than=512 -Wstack-usage=255 \ + -Werror=return-type CFLAGS += -DLIBOSMOCORE_NO_LOGGING -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2e25884077af6334c9e9ddace3900b04061fae04 Gerrit-Change-Number: 42545 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: firmware: werror on missing return
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42545?usp=email ) Change subject: firmware: werror on missing return ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2e25884077af6334c9e9ddace3900b04061fae04 Gerrit-Change-Number: 42545 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 08:29:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_after_act
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email ) Change subject: stp: m3ua: Introduce test TC_adm_block_after_act ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18672d228c1d15ef99039bccbb972e0b2496b545 Gerrit-Change-Number: 42550 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 08:29:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_adm_block_act_err
by laforge 31 Mar '26

31 Mar '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42548?usp=email ) Change subject: stp: m3ua: Introduce test TC_adm_block_act_err ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9869ec2b71a3f6814340e181d67bab4c9266a2f4 Gerrit-Change-Number: 42548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Mar 2026 08:28:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026