lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" fea...
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email ) Change subject: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" feature ...................................................................... Patch Set 2: (3 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/7a26d48f_8319… : PS1, Line 467: private function f_tcap_loadshare_register_new_trans( > I don't get it. Having a function "f_tcap_loadshare_register_new_trans(nteger node_, integer tid_start, integer tid_stop, boolean accept_new_trans)" and calling it twice for A and B would make this a lot cleaner... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/94162887_bb84… : PS1, Line 1074: testcase TC_tcap_loadshare_ipa_tcap_new_trans_register() runs on TCAP_CT { > Yes, this is a part of another tests. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/711826c2_c7d7… : PS1, Line 1109: var integer dtid := ((rand_tid + i) mod 99); > Because the dtid should be in the range of `asp-ipa-loadshare-0-0`. […] This actually relates to the other discussion a couple lines before. Since you are willing to test it for the other ASP then it needs modification. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948e95e66bdafadf01020e9e97ac50a04b78ec50 Gerrit-Change-Number: 44005 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: remove outdated counter tcap:asp:failed
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086?usp=email ) Change subject: tcap_as_loadshare: remove outdated counter tcap:asp:failed ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086/comment/7066d4df_4d2b0… : PS1, Line 737: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); This change looks unrelated? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I390cc5b0bd4500ed8f1d674fb13ac5dced5f7c9b Gerrit-Change-Number: 44086 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:25:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: fix cosmetic whitespace
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44085?usp=email ) Change subject: tcap_as_loadshare: fix cosmetic whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie1e374de0ccdb5c34c89b5c962b3da89e118fb8a Gerrit-Change-Number: 44085 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:24:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: add rate counter for TCAP tcap:session:hit
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44082?usp=email ) Change subject: tcap_as_loadshare: add rate counter for TCAP tcap:session:hit ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: dialog -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I10c3ae05c36bef3f3ae91713ed7332a5e66bb04b Gerrit-Change-Number: 44082 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: fix description of tcap:session:miss
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44081?usp=email ) Change subject: tcap_as_loadshare: fix description of tcap:session:miss ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You can simply squash this one in previous commit? You are adding the line there right? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I193585a7d192df4d0d672578ee09db6655fa9d17 Gerrit-Change-Number: 44081 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: rename rate counter for TCAP session miss
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44080?usp=email ) Change subject: tcap_as_loadshare: rename rate counter for TCAP session miss ...................................................................... Patch Set 1: (2 comments) File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44080/comment/42e56d95_4a1bc… : PS1, Line 74: SS7_AS_CTR_TCAP_SESS_MISS, I think the correct concept naming in TCAP is "dialog", not "session"? File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44080/comment/605819be_fcaee… : PS1, Line 147: [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry, but routed successful. (loadshare-tcap)" }, s/session/dialog/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1e5e908f092976c98e906ec935c2428123b55fa5 Gerrit-Change-Number: 44080 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: also increase rate counter for TCAP message from a...
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44079?usp=email ) Change subject: tcap_as_loadshare: also increase rate counter for TCAP message from an TCAP loadsharing ASP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I04e44797d14d36ed1b1bbd770ba2d7592959a040 Gerrit-Change-Number: 44079 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:18:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: rename rate counters for TCAP decoding
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44078?usp=email ) Change subject: tcap_as_loadshare: rename rate counters for TCAP decoding ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If7218400ef3353c5f28845b390b354390f2e3b73 Gerrit-Change-Number: 44078 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: close the ASP connection when receiving an invalid...
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44076?usp=email ) Change subject: tcap_as_loadshare: close the ASP connection when receiving an invalid message ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure we really want to close the entire IPA multiplex conn in this case tbh, I'd rather simply return a NACK or simply drop the packet and log an error... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iae3d2ebce2e984db497794297696af36ca7f010b Gerrit-Change-Number: 44076 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:16:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 4: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/ad9e9e8c_03ec3… : PS2, Line 985: goto out; > that we need to fix it for all branches which uses `goto out`. Ok, do you mind submitting an extra patch fixing it? File src/tcap_as_loadshare_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/23aac4c5_689e5… : PS3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp)) > The other I found, was using Yes and No. […] Then if there's can't be an inactive ASP, why doing the call to "!osmo_ss7_asp_active(assoc->asp)" ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 27
  • 28
  • 29
  • 30
  • 31
  • 32
  • 33
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.