lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: rename rate counter for successful load sharing
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44083?usp=email ) Change subject: tcap_as_loadshare: rename rate counter for successful load sharing ...................................................................... tcap_as_loadshare: rename rate counter for successful load sharing To prepare for a counter when load sharing fails for a TCAP Begin message. Related: SYS#8283 Change-Id: I6a0dc75e945a7a9688386e9bcd842bf7e9bc1d1e --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/83/44083/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index 3a9352e..8b71359 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -141,7 +141,7 @@ #ifdef WITH_TCAP_LOADSHARING [SS7_AS_CTR_TCAP_DECODE_SUCCESS] = { "tcap:decode:success", "Number of successful decoded TCAP messages (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_DECODE_FAILURE] = { "tcap:decode:failure", "Number of TCAP messages which could not decoded (loadshare-tcap)" }, - [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS] = {"tcap:loadshare:success","Successful ASP selection for a TCAP Begin message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" }, diff --git a/src/ss7_as.h b/src/ss7_as.h index d9301a0..4e6b671 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -68,7 +68,7 @@ #ifdef WITH_TCAP_LOADSHARING SS7_AS_CTR_TCAP_DECODE_SUCCESS, SS7_AS_CTR_TCAP_DECODE_FAILURE, - SS7_AS_CTR_TCAP_ASP_SELECTED, + SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS, SS7_AS_CTR_TCAP_ASP_FALLBACK, SS7_AS_CTR_TCAP_ASP_FAILED, SS7_AS_CTR_TCAP_SESS_MISS, diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index ca4cd6d..15512a6 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -661,7 +661,7 @@ * is allowed (e.g., round robin)." */ asp = select_asp_tcap_enabled_rr(as); if (asp) { - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_SELECTED); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS); } else { /* Couldn't find a suitable canditate */ LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a suitable canditate for TCAP Begin otid %u\n", parsed.otid); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6a0dc75e945a7a9688386e9bcd842bf7e9bc1d1e Gerrit-Change-Number: 44083 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: fix description of tcap:session:miss
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44081?usp=email ) Change subject: tcap_as_loadshare: fix description of tcap:session:miss ...................................................................... tcap_as_loadshare: fix description of tcap:session:miss It is unclear if the message got routed even after missing the tcap sesion tracking. Related: SYS#8283 Change-Id: I193585a7d192df4d0d672578ee09db6655fa9d17 --- M src/ss7_as.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/81/44081/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index e3319fb..6721c24 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -144,7 +144,7 @@ [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, - [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry, but routed successful. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I193585a7d192df4d0d672578ee09db6655fa9d17 Gerrit-Change-Number: 44081 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: rename rate counter for TCAP session miss
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44080?usp=email ) Change subject: tcap_as_loadshare: rename rate counter for TCAP session miss ...................................................................... tcap_as_loadshare: rename rate counter for TCAP session miss Prefix the rate counter to prepare for a hit counter. Related: SYS#8283 Change-Id: I1e5e908f092976c98e906ec935c2428123b55fa5 --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/80/44080/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index 41ae807..e3319fb 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -144,7 +144,7 @@ [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, - [SS7_AS_CTR_TCAP_ASP_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry, but routed successful. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry, but routed successful. (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ }; diff --git a/src/ss7_as.h b/src/ss7_as.h index b713ca4..804b59d 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -71,7 +71,7 @@ SS7_AS_CTR_TCAP_ASP_SELECTED, SS7_AS_CTR_TCAP_ASP_FALLBACK, SS7_AS_CTR_TCAP_ASP_FAILED, - SS7_AS_CTR_TCAP_ASP_MISS, + SS7_AS_CTR_TCAP_SESS_MISS, #endif /* WITH_TCAP_LOADSHARING */ }; diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 026f0f3..ea9545e 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -684,7 +684,7 @@ asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); if (!asp) { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP Continue, dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_SESS_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); if (!asp) { /* Couldn't find a matching TCAP endpoint for an ongoing session */ @@ -716,7 +716,7 @@ asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); if (!asp) { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route\n", parsed.dtid); - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_SESS_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); if (!asp) { /* Couldn't find a matching TCAP endpoint for an ongoing session */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1e5e908f092976c98e906ec935c2428123b55fa5 Gerrit-Change-Number: 44080 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: add rate counter for TCAP tcap:session:hit
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44082?usp=email ) Change subject: tcap_as_loadshare: add rate counter for TCAP tcap:session:hit ...................................................................... tcap_as_loadshare: add rate counter for TCAP tcap:session:hit When a TCAP message could be routed by the tcap session tracking. Related: SYS#8283 Change-Id: I10c3ae05c36bef3f3ae91713ed7332a5e66bb04b --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/82/44082/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index 6721c24..3a9352e 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -145,6 +145,7 @@ [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_SESS_HIT] = { "tcap:session:hit", "A non-starting TCAP message (Continue, End, Abort) hit a session entry, (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ }; diff --git a/src/ss7_as.h b/src/ss7_as.h index 804b59d..d9301a0 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -72,6 +72,7 @@ SS7_AS_CTR_TCAP_ASP_FALLBACK, SS7_AS_CTR_TCAP_ASP_FAILED, SS7_AS_CTR_TCAP_SESS_MISS, + SS7_AS_CTR_TCAP_SESS_HIT, #endif /* WITH_TCAP_LOADSHARING */ }; diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index ea9545e..ca4cd6d 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -682,7 +682,9 @@ * "When a destination TID is present, the SG extracts the label and * selects the ASP that corresponds with it." */ asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); - if (!asp) { + if (asp) + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_SESS_HIT); + else { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP Continue, dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_SESS_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); @@ -714,7 +716,9 @@ } asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); - if (!asp) { + if (asp) + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_SESS_HIT); + else { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route\n", parsed.dtid); rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_SESS_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I10c3ae05c36bef3f3ae91713ed7332a5e66bb04b Gerrit-Change-Number: 44082 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: rename rate counters for TCAP decoding
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44078?usp=email ) Change subject: tcap_as_loadshare: rename rate counters for TCAP decoding ...................................................................... tcap_as_loadshare: rename rate counters for TCAP decoding Rename the define for successful/failed decoding. Related: SYS#8283 Change-Id: If7218400ef3353c5f28845b390b354390f2e3b73 --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/78/44078/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index 59e9e06..41ae807 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -139,8 +139,8 @@ [SS7_AS_CTR_TX_MSU_SLS_14] = { "tx:msu:sls:14", SS7_AS_CTR_TX_MSU_SLS_STR "14" }, [SS7_AS_CTR_TX_MSU_SLS_15] = { "tx:msu:sls:15", SS7_AS_CTR_TX_MSU_SLS_STR "15" }, #ifdef WITH_TCAP_LOADSHARING - [SS7_AS_CTR_RX_TCAP_DECODED] = { "tcap:decoded", "Number of TCAP-messages decoded successfully (loadshare-tcap)" }, - [SS7_AS_CTR_RX_TCAP_FAILED] = { "tcap:failed", "Number of TCAP-messages that failed decoding (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_DECODE_SUCCESS] = { "tcap:decode:success", "Number of successful decoded TCAP messages (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_DECODE_FAILURE] = { "tcap:decode:failure", "Number of TCAP messages which could not decoded (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, diff --git a/src/ss7_as.h b/src/ss7_as.h index 329350b..b713ca4 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -66,8 +66,8 @@ SS7_AS_CTR_TX_MSU_SLS_14, SS7_AS_CTR_TX_MSU_SLS_15, #ifdef WITH_TCAP_LOADSHARING - SS7_AS_CTR_RX_TCAP_DECODED, - SS7_AS_CTR_RX_TCAP_FAILED, + SS7_AS_CTR_TCAP_DECODE_SUCCESS, + SS7_AS_CTR_TCAP_DECODE_FAILURE, SS7_AS_CTR_TCAP_ASP_SELECTED, SS7_AS_CTR_TCAP_ASP_FALLBACK, SS7_AS_CTR_TCAP_ASP_FAILED, diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index d490319..61885a6 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -614,12 +614,12 @@ rc, parsed.present, parsed.otid, parsed.dtid); if (rc <= 0) { - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_TCAP_FAILED); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_DECODE_FAILURE); LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed parse TCAP message to retrieve otid/dtid.\n"); rc = -EINVAL; goto out_free_sua; } - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_TCAP_DECODED); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_DECODE_SUCCESS); /* Handle UDTS message */ if (sua->hdr.msg_type == SUA_CL_CLDR) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If7218400ef3353c5f28845b390b354390f2e3b73 Gerrit-Change-Number: 44078 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: also increase rate counter for TCAP message from a...
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44079?usp=email ) Change subject: tcap_as_loadshare: also increase rate counter for TCAP message from an TCAP loadsharing ASP ...................................................................... tcap_as_loadshare: also increase rate counter for TCAP message from an TCAP loadsharing ASP Before only messages towards an TCAP loadsharing ASP were counted. Also count when parsing a TCAP messages from a TCAP ASP. Related: SYS#8283 Change-Id: I04e44797d14d36ed1b1bbd770ba2d7592959a040 --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/79/44079/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 61885a6..026f0f3 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -350,10 +350,12 @@ rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_DECODE_FAILURE); rc = -7; goto out; } + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_DECODE_SUCCESS); LOGPAS(as, DLTCAP, LOGL_INFO, "Looking up transaction for type 0x%02x, otid=%u dtid=%u\n", parsed.present, parsed.otid, parsed.dtid); /* TCAP messages towards the IPAC nodes */ switch (parsed.present) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I04e44797d14d36ed1b1bbd770ba2d7592959a040 Gerrit-Change-Number: 44079 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: testenv: set default titan version to 11.2.1
by fixeria 13 Nov '26

13 Nov '26
Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44071?usp=email ) Change subject: testenv: set default titan version to 11.2.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04145bd975b464301f41fa020e6082d1feb67b61 Gerrit-Change-Number: 44071 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Nov 2026 21:24:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_TCAP: add TC_tcap_loadshare_ipa_tcap_tx_invalid_close
by lynxis 13 Nov '26

13 Nov '26
Attention is currently required from: pespin. Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44077?usp=email to look at the new patch set (#2). Change subject: stp: STP_Tests_TCAP: add TC_tcap_loadshare_ipa_tcap_tx_invalid_close ...................................................................... stp: STP_Tests_TCAP: add TC_tcap_loadshare_ipa_tcap_tx_invalid_close Test if an invalid IPA TCAP routing packet closes the connection. Depends-on: Iae3d2ebce2e984db497794297696af36ca7f010b (libosmo-sigtran) Related: SYS#8286 Change-Id: I93380962905b720343e14a9a5277baa4680b5713 --- M library/IPA_EXT_TCAP_ROUTING.ttcn M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_TCAP.ttcn 3 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/44077/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93380962905b720343e14a9a5277baa4680b5713 Gerrit-Change-Number: 44077 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: stp: add TC_tcap_loadshare_ipa_tcap_tx_invalid_close
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44077?usp=email ) Change subject: stp: add TC_tcap_loadshare_ipa_tcap_tx_invalid_close ...................................................................... stp: add TC_tcap_loadshare_ipa_tcap_tx_invalid_close Test if an invalid packet closes the connection. Depends-on: Iae3d2ebce2e984db497794297696af36ca7f010b (libosmo-sigtran) Related: SYS#8286 Change-Id: I93380962905b720343e14a9a5277baa4680b5713 --- M library/IPA_EXT_TCAP_ROUTING.ttcn M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_TCAP.ttcn 3 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/44077/1 diff --git a/library/IPA_EXT_TCAP_ROUTING.ttcn b/library/IPA_EXT_TCAP_ROUTING.ttcn index 1779830..1d0d5d8 100644 --- a/library/IPA_EXT_TCAP_ROUTING.ttcn +++ b/library/IPA_EXT_TCAP_ROUTING.ttcn @@ -84,6 +84,15 @@ tr_IPA_EXT_TCAP_ROUTING_NACK := tr_IPA_EXT_TCAP_ROUTING_Message(IPA_EXT_TCAP_ROUTING_MSG_TID_NACK); template (value) IPA_EXT_TCAP_ROUTING_Message +ts_IPA_EXT_TCAP_ACK(template (value) uint32_t seq_nr) := { + msg_type := IPA_EXT_TCAP_ROUTING_MSG_TID_ACK, + seq_nr := seq_nr, + u := { + ack := {} + } +} + +template (value) IPA_EXT_TCAP_ROUTING_Message ts_IPA_EXT_TCAP_ROUTING_ADD_RANGE(template (value) uint32_t seq_nr, template (value) uint32_t tid_start, template (value) uint32_t tid_end, diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index b16cb0e..0c21e81 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -11,6 +11,7 @@ */ friend module STP_Tests_IPA_M3UA; +friend module STP_Tests_IPA_TCAP; import from General_Types all; import from Osmocom_Types all; diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index c57e650..a28188f 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -66,6 +66,7 @@ type component TCAP_CT extends Test_CT { var SCCP_Adapter g_tcap[MAX_NUM_ASP]; port TCAP_CODEC_PT SCCP_TCAP[MAX_NUM_ASP]; + port IPA_SP_PT IPA_CTRL[MAX_NUM_ASP]; /* Port for IPA Extension TCAP_ROUTING */ port IPA_TCAP_ROUTING_PT IPA_TCAP_ROUTING[MAX_NUM_ASP]; @@ -98,6 +99,14 @@ return tcap_configs; } +private altstep as_IPA_wait_tcp_conn_closed(integer idx) runs on TCAP_CT { + var ASP_IPA_Event evt; + [] IPA_CTRL[idx].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) -> value evt { + log("Peer closed conn: ", evt) + } +} + + private function f_get_peer_pc_list() runs on TCAP_CT return Osmocom_Types.ro_integer { var Osmocom_Types.ro_integer peer_pc_list := {}; @@ -177,6 +186,7 @@ f_sccp_adapter_init(g_tcap[i], tcap_configs[i].cfg, "STP_TCAP_" & int2str(i)); connect(self:SCCP_TCAP[i], g_tcap[i].vc_SCCP:SCCP_SP_PORT); if (tcap_configs[i].cfg.transport == SCCP_TRANSPORT_SCCPlite) { + connect(self:IPA_CTRL[i], g_tcap[i].vc_IPA:IPA_SP_PORT); connect(self:IPA_TCAP_ROUTING[i], g_tcap[i].vc_IPA:IPA_TCAP_ROUTING_PORT); } } @@ -1085,6 +1095,23 @@ setverdict(pass); } +/* Test if transmitting an invalid PDU ( ACK) closes the connection */ +testcase TC_tcap_loadshare_ipa_tcap_tx_invalid_close() runs on TCAP_CT { + var Misc_Helpers.ro_charstring tcap_asps := { "asp-m3ua-loadshare-0-0", + "asp-m3ua-loadshare-0-1", + "asp-ipa-loadshare-0-0", + "asp-ipa-loadshare-0-1" }; + var TCAP_CT_Configurations tcap_configs := tcap_build_configs(tcap_asps); + + f_init_tcap(tcap_configs); + f_tcap_loadshare_register_new_trans(2, 0, 99, true, + 3, 100, 299, false); + + IPA_TCAP_ROUTING[3].send(ts_IPA_EXT_TCAP_ACK(3)); + as_IPA_wait_tcp_conn_closed(3); + setverdict(pass); +} + /* Register 2 TCAP loadsharing nodes. * asp-ipa-loadshare-0-0: 0 - 99, receiving new tcap transactions * asp-ipa-loadshare-0-1: 100 - 299, NOT receiving new tcap transactions @@ -1106,11 +1133,20 @@ var integer rand_tid := f_rnd_int(50); for (var integer i := 0; i < loops; i := i + 1) { var integer otid := rand_tid + i; + /* Select a DTID in the range of asp-ipa-loadshare-0-0: [0, 99] */ var integer dtid := ((rand_tid + i) mod 99); f_asp_tx_tcap_m3ua_ipa_transaction(0, 2, int2oct(otid, 4), int2oct(dtid, 4)); } + for (var integer i := loops; i < 2 * loops; i := i + 1) { + var integer otid := rand_tid + i; + /* Select a DTID in the range of asp-ipa-loadshare-0-1: [0, 99] */ + var integer dtid := ((rand_tid + i) mod 99); + + f_asp_tx_tcap_m3ua_ipa_transaction(1, 2, int2oct(otid, 4), int2oct(dtid, 4)); + } + setverdict(pass); } @@ -1216,6 +1252,7 @@ execute( TC_tcap_loadshare_ipa_tcap_new_trans_rx_loadshare() ); execute( TC_tcap_loadshare_ipa_tcap_new_trans_outgoing_transactions() ); execute( TC_tcap_loadshare_ipa_tcap_new_trans_no_ready() ); + execute( TC_tcap_loadshare_ipa_tcap_tx_invalid_close() ); execute( TC_tcap_loadshare_m3ua_to_ipa_udts() ); execute( TC_tcap_loadshare_m3ua_to_ipa_udts_routing() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93380962905b720343e14a9a5277baa4680b5713 Gerrit-Change-Number: 44077 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" fea...
by lynxis 13 Nov '26

13 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email ) Change subject: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" feature ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/4d6da16a_7527… : PS1, Line 1111: f_asp_tx_tcap_m3ua_ipa_transaction(0, 2, int2oct(otid, 4), int2oct(dtid, 4)); > Ok, but this test is only doing an incoming test Yes, you're right. I'll also test the other m3ua. I mixed it with the ipa ASP. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948e95e66bdafadf01020e9e97ac50a04b78ec50 Gerrit-Change-Number: 44005 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Nov 2026 20:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 30
  • 31
  • 32
  • 33
  • 34
  • 35
  • 36
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.