lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[M] Change in libosmocore[master]: libosmogsm: Use the subscriber's K length for TUAK AUTS
by Josh Shilts 15 Nov '26

15 Nov '26
Josh Shilts has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email ) Change subject: libosmogsm: Use the subscriber's K length for TUAK AUTS ...................................................................... libosmogsm: Use the subscriber's K length for TUAK AUTS tuak_gen_vec_auts() passed sizeof(aud->u.umts.k), which is always 32, as the K length, so resync failed for every subscriber with a 128-bit K. Add TUAK resync cases with a 128-bit and a 256-bit K to the osmo-auc-gen test. Fixes: OS#7119 Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 --- M src/gsm/auth_tuak.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M tests/osmo-auc-gen/osmo-auc-gen_test.sh 3 files changed, 51 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/44088/1 diff --git a/src/gsm/auth_tuak.c b/src/gsm/auth_tuak.c index 05fbf69..075d915 100644 --- a/src/gsm/auth_tuak.c +++ b/src/gsm/auth_tuak.c @@ -179,7 +179,7 @@ opc = gen_opc_if_needed(aud, gen_opc); - rc = tuak_auts(opc, aud->u.umts.k, sizeof(aud->u.umts.k), rand_auts, auts, sqn_out); + rc = tuak_auts(opc, aud->u.umts.k, aud->u.umts.k_len, rand_auts, auts, sqn_out); if (rc < 0) return rc; diff --git a/tests/osmo-auc-gen/osmo-auc-gen_test.ok b/tests/osmo-auc-gen/osmo-auc-gen_test.ok index 2da0b02..d18e57c 100644 --- a/tests/osmo-auc-gen/osmo-auc-gen_test.ok +++ b/tests/osmo-auc-gen/osmo-auc-gen_test.ok @@ -290,3 +290,39 @@ osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY + + +> osmo-auc-gen -3 -a tuak -r 42424242424242424242424242424242 -k abababababababababababababababab -O 5555555555555555555555555555555555555555555555555555555555555555 -A e7af6b3d0e2f4f669592ff7d647d +osmo-auc-gen (C) 2011-2023 by Harald Welte +This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY + +RAND: 42424242424242424242424242424242 +AUTN: aad217459a450000a629d0b8d090f68f +IK: 52c2ecdcb90878d9eaa7ae82add046c0 +CK: 144269a4bd882a02026ddbb13243404b +RES: 7abd06d3fff7f634 +IMS nonce: QkJCQkJCQkJCQkJCQkJCQqrSF0WaRQAApinQuNCQ9o8= +IMS res: er0G0//39jQ= +SRES: 854af0e7 +Kc: ae4af04b9b135450 +SQN: 32 +IND: 0 +SQN.MS: 23 + + +> osmo-auc-gen -3 -a tuak -r 0123456789abcdef0123456789abcdef -k fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e0 -O 808182838485868788898a8b8c8d8e8f909192939495969798999a9b9c9d9e9f -A f84eb338849bac1fbaf692a06dfb +osmo-auc-gen (C) 2011-2023 by Harald Welte +This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY + +RAND: 0123456789abcdef0123456789abcdef +AUTN: 480a9345cc3e00009a4cacea6268825e +IK: 2274155ccf4199d5e2abcbf621907f90 +CK: a4cb6f6529ab17f8337f27baa8234d47 +RES: e9d749dc4eea0035 +IMS nonce: ASNFZ4mrze8BI0VniavN70gKk0XMPgAAmkys6mJogl4= +IMS res: 6ddJ3E7qADU= +SRES: a73d49e9 +Kc: 576b96756f59bcfa +SQN: 32 +IND: 0 +SQN.MS: 23 diff --git a/tests/osmo-auc-gen/osmo-auc-gen_test.sh b/tests/osmo-auc-gen/osmo-auc-gen_test.sh index 55b0757..5a301f9 100755 --- a/tests/osmo-auc-gen/osmo-auc-gen_test.sh +++ b/tests/osmo-auc-gen/osmo-auc-gen_test.sh @@ -60,3 +60,17 @@ invoke_err -3 -a milenage -r $rand -k $k -o $opc -A $auts --ind 42 invoke_err -3 -a milenage -r $rand -k $k -o $opc -A $auts --ind-len 0 --ind 1 + +# TUAK resync with a 128-bit and a 256-bit K, using the K, TOP and RAND of +# 3GPP TS 35.233 test sets 1 and 2 +k="abababababababababababababababab" +op="5555555555555555555555555555555555555555555555555555555555555555" +rand="42424242424242424242424242424242" +auts="e7af6b3d0e2f4f669592ff7d647d" # --> SQN.MS = 23 +invoke -3 -a tuak -r $rand -k $k -O $op -A $auts + +k="fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e0" +op="808182838485868788898a8b8c8d8e8f909192939495969798999a9b9c9d9e9f" +rand="0123456789abcdef0123456789abcdef" +auts="f84eb338849bac1fbaf692a06dfb" # --> SQN.MS = 23 +invoke -3 -a tuak -r $rand -k $k -O $op -A $auts -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 Gerrit-Change-Number: 44088 Gerrit-PatchSet: 1 Gerrit-Owner: Josh Shilts <joshuashilts(a)gmail.com>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: improve fallback rate counters
by Jenkins Builder 14 Nov '26

14 Nov '26
Attention is currently required from: lynxis. Jenkins Builder has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email ) Change subject: tcap_as_loadshare: improve fallback rate counters ...................................................................... Patch Set 2: (2 comments) File src/ss7_as.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087/comment/c03a40e8_69534… : PS2, Line 148: [SS7_AS_CTR_TCAP_FALLBACK_UDTS] ={ "tcap:fallback:udts", "Successful fallback handling by sending a UDTS. (loadshare-tcap)" }, spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087/comment/ac590ec5_a8ce4… : PS2, Line 149: [SS7_AS_CTR_TCAP_FALLBACK_ROUTE] ={ "tcap:fallback:route", "Successful fallback handling by sending to the fallback rount. (loadshare-tcap)" }, spaces required around that '=' (ctx:WxV) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If471c2b53ce8ff423313cfb0b8bf3042cc194803 Gerrit-Change-Number: 44087 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 14 Nov 2026 00:12:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: improve fallback rate counters
by lynxis 14 Nov '26

14 Nov '26
Attention is currently required from: lynxis. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tcap_as_loadshare: improve fallback rate counters ...................................................................... tcap_as_loadshare: improve fallback rate counters Rename tcap:asp:fallback into tcap:fallback:handle. Add a seperate counter for every different fallback method. Related: SYS#8283 Change-Id: If471c2b53ce8ff423313cfb0b8bf3042cc194803 --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/87/44087/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If471c2b53ce8ff423313cfb0b8bf3042cc194803 Gerrit-Change-Number: 44087 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: rename rate counter for successful load sharing
by Jenkins Builder 13 Nov '26

13 Nov '26
Jenkins Builder has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44083?usp=email ) Change subject: tcap_as_loadshare: rename rate counter for successful load sharing ...................................................................... Patch Set 1: (1 comment) File src/ss7_as.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/44083/comment/446cb91d_20b83… : PS1, Line 144: [SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS] = {"tcap:loadshare:success","Successful ASP selection for a TCAP Begin message (loadshare-tcap)" }, space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6a0dc75e945a7a9688386e9bcd842bf7e9bc1d1e Gerrit-Change-Number: 44083 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 13 Nov 2026 22:38:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: add rate counter tcap:loadshare:failure
by Jenkins Builder 13 Nov '26

13 Nov '26
Jenkins Builder has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44084?usp=email ) Change subject: tcap_as_loadshare: add rate counter tcap:loadshare:failure ...................................................................... Patch Set 1: (1 comment) File src/ss7_as.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/44084/comment/f963e2de_79f83… : PS1, Line 145: [SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE] = {"tcap:loadshare:failure","Could not find a valid ASP for a TCAP Begin message (loadshare-tcap)" }, space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I04e63bf30742e5e584609337aab11177553b8033 Gerrit-Change-Number: 44084 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 13 Nov 2026 22:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: improve fallback rate counters
by Jenkins Builder 13 Nov '26

13 Nov '26
Jenkins Builder has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email ) Change subject: tcap_as_loadshare: improve fallback rate counters ...................................................................... Patch Set 1: (2 comments) File src/ss7_as.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087/comment/1420d6a5_3837d… : PS1, Line 148: [SS7_AS_CTR_TCAP_FALLBACK_UDTS] ={ "tcap:fallback:udts", "Successful fallback handling by sending a UDTS. (loadshare-tcap)" }, spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087/comment/0b3818b4_7d272… : PS1, Line 149: [SS7_AS_CTR_TCAP_FALLBACK_ROUTE] ={ "tcap:fallback:udts", "Successful fallback handling by sending to the fallback rount. (loadshare-tcap)" }, spaces required around that '=' (ctx:WxV) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If471c2b53ce8ff423313cfb0b8bf3042cc194803 Gerrit-Change-Number: 44087 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 13 Nov 2026 22:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: improve fallback rate counters
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email ) Change subject: tcap_as_loadshare: improve fallback rate counters ...................................................................... tcap_as_loadshare: improve fallback rate counters Rename tcap:asp:fallback into tcap:fallback:handle. Add a seperate counter for every different fallback method. Related: SYS#8283 Change-Id: If471c2b53ce8ff423313cfb0b8bf3042cc194803 --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/87/44087/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index d2b6081..6dc51d2 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -143,7 +143,10 @@ [SS7_AS_CTR_TCAP_DECODE_FAILURE] = { "tcap:decode:failure", "Number of TCAP messages which could not decoded (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS] = {"tcap:loadshare:success","Successful ASP selection for a TCAP Begin message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE] = {"tcap:loadshare:failure","Could not find a valid ASP for a TCAP Begin message (loadshare-tcap)" }, - [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_FALLBACK_HANDLE] = { "tcap:fallback:handle", "A non-starting TCAP message (Continue, End, Abort) had to be handled by the fallback. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_FALLBACK_ROUNDROBIN] = {"tcap:fallback:rr", "Successful fallback handling by TCAP load sharing. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_FALLBACK_UDTS] ={ "tcap:fallback:udts", "Successful fallback handling by sending a UDTS. (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_FALLBACK_ROUTE] ={ "tcap:fallback:udts", "Successful fallback handling by sending to the fallback rount. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_HIT] = { "tcap:session:hit", "A non-starting TCAP message (Continue, End, Abort) hit a session entry, (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ diff --git a/src/ss7_as.h b/src/ss7_as.h index 27c56e4..57727ab 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -70,7 +70,10 @@ SS7_AS_CTR_TCAP_DECODE_FAILURE, SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS, SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE, - SS7_AS_CTR_TCAP_ASP_FALLBACK, + SS7_AS_CTR_TCAP_FALLBACK_HANDLE, + SS7_AS_CTR_TCAP_FALLBACK_ROUNDROBIN, + SS7_AS_CTR_TCAP_FALLBACK_ROUTE, + SS7_AS_CTR_TCAP_FALLBACK_UDTS, SS7_AS_CTR_TCAP_SESS_MISS, SS7_AS_CTR_TCAP_SESS_HIT, #endif /* WITH_TCAP_LOADSHARING */ diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index bee3bfd..afd2a2d 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -507,6 +507,8 @@ OSMO_ASSERT(rasp); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_FALLBACK_HANDLE); + switch (as->cfg.loadshare.tcap.unroutable_tcap_msg) { case SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS: /* RFC3868 A.3.1 Connectionless Transport: @@ -519,8 +521,10 @@ * Hence, if UNROUTABLE_LOAD_SHARE_AS is configured, allocation * policy "State sharing" at the peer is assumed. */ asp = select_asp_tcap_enabled_rr(as); - if (asp) + if (asp) { + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_FALLBACK_ROUNDROBIN); rc = 0; + } break; case SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK: /* RFC3868 A.2: @@ -529,14 +533,21 @@ * in-sequence-delivery is requested. However, linkset failures * may cause MTP to reroute to the other SG." */ /* No ASP selection. Try to route the SCCP msg to the fallback DPC */ + rc = asp_loadshare_tcap_route_fallback(as, mtp3_rtlb, sccp_msg); - if (!rc) /* rc == 0 would require a valid asp, use > 0 to drop the msg, but don't send an error back if needed */ + if (!rc) { + /* asp_loadshare_tcap_route_fallback() returns 0 on success, but rc = 0 would + * require a valid asp. + * Use rc > 0, so asp_loadshare_tcap_sccp() will drop further handling and free the message. */ rc = 1; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_FALLBACK_ROUTE); + } break; case SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS: /* RFC3868 4.7.3.1 TCAP traffic: * "If an ASP is not available, the SG may generate (X)UDTS * "routing failure", if the return option is used." */ + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_FALLBACK_UDTS); /* fall-through */ default: /* default case, asp stays NULL, will reject when returning -ENOKEY */ @@ -699,8 +710,6 @@ rc = -ENOKEY; goto out_free_sua; } - - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); } tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); @@ -733,7 +742,6 @@ rc = -ENOKEY; goto out_free_sua; } - } /* Don't create an entry for an End */ } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If471c2b53ce8ff423313cfb0b8bf3042cc194803 Gerrit-Change-Number: 44087 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: fix cosmetic whitespace
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44085?usp=email ) Change subject: tcap_as_loadshare: fix cosmetic whitespace ...................................................................... tcap_as_loadshare: fix cosmetic whitespace Change-Id: Ie1e374de0ccdb5c34c89b5c962b3da89e118fb8a --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/85/44085/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 81fae90..4842c23 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -537,7 +537,7 @@ /* RFC3868 4.7.3.1 TCAP traffic: * "If an ASP is not available, the SG may generate (X)UDTS * "routing failure", if the return option is used." */ - /* fall-through */ + /* fall-through */ default: /* default case, asp stays NULL, will reject when returning -ENOKEY */ rc = -ENOKEY; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie1e374de0ccdb5c34c89b5c962b3da89e118fb8a Gerrit-Change-Number: 44085 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: remove outdated counter tcap:asp:failed
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086?usp=email ) Change subject: tcap_as_loadshare: remove outdated counter tcap:asp:failed ...................................................................... tcap_as_loadshare: remove outdated counter tcap:asp:failed The counter counted all cases when rejecting the TCAP message, but does not differentiate between the multiple failures. Related: SYS#8283 Change-Id: I390cc5b0bd4500ed8f1d674fb13ac5dced5f7c9b --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/44086/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index d000125..d2b6081 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -144,7 +144,6 @@ [SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS] = {"tcap:loadshare:success","Successful ASP selection for a TCAP Begin message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE] = {"tcap:loadshare:failure","Could not find a valid ASP for a TCAP Begin message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, - [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_HIT] = { "tcap:session:hit", "A non-starting TCAP message (Continue, End, Abort) hit a session entry, (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ diff --git a/src/ss7_as.h b/src/ss7_as.h index f869240..27c56e4 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -71,7 +71,6 @@ SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS, SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE, SS7_AS_CTR_TCAP_ASP_FALLBACK, - SS7_AS_CTR_TCAP_ASP_FAILED, SS7_AS_CTR_TCAP_SESS_MISS, SS7_AS_CTR_TCAP_SESS_HIT, #endif /* WITH_TCAP_LOADSHARING */ diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 4842c23..bee3bfd 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -734,7 +734,6 @@ goto out_free_sua; } - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); } /* Don't create an entry for an End */ } @@ -749,9 +748,6 @@ break; } out_free_sua: - if (rc == -ENOKEY) - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED); - /* RFC3868 4.7.3: "If an ASP is not available, the SG may generate (X)UDTS "routing failure", * if the return option is used." * See also ITU Q.714 4.2 */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I390cc5b0bd4500ed8f1d674fb13ac5dced5f7c9b Gerrit-Change-Number: 44086 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: add rate counter tcap:loadshare:failure
by lynxis 13 Nov '26

13 Nov '26
lynxis has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44084?usp=email ) Change subject: tcap_as_loadshare: add rate counter tcap:loadshare:failure ...................................................................... tcap_as_loadshare: add rate counter tcap:loadshare:failure When selecting an ASP fails for a TCAP Begin message. Related: SYS#8283 Change-Id: I04e63bf30742e5e584609337aab11177553b8033 --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/84/44084/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index 8b71359..d000125 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -142,6 +142,7 @@ [SS7_AS_CTR_TCAP_DECODE_SUCCESS] = { "tcap:decode:success", "Number of successful decoded TCAP messages (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_DECODE_FAILURE] = { "tcap:decode:failure", "Number of TCAP messages which could not decoded (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS] = {"tcap:loadshare:success","Successful ASP selection for a TCAP Begin message (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE] = {"tcap:loadshare:failure","Could not find a valid ASP for a TCAP Begin message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" }, diff --git a/src/ss7_as.h b/src/ss7_as.h index 4e6b671..f869240 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -69,6 +69,7 @@ SS7_AS_CTR_TCAP_DECODE_SUCCESS, SS7_AS_CTR_TCAP_DECODE_FAILURE, SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS, + SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE, SS7_AS_CTR_TCAP_ASP_FALLBACK, SS7_AS_CTR_TCAP_ASP_FAILED, SS7_AS_CTR_TCAP_SESS_MISS, diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 15512a6..81fae90 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -665,6 +665,7 @@ } else { /* Couldn't find a suitable canditate */ LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a suitable canditate for TCAP Begin otid %u\n", parsed.otid); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE); rc = -ENOKEY; goto out_free_sua; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I04e63bf30742e5e584609337aab11177553b8033 Gerrit-Change-Number: 44084 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 29
  • 30
  • 31
  • 32
  • 33
  • 34
  • 35
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.