lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: refactor and cleanup tcap state
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/9cda38b2_d8987… : PS2, Line 1112: void tcap_asp_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp) > But if you look into the code where tcap_asp_down is called, you find such loop. ACK, but still from API/event point of view, this looks like the wrong approach imho. Please rewrite tcap_asp_down() to be passed only the asp as parameter, and then do a loop iteration here in tcap_asp_down() calling tcap_cleanup_state() for each as. File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/7ee71b30_0410c… : PS2, Line 472: tcap_asp_down(as, asp); Move this block above outside the llist_for_each_entry_safe() loop. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:13:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[M] Change in libosmocore[master]: libosmogsm: Use the subscriber's K length for TUAK AUTS
by pespin 16 Nov '26

16 Nov '26
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email ) Change subject: libosmogsm: Use the subscriber's K length for TUAK AUTS ...................................................................... libosmogsm: Use the subscriber's K length for TUAK AUTS tuak_gen_vec_auts() passed sizeof(aud->u.umts.k), which is always 32, as the K length, so resync failed for every subscriber with a 128-bit K. Add TUAK resync cases with a 128-bit and a 256-bit K to the osmo-auc-gen test. Fixes: OS#7119 Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 --- M src/gsm/auth_tuak.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M tests/osmo-auc-gen/osmo-auc-gen_test.sh 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/gsm/auth_tuak.c b/src/gsm/auth_tuak.c index 05fbf69..075d915 100644 --- a/src/gsm/auth_tuak.c +++ b/src/gsm/auth_tuak.c @@ -179,7 +179,7 @@ opc = gen_opc_if_needed(aud, gen_opc); - rc = tuak_auts(opc, aud->u.umts.k, sizeof(aud->u.umts.k), rand_auts, auts, sqn_out); + rc = tuak_auts(opc, aud->u.umts.k, aud->u.umts.k_len, rand_auts, auts, sqn_out); if (rc < 0) return rc; diff --git a/tests/osmo-auc-gen/osmo-auc-gen_test.ok b/tests/osmo-auc-gen/osmo-auc-gen_test.ok index 2da0b02..d18e57c 100644 --- a/tests/osmo-auc-gen/osmo-auc-gen_test.ok +++ b/tests/osmo-auc-gen/osmo-auc-gen_test.ok @@ -290,3 +290,39 @@ osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY + + +> osmo-auc-gen -3 -a tuak -r 42424242424242424242424242424242 -k abababababababababababababababab -O 5555555555555555555555555555555555555555555555555555555555555555 -A e7af6b3d0e2f4f669592ff7d647d +osmo-auc-gen (C) 2011-2023 by Harald Welte +This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY + +RAND: 42424242424242424242424242424242 +AUTN: aad217459a450000a629d0b8d090f68f +IK: 52c2ecdcb90878d9eaa7ae82add046c0 +CK: 144269a4bd882a02026ddbb13243404b +RES: 7abd06d3fff7f634 +IMS nonce: QkJCQkJCQkJCQkJCQkJCQqrSF0WaRQAApinQuNCQ9o8= +IMS res: er0G0//39jQ= +SRES: 854af0e7 +Kc: ae4af04b9b135450 +SQN: 32 +IND: 0 +SQN.MS: 23 + + +> osmo-auc-gen -3 -a tuak -r 0123456789abcdef0123456789abcdef -k fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e0 -O 808182838485868788898a8b8c8d8e8f909192939495969798999a9b9c9d9e9f -A f84eb338849bac1fbaf692a06dfb +osmo-auc-gen (C) 2011-2023 by Harald Welte +This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY + +RAND: 0123456789abcdef0123456789abcdef +AUTN: 480a9345cc3e00009a4cacea6268825e +IK: 2274155ccf4199d5e2abcbf621907f90 +CK: a4cb6f6529ab17f8337f27baa8234d47 +RES: e9d749dc4eea0035 +IMS nonce: ASNFZ4mrze8BI0VniavN70gKk0XMPgAAmkys6mJogl4= +IMS res: 6ddJ3E7qADU= +SRES: a73d49e9 +Kc: 576b96756f59bcfa +SQN: 32 +IND: 0 +SQN.MS: 23 diff --git a/tests/osmo-auc-gen/osmo-auc-gen_test.sh b/tests/osmo-auc-gen/osmo-auc-gen_test.sh index 55b0757..5a301f9 100755 --- a/tests/osmo-auc-gen/osmo-auc-gen_test.sh +++ b/tests/osmo-auc-gen/osmo-auc-gen_test.sh @@ -60,3 +60,17 @@ invoke_err -3 -a milenage -r $rand -k $k -o $opc -A $auts --ind 42 invoke_err -3 -a milenage -r $rand -k $k -o $opc -A $auts --ind-len 0 --ind 1 + +# TUAK resync with a 128-bit and a 256-bit K, using the K, TOP and RAND of +# 3GPP TS 35.233 test sets 1 and 2 +k="abababababababababababababababab" +op="5555555555555555555555555555555555555555555555555555555555555555" +rand="42424242424242424242424242424242" +auts="e7af6b3d0e2f4f669592ff7d647d" # --> SQN.MS = 23 +invoke -3 -a tuak -r $rand -k $k -O $op -A $auts + +k="fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e0" +op="808182838485868788898a8b8c8d8e8f909192939495969798999a9b9c9d9e9f" +rand="0123456789abcdef0123456789abcdef" +auts="f84eb338849bac1fbaf692a06dfb" # --> SQN.MS = 23 +invoke -3 -a tuak -r $rand -k $k -O $op -A $auts -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 Gerrit-Change-Number: 44088 Gerrit-PatchSet: 1 Gerrit-Owner: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in libosmocore[master]: libosmogsm: Use the subscriber's K length for TUAK AUTS
by pespin 16 Nov '26

16 Nov '26
Attention is currently required from: Josh Shilts. pespin has posted comments on this change by Josh Shilts. ( https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email ) Change subject: libosmogsm: Use the subscriber's K length for TUAK AUTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 Gerrit-Change-Number: 44088 Gerrit-PatchSet: 1 Gerrit-Owner: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:02:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmocore[master]: libosmogsm: Use the subscriber's K length for TUAK AUTS
by fixeria 16 Nov '26

16 Nov '26
Attention is currently required from: Josh Shilts, pespin. fixeria has posted comments on this change by Josh Shilts. ( https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email ) Change subject: libosmogsm: Use the subscriber's K length for TUAK AUTS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 Gerrit-Change-Number: 44088 Gerrit-PatchSet: 1 Gerrit-Owner: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 06:55:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmocore[master]: socket: Introduce API osmo_sockaddr_pton()
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/44072?usp=email ) Change subject: socket: Introduce API osmo_sockaddr_pton() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I196dc4ab58ab300e2b16daeb214278cfb9bb8226 Gerrit-Change-Number: 44072 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 00:29:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-pfcp[master]: pfcp_msg: Introduce API osmo_pfcp_ie_node_id_from_str()
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/44073?usp=email ) Change subject: pfcp_msg: Introduce API osmo_pfcp_ie_node_id_from_str() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/44073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ibfb53fddb618a4480d873ceb783e56c0a0e5fead Gerrit-Change-Number: 44073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 00:28:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-upf[master]: vty: Support configuring local PFCP Node ID
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/44074?usp=email ) Change subject: vty: Support configuring local PFCP Node ID ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/44074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iaba51a7f3d6b357ab6d484e073653422178adac7 Gerrit-Change-Number: 44074 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 00:28:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-ccid-firmware[master]: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email ) Change subject: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters} ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I agre this should be merged in general, but let's slightly delay it until we have merged all the mo […] I'd guess for quite some time. Please rebase + resubmit -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24 Gerrit-Change-Number: 42312 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 00:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: testenv: set default titan version to 11.2.1
by laforge 16 Nov '26

16 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44071?usp=email ) Change subject: testenv: set default titan version to 11.2.1 ...................................................................... testenv: set default titan version to 11.2.1 Related: OS#7106 Change-Id: I04145bd975b464301f41fa020e6082d1feb67b61 --- M _testenv/testenv/testsrcdir_cfg.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/testenv/testsrcdir_cfg.py b/_testenv/testenv/testsrcdir_cfg.py index c21c29c..1a7f9cd 100644 --- a/_testenv/testenv/testsrcdir_cfg.py +++ b/_testenv/testenv/testsrcdir_cfg.py @@ -11,7 +11,7 @@ cfg = { "max_jobs_per_gb_ram": None, - "titan_min": "11.1.0", + "titan_min": "11.2.1", } titan_version_in_path = None -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04145bd975b464301f41fa020e6082d1feb67b61 Gerrit-Change-Number: 44071 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in libosmocore[master]: libosmogsm: Use the subscriber's K length for TUAK AUTS
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: Josh Shilts. laforge has posted comments on this change by Josh Shilts. ( https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email ) Change subject: libosmogsm: Use the subscriber's K length for TUAK AUTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82180dde388a81eed337c7f1d99f5979489b9cd7 Gerrit-Change-Number: 44088 Gerrit-PatchSet: 1 Gerrit-Owner: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Josh Shilts <joshuashilts(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Nov 2026 00:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 28
  • 29
  • 30
  • 31
  • 32
  • 33
  • 34
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.