[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: refactor and cleanup tcap state
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/9cda38b2_d89870... : PS2, Line 1112: void tcap_asp_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp)
But if you look into the code where tcap_asp_down is called, you find such loop. ACK, but still from API/event point of view, this looks like the wrong approach imho.
Please rewrite tcap_asp_down() to be passed only the asp as parameter, and then do a loop iteration here in tcap_asp_down() calling tcap_cleanup_state() for each as. File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/7ee71b30_0410c5... : PS2, Line 472: tcap_asp_down(as, asp); Move this block above outside the llist_for_each_entry_safe() loop. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:13:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis <lynxis@fe80.eu>
participants (1)
-
pespin