[M] Change in libosmo-sigtran[master]: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 4: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/ad9e9e8c_03ec36... : PS2, Line 985: goto out;
that we need to fix it for all branches which uses `goto out`. Ok, do you mind submitting an extra patch fixing it?
File src/tcap_as_loadshare_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/23aac4c5_689e5b... : PS3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp))
The other I found, was using Yes and No. […] Then if there's can't be an inactive ASP, why doing the call to "!osmo_ss7_asp_active(assoc->asp)" ?
-- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis <lynxis@fe80.eu>
participants (1)
-
pespin