[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" fea...
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email ) Change subject: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" feature ...................................................................... Patch Set 2: (3 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/7a26d48f_8319a... : PS1, Line 467: private function f_tcap_loadshare_register_new_trans(
I don't get it. Having a function "f_tcap_loadshare_register_new_trans(nteger node_, integer tid_start, integer tid_stop, boolean accept_new_trans)" and calling it twice for A and B would make this a lot cleaner...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/94162887_bb84f... : PS1, Line 1074: testcase TC_tcap_loadshare_ipa_tcap_new_trans_register() runs on TCAP_CT {
Yes, this is a part of another tests. […] Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/711826c2_c7d7d... : PS1, Line 1109: var integer dtid := ((rand_tid + i) mod 99);
Because the dtid should be in the range of `asp-ipa-loadshare-0-0`. […] This actually relates to the other discussion a couple lines before. Since you are willing to test it for the other ASP then it needs modification.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948e95e66bdafadf01020e9e97ac50a04b78ec50 Gerrit-Change-Number: 44005 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 10:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis <lynxis@fe80.eu>
participants (1)
-
pespin