November 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: m3ua: Drop rx packets with unexpected Network Indicator
by fixeria 12 Nov '25

12 Nov '25

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email ) Change subject: m3ua: Drop rx packets with unexpected Network Indicator ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54de65b16949851062914ca5d3362d1e46158b8b Gerrit-Change-Number: 41408 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 18:12:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Add per ss7 instance rate_ctr_group
by fixeria 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email ) Change subject: Add per ss7 instance rate_ctr_group ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/ss7_instance.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407/comment/30a63e6c_39ce0… : PS4, Line 59: s7i Did you mean `ss7i` maybe? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id916307c2465daab3072f850774240969fae3f6e Gerrit-Change-Number: 41407 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 18:08:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp_sap.h: Protect MTP_SIO macro params with parenthesis
by pespin 12 Nov '25

12 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email ) Change subject: mtp_sap.h: Protect MTP_SIO macro params with parenthesis ...................................................................... mtp_sap.h: Protect MTP_SIO macro params with parenthesis Change-Id: I0ba8139fd5458ff3637eebaaba0d4c0edd080e6a --- M include/osmocom/sigtran/mtp_sap.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/sigtran/mtp_sap.h b/include/osmocom/sigtran/mtp_sap.h index 05308c2..f13d6f1 100644 --- a/include/osmocom/sigtran/mtp_sap.h +++ b/include/osmocom/sigtran/mtp_sap.h @@ -32,7 +32,7 @@ }; /* ITU Q.704 14.2 Service information octet. See enum mtp_si_ni00 in mtp.h. */ -#define MTP_SIO(service, net_ind) (((net_ind & 0x3) << 6) | (service & 0xF)) +#define MTP_SIO(service, net_ind) ((((net_ind) & 0x3) << 6) | ((service) & 0xF)) struct osmo_mtp_transfer_param { uint32_t opc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0ba8139fd5458ff3637eebaaba0d4c0edd080e6a Gerrit-Change-Number: 41404 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator()
by pespin 12 Nov '25

12 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email ) Change subject: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator() ...................................................................... ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator() This is usually needed for users (eg. osmo-bsc) willing to use the MTP SAP (eg. MTP-TRANSFER.req) since it needs to fill in prim.u.transfer.sio. Related: OS#6880 Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/ss7_instance.c 3 files changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index a89255b..2ecfd57 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmo-netif >1.6.0 stream OSMO_STREAM_{CLI,SRV}_TCP_SOCKOPT_KEEP* libosmo-sigtran add enum mtp_network_indicator, mtp_network_indicator_vals +libosmo-sigtran add osmo_ss7_instance_get_network_indicator() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index dc9aada..5a51ba3 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -59,6 +59,7 @@ osmo_ss7_instance_get_pc_fmt(const struct osmo_ss7_instance *inst); uint32_t osmo_ss7_instance_get_primary_pc(const struct osmo_ss7_instance *inst); +uint8_t osmo_ss7_instance_get_network_indicator(const struct osmo_ss7_instance *inst); struct osmo_sccp_instance *osmo_ss7_ensure_sccp(struct osmo_ss7_instance *inst); struct osmo_sccp_instance *osmo_ss7_get_sccp(const struct osmo_ss7_instance *inst); diff --git a/src/ss7_instance.c b/src/ss7_instance.c index b583b98..a4cbe1e 100644 --- a/src/ss7_instance.c +++ b/src/ss7_instance.c @@ -125,6 +125,12 @@ return inst->cfg.primary_pc; } +/* Q.704 14.2.2 Sub-service field, bits D C (= Network Indicator) */ +uint8_t osmo_ss7_instance_get_network_indicator(const struct osmo_ss7_instance *inst) +{ + return inst->cfg.network_indicator; +} + /*! \brief Set the point code format used in given SS7 instance */ int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c Gerrit-Change-Number: 41409 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_rx_msg: fill xua->mtp.sio with configured network indicator
by pespin 12 Nov '25

12 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email ) Change subject: xua_rx_msg: fill xua->mtp.sio with configured network indicator ...................................................................... xua_rx_msg: fill xua->mtp.sio with configured network indicator Change-Id: I12b2debd62820e917a324da2b15cfb88eebc1bd1 --- M src/sua.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/sua.c b/src/sua.c index 448bdee..e157f31 100644 --- a/src/sua.c +++ b/src/sua.c @@ -717,7 +717,7 @@ xua->mtp.opc = ; xua->mtp.dpc = ; #endif - xua->mtp.sio = MTP_SI_SCCP; + xua->mtp.sio = MTP_SIO(MTP_SI_SCCP, asp->inst->cfg.network_indicator); LOGPASP(asp, DLSUA, LOGL_DEBUG, "Received SUA Message (%s)\n", xua_hdr_dump(xua, &xua_dialect_sua)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12b2debd62820e917a324da2b15cfb88eebc1bd1 Gerrit-Change-Number: 41405 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: tests/cnpool.vty: Skip non-related fields under cs7 instance
by pespin 12 Nov '25

12 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41412?usp=email ) Change subject: tests/cnpool.vty: Skip non-related fields under cs7 instance ...................................................................... tests/cnpool.vty: Skip non-related fields under cs7 instance libosmo-sigtran now always prints network-indicator, which creates an unexpected output during cnpool.vty test. Make sure it doesn't interfere with what we are really testing there. Related: libosmo-sigtran.git a11b2bfff289b09f4c9e964b763df288ace8304a Change-Id: I0e53cacbb0004f91c67f4c0bcb9b1d041fb534dd --- M tests/cnpool.vty 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/12/41412/1 diff --git a/tests/cnpool.vty b/tests/cnpool.vty index 83d7352..52f1369 100644 --- a/tests/cnpool.vty +++ b/tests/cnpool.vty @@ -135,6 +135,7 @@ OsmoHNBGW(config)# show running-config ... cs7 instance 0 +... point-code 0.23.5 ... sccp-address addr-dyn-msc-default -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0e53cacbb0004f91c67f4c0bcb9b1d041fb534dd Gerrit-Change-Number: 41412 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator()
by fixeria 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email ) Change subject: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c Gerrit-Change-Number: 41409 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 18:05:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: xua_rx_msg: fill xua->mtp.sio with configured network indicator
by fixeria 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email ) Change subject: xua_rx_msg: fill xua->mtp.sio with configured network indicator ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12b2debd62820e917a324da2b15cfb88eebc1bd1 Gerrit-Change-Number: 41405 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 18:04:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp_sap.h: Protect MTP_SIO macro params with parenthesis
by fixeria 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email ) Change subject: mtp_sap.h: Protect MTP_SIO macro params with parenthesis ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0ba8139fd5458ff3637eebaaba0d4c0edd080e6a Gerrit-Change-Number: 41404 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 18:03:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Always write network-indicator
by pespin 12 Nov '25

12 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email ) Change subject: vty: Always write network-indicator ...................................................................... vty: Always write network-indicator Network-indicator is an important configuration defining the network, hence it should always be printed during vty show/write. Change-Id: I969ee94c00afa7a77e26c8cf3e9b998b06022641 --- M src/ss7_vty.c M tests/vty/osmo_stp_route_prio.vty M tests/vty/osmo_stp_test.vty 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/ss7_vty.c b/src/ss7_vty.c index cfc658d..98c6073 100644 --- a/src/ss7_vty.c +++ b/src/ss7_vty.c @@ -1286,11 +1286,9 @@ vty_out(vty, "cs7 instance %u%s", inst->cfg.id, VTY_NEWLINE); if (inst->cfg.description) vty_out(vty, " description %s%s", inst->cfg.description, VTY_NEWLINE); - if (inst->cfg.network_indicator != MTP_NI_INTERNATIONAL) - vty_out(vty, " network-indicator %s%s", - get_value_string(mtp_network_indicator_vals, - inst->cfg.network_indicator), - VTY_NEWLINE); + vty_out(vty, " network-indicator %s%s", + get_value_string(mtp_network_indicator_vals, inst->cfg.network_indicator), + VTY_NEWLINE); if (inst->cfg.pc_fmt.component_len[0] != 3 || inst->cfg.pc_fmt.component_len[1] != 8 || diff --git a/tests/vty/osmo_stp_route_prio.vty b/tests/vty/osmo_stp_route_prio.vty index d9e3add..6a4ac08 100644 --- a/tests/vty/osmo_stp_route_prio.vty +++ b/tests/vty/osmo_stp_route_prio.vty @@ -36,6 +36,7 @@ OsmoSTP(config-cs7)# show running-config ... cs7 instance 0 + network-indicator international xua rkm routing-key-allocation dynamic-permitted asp asp1 2905 54321 m3ua local-ip 27.0.0.1 diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 62ad287..8f2a96a 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -610,6 +610,7 @@ OsmoSTP(config)# show running-config ... cs7 instance 0 + network-indicator international xua rkm routing-key-allocation dynamic-permitted asp my-asp 12345 54321 m3ua local-ip 127.0.0.100 @@ -632,6 +633,7 @@ routing-indicator PC point-code 1.2.3 cs7 instance 1 + network-indicator international route-table system sccp-address bar routing-indicator PC -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I969ee94c00afa7a77e26c8cf3e9b998b06022641 Gerrit-Change-Number: 41403 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025