November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: erab_fsm: log the creation event and UID
by fixeria 21 Nov '25

21 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41475?usp=email ) Change subject: erab_fsm: log the creation event and UID ...................................................................... erab_fsm: log the creation event and UID When looking at GSMTAP logging, it's oftentimes useful to see the beginning of a lifecycle of an E-RAB FSM. Change-Id: I5746a645d95c9c931c24ebc170ef88cd38311542 Related: SYS#7738 --- M src/erab_fsm.erl 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/75/41475/1 diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index 49a26ca..213a3c1 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -232,6 +232,7 @@ init([UID]) -> set_logging_prefix(UID), + ?LOG_DEBUG("Creating E-RAB FSM (UID ~p)", [UID]), %% request a unieue SEID for this E-RAB FSM {ok, SEID} = pfcp_peer:seid_alloc(), {ok, erab_wait_setup_req, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5746a645d95c9c931c24ebc170ef88cd38311542 Gerrit-Change-Number: 41475 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: move catch-all for SCTP events to handle_event/4
by fixeria 21 Nov '25

21 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41476?usp=email ) Change subject: sctp_proxy: move catch-all for SCTP events to handle_event/4 ...................................................................... sctp_proxy: move catch-all for SCTP events to handle_event/4 Reduce code duplication and prepare for handing of sctp_error. Change-Id: I8f42a31fdf4a4e01106ace81d87188a340fe7c83 Related: SYS#7738 --- M src/sctp_proxy.erl 1 file changed, 6 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/76/41476/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 4ed3cb8..594b286 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -149,13 +149,6 @@ {stop, {shutdown, conn_est_fail}} end; -%% Catch-all for other kinds of SCTP events -connecting(info, {sctp, _Socket, MmeAddr, MmePort, - {AncData, Data}}, S) -> - ?LOG_DEBUG("Unhandled SCTP event (~p:~p): ~p, ~p", - [MmeAddr, MmePort, AncData, Data]), - {keep_state, S}; - connecting(Event, EventData, S) -> handle_event(?FUNCTION_NAME, Event, EventData, S). @@ -213,13 +206,6 @@ end, {keep_state, S}; -%% Catch-all for other kinds of SCTP events -connected(info, {sctp, _Socket, MmeAddr, MmePort, - {AncData, Data}}, S) -> - ?LOG_DEBUG("Unhandled SCTP event (~p:~p): ~p, ~p", - [MmeAddr, MmePort, AncData, Data]), - {keep_state, S}; - connected(Event, EventData, S) -> handle_event(?FUNCTION_NAME, Event, EventData, S). @@ -233,6 +219,12 @@ ?LOG_ERROR("Unexpected call in state ~p: ~p", [State, EventData]), {keep_state_and_data, {reply, From, {error, {unexpected_call, State}}}}; +%% Catch-all for unhandled SCTP events +handle_event(State, info, {sctp, _Socket, MmeAddr, MmePort, {AncData, Data}}, _S) -> + ?LOG_DEBUG("Unhandled SCTP event in state ~p (~p:~p): ~p, ~p", + [State, MmeAddr, MmePort, AncData, Data]), + keep_state_and_data; + handle_event(State, Event, EventData, _S) -> ?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State, EventData]), keep_state_and_data. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8f42a31fdf4a4e01106ace81d87188a340fe7c83 Gerrit-Change-Number: 41476 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_{server,proxy}: handle sctp_error messages from gen_sctp
by fixeria 21 Nov '25

21 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email ) Change subject: sctp_{server,proxy}: handle sctp_error messages from gen_sctp ...................................................................... sctp_{server,proxy}: handle sctp_error messages from gen_sctp The `{sctp_error, ...}` message is undocumented, but it does exist, and we have encountered it in production. The logic that generates `{sctp, ...}` and `{sctp_error, ...}` messages resides in Erlang/OTP's inet_drv.c, specifically in packet_binary_message() and sctp_parse_async_event(). Within sctp_parse_async_event(), an error is indicated by replacing the initial `sctp` atom with `sctp_error`. Currently the following SCTP events are treated as errors: * SCTP_SEND_FAILED (becomes #sctp_send_failed{}), * SCTP_REMOTE_ERROR (becomes #sctp_remote_error{}), * SCTP_PARTIAL_DELIVERY_EVENT (becomes #sctp_pdapi_event{}). Print more specific messages when the sctp_error is received. Add new metrics for the above-mentioned SCTP events. Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Related: SYS#7738 --- M include/s1gw_metrics.hrl M src/s1gw_metrics.erl M src/sctp_common.erl M src/sctp_proxy.erl M src/sctp_server.erl 5 files changed, 48 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/77/41477/1 diff --git a/include/s1gw_metrics.hrl b/include/s1gw_metrics.hrl index 5afbff0..385b5fa 100644 --- a/include/s1gw_metrics.hrl +++ b/include/s1gw_metrics.hrl @@ -40,6 +40,12 @@ -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ALL, [ctr, s1ap, proxy, out_pkt, reply, all]). -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP, [ctr, s1ap, proxy, out_pkt, reply, erab_setup_rsp]). +%% SCTP related metrics +-define(S1GW_CTR_SCTP_ERROR_ALL, [ctr, sctp, error, all]). +-define(S1GW_CTR_SCTP_ERROR_SEND_FAILED, [ctr, sctp, error, send_failed]). +-define(S1GW_CTR_SCTP_ERROR_PDAPI_EVENT, [ctr, sctp, error, pdapi_event]). +-define(S1GW_CTR_SCTP_ERROR_REMOTE_ERROR, [ctr, sctp, error, remote_error]). + %% per-eNB counters %% NOTE: these counters shall not be listed in ?S1GW_COUNTERS, %% but created dynamically for each connecting eNB. diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl index 7ca3352..bb4bd97 100644 --- a/src/s1gw_metrics.erl +++ b/src/s1gw_metrics.erl @@ -95,7 +95,13 @@ ?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_PROC, %% forwarded: processed ?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_UNMODIFIED, %% forwarded: unmodified ?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ALL, %% replied: total - ?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP %% replied: E-RAB SETUP.rsp + ?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP, %% replied: E-RAB SETUP.rsp + + %% SCTP related counters + ?S1GW_CTR_SCTP_ERROR_ALL, %% total number of SCTP errors + ?S1GW_CTR_SCTP_ERROR_SEND_FAILED, %% send operation failed + ?S1GW_CTR_SCTP_ERROR_PDAPI_EVENT, %% partial delivery failure + ?S1GW_CTR_SCTP_ERROR_REMOTE_ERROR %% remote error ]). -define(S1GW_GAUGES, [ diff --git a/src/sctp_common.erl b/src/sctp_common.erl index 296dbff..9b86b50 100644 --- a/src/sctp_common.erl +++ b/src/sctp_common.erl @@ -35,12 +35,14 @@ -module(sctp_common). -export([parse_addr/1, + report_error/1, send_data/2, shutdown/1]). -include_lib("kernel/include/logger.hrl"). -include_lib("kernel/include/inet_sctp.hrl"). +-include("s1gw_metrics.hrl"). -include("s1ap.hrl"). @@ -68,6 +70,20 @@ end. +-spec report_error(term()) -> term(). +report_error(Error) -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_ALL), + case Error of + #sctp_send_failed{} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_SEND_FAILED); + #sctp_pdapi_event{} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_PDAPI_EVENT); + #sctp_remote_error{} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_REMOTE_ERROR); + _ -> ok + end. + + -spec send_data(sock_aid(), binary()) -> ok | {error, term()}. send_data({Sock, Aid}, Data) -> gen_sctp:send(Sock, #sctp_sndrcvinfo{stream = ?S1AP_SCTP_STREAM, diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 594b286..3aa67d8 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -225,6 +225,12 @@ [State, MmeAddr, MmePort, AncData, Data]), keep_state_and_data; +handle_event(State, info, {sctp_error, _Socket, MmeAddr, MmePort, {_, Error}}, _S) -> + ?LOG_ERROR("Rx SCTP error in state ~p (~p:~p): ~p", + [State, MmeAddr, MmePort, Error]), + sctp_common:report_error(Error), + keep_state_and_data; + handle_event(State, Event, EventData, _S) -> ?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State, EventData]), keep_state_and_data. diff --git a/src/sctp_server.erl b/src/sctp_server.erl index d194ce4..46c352b 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -158,6 +158,10 @@ S1 = sctp_recv({FromAddr, FromPort, AncData, Data}, S0), {noreply, S1}; +handle_info({sctp_error, _Socket, FromAddr, FromPort, {_, Error}}, S0) -> + S1 = sctp_error({FromAddr, FromPort, Error}, S0), + {noreply, S1}; + %% Handle termination events of the child processes handle_info({'EXIT', Pid, Reason}, #server_state{sock = Sock, clients = Clients} = S0) -> @@ -245,6 +249,15 @@ S. +%% SCTP error handler +sctp_error({FromAddr, FromPort, Error}, + #server_state{} = S) -> + ?LOG_ERROR("Rx SCTP error (~p:~p): ~p", + [FromAddr, FromPort, Error]), + sctp_common:report_error(Error), + S. + + %% Add a new client to the list, spawning a handler process client_add(Aid, FromAddr, FromPort, #server_state{clients = Clients, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Gerrit-Change-Number: 41477 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: re-organize Card Key Provider related options
by dexter 21 Nov '25

21 Nov '25

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41468?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell: re-organize Card Key Provider related options ...................................................................... pySim-shell: re-organize Card Key Provider related options As we plan to support other formats as data source for the Card Key Provider soon, the more commandline options may be added and it makes sense to group the Card Key Provider options in a dedicated group. Let's also rename the option "--csv-column-key" to just "--column-key". The column encryption is a generic concept and not CSV format specific. (let's silently keep the "--csv-column-key" argument so maintain backward compatibility) Related: SYS#7725 Change-Id: I5093f8383551f8c9b84342ca6674c1ebdbbfc19c --- M pySim-shell.py 1 file changed, 14 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/68/41468/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5093f8383551f8c9b84342ca6674c1ebdbbfc19c Gerrit-Change-Number: 41468 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: upf: Use Node ID already generated in g_pars
by pespin 21 Nov '25

21 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email ) Change subject: upf: Use Node ID already generated in g_pars ...................................................................... upf: Use Node ID already generated in g_pars Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 --- M upf/UPF_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 434e4f4..f9c0186 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -875,7 +875,7 @@ private function f_session_est(inout PFCP_session s, PFCP_Ruleset rules) runs on CPF_ConnHdlr { log("f_session_est: rules = ", rules); - PFCP.send(ts_PFCP_Session_Est_Req(ts_PFCP_Node_ID_ipv4(f_inet_addr(g_pars.local_addr)), + PFCP.send(ts_PFCP_Session_Est_Req(g_pars.local_node_id, ts_PFCP_F_SEID_ipv4(f_inet_addr(g_pars.local_addr), s.cp_seid), rules.pdr, rules.far)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 Gerrit-Change-Number: 41469 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: upf: Use Node ID already generated in g_pars
by pespin 21 Nov '25

21 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email ) Change subject: upf: Use Node ID already generated in g_pars ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 Gerrit-Change-Number: 41469 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Nov 2025 15:04:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: upf: Use Node ID already generated in g_pars
by osmith 20 Nov '25

20 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email ) Change subject: upf: Use Node ID already generated in g_pars ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 Gerrit-Change-Number: 41469 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Nov 2025 12:25:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: sccplite: rx mgcp: Make sure payload string is null-terminated
by daniel 20 Nov '25

20 Nov '25

Attention is currently required from: fixeria, laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41449?usp=email ) Change subject: sccplite: rx mgcp: Make sure payload string is null-terminated ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/osmo_bsc_mgcp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41449/comment/afc52f08_18004a20?usp… : PS1, Line 107: LOGPFSMSL(conn->fi, DMSC, LOGL_DEBUG, "ep_local_name='%s' vs rcv_ep_local_name='%s'\n", These formatting changes seem wrong since the lines are all well under 120 characters -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac3ea7dd5d89eb9ffb6d5123700e9dc9cdfc2ea2 Gerrit-Change-Number: 41449 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Nov 2025 12:15:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-gsm-manuals[master]: GSUP: PDP Context ID: start at 1
by osmith 20 Nov '25

20 Nov '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41471?usp=email to look at the new patch set (#2). Change subject: GSUP: PDP Context ID: start at 1 ...................................................................... GSUP: PDP Context ID: start at 1 In OsmoHLR, PDP Contexts can have IDs <1-10>. 0 is used internally to mark a profile slot as disabled: https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr/src/commit/d4b45… HLR Test TC_gsup_ul_subscriber_data in osmo-ttcn3-hacks also makes this assumption: https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/85276b94c474bb6… However the new GSUP implementation in PyHSS started its IDs at 0. I've suggested to start it at 1 here: https://github.com/nickvsnetworking/pyhss/pull/277/files/4b6da7447438778068… Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48 --- M common/chapters/gsup.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/71/41471/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48 Gerrit-Change-Number: 41471 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-ttcn3-hacks[master]: pyhss_api_helper: add second default apn "*"
by osmith 20 Nov '25

20 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41473?usp=email ) Change subject: pyhss_api_helper: add second default apn "*" ...................................................................... pyhss_api_helper: add second default apn "*" Prepare to make HLR test TC_gsup_ul_subscriber_data pass with PyHSS, which assumes that a second APN named "*" exists. Change-Id: Ibac60f03d62dcb37889cd05a35ad106fc5eb1f5f --- M _testenv/data/scripts/pyhss_api_helper.py M hlr/pyhss/setup_db.sh M hss/pyhss/setup_db.sh 3 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/41473/1 diff --git a/_testenv/data/scripts/pyhss_api_helper.py b/_testenv/data/scripts/pyhss_api_helper.py index 09b220d..7517567 100755 --- a/_testenv/data/scripts/pyhss_api_helper.py +++ b/_testenv/data/scripts/pyhss_api_helper.py @@ -16,7 +16,7 @@ parser = argparse.ArgumentParser() subparsers = parser.add_subparsers(title="action", dest="action", required=True) - subparser = subparsers.add_parser("add_default_apn") + subparser = subparsers.add_parser("add_default_apns") subparser = subparsers.add_parser("add_subscr") subparser.add_argument("--imsi", required=True) @@ -32,8 +32,9 @@ args = parser.parse_args() -def add_default_apn(): +def add_default_apns(): url = f"{api}/apn/" + print(f"PUT {url}") payload = { "apn_id": 1, @@ -49,6 +50,21 @@ } session.put(url, json=payload) + print(f"PUT {url}") + payload = { + "apn_id": 2, + "apn": "*", + "ip_version": 0, + "charging_characteristics": "0800", + "apn_ambr_dl": 0, + "apn_ambr_ul": 0, + "qci": 9, + "arp_priority": 4, + "arp_preemption_capability": 0, + "arp_preemption_vulnerability": 1, + } + session.put(url, json=payload) + def add_subscr(): # Previous tests may have left an entry in the AUC table @@ -74,7 +90,7 @@ payload = { "auc_id": args.auc_id, "default_apn": "internet", - "apn_list": "1", + "apn_list": "1,2", "imsi": args.imsi, "msisdn": args.msisdn, } diff --git a/hlr/pyhss/setup_db.sh b/hlr/pyhss/setup_db.sh index 5fe0a71..3a51113 100755 --- a/hlr/pyhss/setup_db.sh +++ b/hlr/pyhss/setup_db.sh @@ -2,4 +2,4 @@ wait_for_port.py -p 8080 -pyhss_api_helper.py add_default_apn +pyhss_api_helper.py add_default_apns diff --git a/hss/pyhss/setup_db.sh b/hss/pyhss/setup_db.sh index aa31d76..ecbaf39 100755 --- a/hss/pyhss/setup_db.sh +++ b/hss/pyhss/setup_db.sh @@ -2,7 +2,7 @@ wait_for_port.py -p 8080 pyhss_api_helper.py \ - add_default_apn + add_default_apns # Create a test subscriber with IMSI=001010000000000 pyhss_api_helper.py \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibac60f03d62dcb37889cd05a35ad106fc5eb1f5f Gerrit-Change-Number: 41473 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025