Jenkins Builder has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41413?usp=email )
Change subject: handover: Move log macros to handover_fsm.h
......................................................................
Patch Set 1:
(3 comments)
File include/osmocom/bsc/handover_fsm.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-bsc/+/41413/comment/0ea5b185_839e5d95?usp… :
PS1, Line 18: bsc_subscr_name(lchan->conn? lchan->conn->bsub : NULL), \
spaces required around that '?' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-bsc/+/41413/comment/fcf2ab09_f53f44ff?usp… :
PS1, Line 30: bsc_subscr_name(lchan->conn? lchan->conn->bsub : NULL), \
spaces required around that '?' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-bsc/+/41413/comment/58ab4f2b_ec3b6729?usp… :
PS1, Line 42: bsc_subscr_name(lchan->conn? lchan->conn->bsub : NULL), \
spaces required around that '?' (ctx:VxW)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I65fdde44042b8c4a050aaa07961676c4c18c0431
Gerrit-Change-Number: 41413
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 13 Nov 2025 06:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email )
Change subject: handover_decision: Check for connection prerequisites
......................................................................
handover_decision: Check for connection prerequisites
Before this fix, a handover could be started while
subscriber doesn't have a connection or while an initial
assignment is stiil going.
In some cases, it would cause the assert in handover_request
to fail.
Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d
---
M src/osmo-bsc/handover_decision.c
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/41415/1
diff --git a/src/osmo-bsc/handover_decision.c b/src/osmo-bsc/handover_decision.c
index 2fb466c..2cb12a3 100644
--- a/src/osmo-bsc/handover_decision.c
+++ b/src/osmo-bsc/handover_decision.c
@@ -234,6 +234,20 @@
if (mr->num_cell > 0 && mr->num_cell < 7)
process_meas_neigh(mr);
+ /* check for ongoing handover/assignment */
+ if (!mr->lchan->conn) {
+ LOGPHOLCHAN(mr->lchan, LOGL_ERROR, "Skipping, No subscriber connection???\n");
+ return;
+ }
+ if (mr->lchan->conn->assignment.new_lchan) {
+ LOGPHOLCHAN(mr->lchan, LOGL_INFO, "Skipping, Initial Assignment is still ongoing\n");
+ return;
+ }
+ if (mr->lchan->conn->ho.fi) {
+ LOGPHOLCHAN(mr->lchan, LOGL_INFO, "Skipping, Handover still ongoing\n");
+ return;
+ }
+
av_rxlev = get_meas_rep_avg(mr->lchan, TDMA_MEAS_FIELD_RXLEV, TDMA_MEAS_DIR_DL, TDMA_MEAS_SET_AUTO,
ho_get_hodec1_rxlev_avg_win(bts->ho));
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41415?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I37314bdadd306ea96963d020b7c5372323e4640d
Gerrit-Change-Number: 41415
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email )
Change subject: m3ua: Drop rx packets with unexpected Network Indicator
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408/comment/a813514b_034b6… :
PS2, Line 639:
> I looked at Cisco ITP manual and they are doing this, grep for "network ind" and you'll see counters […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I54de65b16949851062914ca5d3362d1e46158b8b
Gerrit-Change-Number: 41408
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Nov 2025 19:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email )
Change subject: Add per ss7 instance rate_ctr_group
......................................................................
Patch Set 4:
(1 comment)
File src/ss7_instance.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407/comment/a8549510_42585… :
PS4, Line 59: s7i
> Did you mean `ss7i` maybe?
we use the "s7i" keyword in multiple places in the code. I'm fine with changing it whatever someone thinks may make more sense, for me s7i is good.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Id916307c2465daab3072f850774240969fae3f6e
Gerrit-Change-Number: 41407
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Nov 2025 18:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>