Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email )
Change subject: m3ua: Drop rx packets with unexpected Network Indicator
......................................................................
Patch Set 2:
(1 comment)
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408/comment/40c0dca2_8b942… :
PS2, Line 639:
> is there actually a requirement in the MTP spec that requests us to do this? It makes sense, but I […]
I looked at Cisco ITP manual and they are doing this, grep for "network ind" and you'll see counters for exactly this. According to its user manual if you want to have different networks then you declare different cs7 instance and configure translation between them, see "Configuring Multiple Instances and Instance
Translation".
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I54de65b16949851062914ca5d3362d1e46158b8b
Gerrit-Change-Number: 41408
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 17:50:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email )
Change subject: Omit all-zero octets in MS Classmark 3
......................................................................
Omit all-zero octets in MS Classmark 3
TS 24.008 Clause 10.5.7.1 allows us to omit all-zero octets at the end
of the information element. The decoder will add them if needed.
Older specs tell us to include the supported bands, a5 bits and radio
capability. Therefore we don't omit them, even if their encoded octets
are all-zero.
Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index 1750c57..c04193c 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -1270,6 +1270,7 @@
struct gsm_support *sup = &ms->support;
struct gsm_settings *set = &ms->settings;
struct bitvec bv;
+ int minimum_len;
memset(&bv, 0, sizeof(bv));
bv.data = buf;
@@ -1328,6 +1329,8 @@
bitvec_set_uint(&bv, 0, 4);
bitvec_set_uint(&bv, set->class_900, 4);
}
+ /* These octets above shall be included according to GSM 04.08 Version 5.3.0. */
+ minimum_len = (bv.cur_bit + 7) >> 3;
/* r support */
if (set->r_gsm) {
bitvec_set_bit(&bv, ONE);
@@ -1442,6 +1445,16 @@
*len = (bv.cur_bit + 7) >> 3;
bitvec_fill(&bv, (*len*8) - bv.cur_bit, ZERO);
+ /* Remove all all-zero octets at the end. See the rule in Clause 10.5.7.1:
+ "Typically, the number of spare bits at the end is the minimum to reach an octet boundary.
+ The receiver may add any number of bits set to "0" at the end of the received string
+ if needed for correct decoding."
+ GSM 04.08 Version 5.3.0 states that spare octets after "octet 3" and "octet 3bis" may be omitted.
+ Note that "octet 3" refers to the first value (buf[0]) in this TLV information element.
+ */
+ while (*len > minimum_len && buf[*len - 1] == 0x00)
+ (*len)--;
+
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481
Gerrit-Change-Number: 41357
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email )
Change subject: RSSI app: Use correct BSIC for RACH bursts
......................................................................
RSSI app: Use correct BSIC for RACH bursts
A regular RACH burst uses the BSIC of the cell. A 'UIC' (uplink identity
code) value is used for ASCI group calls. The value 0xff disables 'UIC'.
Fixes: 23d46f003 ("ASCI: Add UIC support to random access burst")
Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
---
M src/target/firmware/apps/rssi/main.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c
index 29c5430..a871714 100644
--- a/src/target/firmware/apps/rssi/main.c
+++ b/src/target/firmware/apps/rssi/main.c
@@ -1209,6 +1209,7 @@
rach_req->ra = rach_ra;
rach_req->offset = 0;
rach_req->combined = (ccch_conf == 1);
+ rach_req->uic = 0xff; /* disable, use BSIC instead */
l1a_l23_rx(SC_DLCI_L1A_L23, msg1);
l1a_l23_rx(SC_DLCI_L1A_L23, msg2);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
Gerrit-Change-Number: 41358
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email )
Change subject: m3ua: Drop rx packets with unexpected Network Indicator
......................................................................
Patch Set 2:
(1 comment)
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408/comment/ff852a45_24fff… :
PS2, Line 639:
is there actually a requirement in the MTP spec that requests us to do this? It makes sense, but I think I remotely recall that some STPs actually have different routing tables for different NI...
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41408?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I54de65b16949851062914ca5d3362d1e46158b8b
Gerrit-Change-Number: 41408
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Nov 2025 17:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email )
Change subject: Add per ss7 instance rate_ctr_group
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41407?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Id916307c2465daab3072f850774240969fae3f6e
Gerrit-Change-Number: 41407
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Nov 2025 17:24:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email )
Change subject: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c
Gerrit-Change-Number: 41409
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Nov 2025 17:23:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes