November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: xua_rx_msg: fill xua->mtp.sio with configured network indicator
by laforge 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email ) Change subject: xua_rx_msg: fill xua->mtp.sio with configured network indicator ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12b2debd62820e917a324da2b15cfb88eebc1bd1 Gerrit-Change-Number: 41405 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:23:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp_sap.h: Protect MTP_SIO macro params with parenthesis
by laforge 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email ) Change subject: mtp_sap.h: Protect MTP_SIO macro params with parenthesis ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0ba8139fd5458ff3637eebaaba0d4c0edd080e6a Gerrit-Change-Number: 41404 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Always write network-indicator
by laforge 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email ) Change subject: vty: Always write network-indicator ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I969ee94c00afa7a77e26c8cf3e9b998b06022641 Gerrit-Change-Number: 41403 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:22:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: mtp: Improve Network Indicator definitions
by laforge 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41402?usp=email ) Change subject: mtp: Improve Network Indicator definitions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0a7e113ac89946e5cf3bec8bec07ad10ee38723d Gerrit-Change-Number: 41402 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Move osmo_ss7_user_mtp_xfer_req() to proper header
by pespin 12 Nov '25

12 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41406?usp=email ) Change subject: Move osmo_ss7_user_mtp_xfer_req() to proper header ...................................................................... Patch Set 3: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibdf9be85eed50ede7719a3f5510705f0c82bf7f9 Gerrit-Change-Number: 41406 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 17:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Always write network-indicator
by pespin 12 Nov '25

12 Nov '25

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: vty: Always write network-indicator ...................................................................... vty: Always write network-indicator Network-indicator is an important configuration defining the network, hence it should always be printed during vty show/write. Change-Id: I969ee94c00afa7a77e26c8cf3e9b998b06022641 --- M src/ss7_vty.c M tests/vty/osmo_stp_route_prio.vty M tests/vty/osmo_stp_test.vty 3 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/03/41403/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I969ee94c00afa7a77e26c8cf3e9b998b06022641 Gerrit-Change-Number: 41403 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: mtp.h: improve and fix wrong spec reference
by daniel 12 Nov '25

12 Nov '25

Attention is currently required from: fixeria, laforge, osmith, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41399?usp=email ) Change subject: cosmetic: mtp.h: improve and fix wrong spec reference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I98d3a03138812827725fecd5e093ac8f917d7a8c Gerrit-Change-Number: 41399 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Nov 2025 15:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator()
by pespin 12 Nov '25

12 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email ) Change subject: ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator() ...................................................................... ss7_instance: Introduce API osmo_ss7_instance_get_network_indicator() This is usually needed for users (eg. osmo-bsc) willing to use the MTP SAP (eg. MTP-TRANSFER.req) since it needs to fill in prim.u.transfer.sio. Related: OS#6880 Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/ss7_instance.c 3 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41409/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index a89255b..2ecfd57 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmo-netif >1.6.0 stream OSMO_STREAM_{CLI,SRV}_TCP_SOCKOPT_KEEP* libosmo-sigtran add enum mtp_network_indicator, mtp_network_indicator_vals +libosmo-sigtran add osmo_ss7_instance_get_network_indicator() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index dc9aada..5a51ba3 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -59,6 +59,7 @@ osmo_ss7_instance_get_pc_fmt(const struct osmo_ss7_instance *inst); uint32_t osmo_ss7_instance_get_primary_pc(const struct osmo_ss7_instance *inst); +uint8_t osmo_ss7_instance_get_network_indicator(const struct osmo_ss7_instance *inst); struct osmo_sccp_instance *osmo_ss7_ensure_sccp(struct osmo_ss7_instance *inst); struct osmo_sccp_instance *osmo_ss7_get_sccp(const struct osmo_ss7_instance *inst); diff --git a/src/ss7_instance.c b/src/ss7_instance.c index b583b98..a4cbe1e 100644 --- a/src/ss7_instance.c +++ b/src/ss7_instance.c @@ -125,6 +125,12 @@ return inst->cfg.primary_pc; } +/* Q.704 14.2.2 Sub-service field, bits D C (= Network Indicator) */ +uint8_t osmo_ss7_instance_get_network_indicator(const struct osmo_ss7_instance *inst) +{ + return inst->cfg.network_indicator; +} + /*! \brief Set the point code format used in given SS7 instance */ int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3eb8a562c8f032fe5fd3bfb8282c1a5d9699218c Gerrit-Change-Number: 41409 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: mtp: Improve Network Indicator definitions
by pespin 12 Nov '25

12 Nov '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41402?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: mtp: Improve Network Indicator definitions ...................................................................... mtp: Improve Network Indicator definitions Change-Id: I0a7e113ac89946e5cf3bec8bec07ad10ee38723d --- M TODO-RELEASE M include/osmocom/sigtran/mtp_sap.h M include/osmocom/sigtran/protocol/mtp.h M src/ss7_instance.h M src/ss7_vty.c 5 files changed, 22 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/02/41402/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0a7e113ac89946e5cf3bec8bec07ad10ee38723d Gerrit-Change-Number: 41402 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in libosmo-sigtran[master]: Move osmo_ss7_user_mtp_xfer_req() to proper header
by pespin 12 Nov '25

12 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41406?usp=email ) Change subject: Move osmo_ss7_user_mtp_xfer_req() to proper header ...................................................................... Move osmo_ss7_user_mtp_xfer_req() to proper header That API is part of the MTP SAP, move it there. Change-Id: Ibdf9be85eed50ede7719a3f5510705f0c82bf7f9 --- M include/osmocom/sigtran/mtp_sap.h M include/osmocom/sigtran/osmo_ss7.h 2 files changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/06/41406/1 diff --git a/include/osmocom/sigtran/mtp_sap.h b/include/osmocom/sigtran/mtp_sap.h index f13d6f1..dc3dd04 100644 --- a/include/osmocom/sigtran/mtp_sap.h +++ b/include/osmocom/sigtran/mtp_sap.h @@ -67,3 +67,7 @@ #define msgb_mtp_prim(msg) ((struct osmo_mtp_prim *)(msg)->l1h) char *osmo_mtp_prim_name(struct osmo_prim_hdr *oph); + +/* SS7 User wants to issue MTP-TRANSFER.req */ +int osmo_ss7_user_mtp_xfer_req(struct osmo_ss7_instance *inst, + struct osmo_mtp_prim *omp); diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index dc9aada..34efcdf 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -80,8 +80,6 @@ ***********************************************************************/ struct osmo_ss7_user; -struct osmo_mtp_prim; - struct osmo_ss7_user *osmo_ss7_user_create(struct osmo_ss7_instance *inst, const char *name); void osmo_ss7_user_destroy(struct osmo_ss7_user *user); @@ -96,10 +94,6 @@ int osmo_ss7_user_unregister(struct osmo_ss7_instance *inst, uint8_t service_ind, struct osmo_ss7_user *user); -/* SS7 User wants to issue MTP-TRANSFER.req */ -int osmo_ss7_user_mtp_xfer_req(struct osmo_ss7_instance *inst, - struct osmo_mtp_prim *omp); - /*********************************************************************** * SCCP Instance -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibdf9be85eed50ede7719a3f5510705f0c82bf7f9 Gerrit-Change-Number: 41406 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025