November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: netif/sctp.h: Add missing dep netinet/sctp.h
by osmith 19 Nov '25

19 Nov '25

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41445?usp=email ) Change subject: netif/sctp.h: Add missing dep netinet/sctp.h ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/netif/sctp.h: https://gerrit.osmocom.org/c/libosmo-netif/+/41445/comment/f0918313_9feb306… : PS1, Line 12: enum sctp_sac_state; maybe remove `enum sctp*` then? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icac109aad6dc5a694309c1aedfe4622b04c44c9c Gerrit-Change-Number: 41445 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Nov 2025 11:55:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: hnb: Avoid calling osmo_sock_get_ip_and_port() with negative fd
by pespin 19 Nov '25

19 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41462?usp=email ) Change subject: hnb: Avoid calling osmo_sock_get_ip_and_port() with negative fd ...................................................................... hnb: Avoid calling osmo_sock_get_ip_and_port() with negative fd Related: Coverity CID#551438 Change-Id: I3ff5d17cd42393893a507718ee191af40bb2499b --- M src/osmo-hnbgw/hnb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/62/41462/1 diff --git a/src/osmo-hnbgw/hnb.c b/src/osmo-hnbgw/hnb.c index bd6b02c..88c64f6 100644 --- a/src/osmo-hnbgw/hnb.c +++ b/src/osmo-hnbgw/hnb.c @@ -132,7 +132,7 @@ int fd = osmo_stream_srv_get_fd(ctx->conn); /* get remote addr */ - if (osmo_sock_get_ip_and_port(fd, hostbuf_r, sizeof(hostbuf_r), portbuf_r, sizeof(portbuf_r), false) == 0) + if (fd >= 0 && osmo_sock_get_ip_and_port(fd, hostbuf_r, sizeof(hostbuf_r), portbuf_r, sizeof(portbuf_r), false) == 0) result = talloc_asprintf(OTC_SELECT, "%s:%s", hostbuf_r, portbuf_r); else result = "?"; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41462?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3ff5d17cd42393893a507718ee191af40bb2499b Gerrit-Change-Number: 41462 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 19 Nov '25

19 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... config: Set pfcp_net_inst_* fields as strings The encoded format is not user friendly at all, since length of each DNS label (subdomain) needs to be encoded in the bytestring. Related: SYS#7734 Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 --- M config/sys.config M src/erab_fsm.erl 2 files changed, 21 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/config/sys.config b/config/sys.config index 920a30e..9ad1ca2 100644 --- a/config/sys.config +++ b/config/sys.config @@ -17,8 +17,8 @@ {pfcp_loc_addr, "127.0.1.1"}, %% local address for incoming PFCP PDUs from the UPF {pfcp_rem_addr, "127.0.1.2"} %% remote address for outgoing PFCP PDUs to the UPF %% Optional PFCP Network Instance IEs (omitted if not configured) -%% {pfcp_net_inst_core, << 16#09, "core-side" >>}, %% PFCP Network Instance IE value (to core) -%% {pfcp_net_inst_access, << 16#0a, "radio-side" >>} %% PFCP Network Instance IE value (to access) +%% {pfcp_net_inst_core, "core-side"}, %% PFCP Network Instance IE value (to core) +%% {pfcp_net_inst_access, "radio-side"} %% PFCP Network Instance IE value (to access) %% %% Optional GTP-U KPI configuration %% {gtpu_kpi_enable, true}, %% whether to enable the GTP-U KPI module (default: false) diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index f5d8efe..49a26ca 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -695,12 +695,30 @@ net_inst_param('Access') -> pfcp_net_inst_access. +%% Encode one DNS label from string format into DNS Name Notation +-spec enc_net_inst_label(string()) -> binary(). +enc_net_inst_label(LabelStr) -> + LabelLen = string:length(LabelStr), + LabelBin = list_to_binary(LabelStr), + << LabelLen:8, LabelBin/binary >>. + + +%% Encode Network Instance IE (3GPP TS 29.244 8.2.4) from string format into DNS Name Notation +%% Example: enc_net_inst("www.foobar.com") -> << 3, 'w', 'w', 'w', 6, 'f', 'o', 'o', 'b', 'a', 'r', 3, 'c', 'o', 'm' >>. +-spec enc_net_inst(string()) -> binary(). +enc_net_inst(FQDN) -> + Labels = string:split(FQDN, ".", all), + LabelsEnc = lists:map(fun enc_net_inst_label/1, Labels), + list_to_binary(LabelsEnc). + + %% if configured, add Network Instance IE (optional) -spec add_net_inst(pfcp_ie(), iface()) -> pfcp_ie(). add_net_inst(IE, Iface) -> Param = net_inst_param(Iface), case application:get_env(osmo_s1gw, Param) of - {ok, NI} -> + {ok, NIStr} -> + NI = enc_net_inst(NIStr), IE#{network_instance => NI}; undefined -> IE -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 19 Nov '25

19 Nov '25

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Nov 2025 11:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: Use pdp->teic_own as rate_ctr id
by pespin 19 Nov '25

19 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... pdpctx: Use pdp->teic_own as rate_ctr id Otherwise we run into errors due to non-unique ids. Related: SYS#7125 Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 --- M src/sgsn/pdpctx.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index 2c3fb03..1fbddab 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -73,7 +73,7 @@ if (!pctx) return NULL; - pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, nsapi); + pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, pdp->teic_own); if (!pctx->ctrg) { LOGPDPCTXP(LOGL_ERROR, pctx, "Error allocation counter group\n"); talloc_free(pctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: Pass pdp_t to sgsn_pdp_ctx_alloc()
by pespin 19 Nov '25

19 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email ) Change subject: Pass pdp_t to sgsn_pdp_ctx_alloc() ...................................................................... Pass pdp_t to sgsn_pdp_ctx_alloc() Refactor sgsn_create_pdp_ctx() to pass the libgtp pdp_t to our pctx. This will be used in follow-up patch to use the teic_own as ID of the rate_ctr. Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 --- M include/osmocom/sgsn/pdpctx.h M src/sgsn/pdpctx.c M src/sgsn/sgsn_libgtp.c 3 files changed, 31 insertions(+), 26 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/sgsn/pdpctx.h b/include/osmocom/sgsn/pdpctx.h index a4bbd97..c6a43de 100644 --- a/include/osmocom/sgsn/pdpctx.h +++ b/include/osmocom/sgsn/pdpctx.h @@ -92,6 +92,7 @@ struct sgsn_pdp_ctx *sgsn_pdp_ctx_alloc(struct sgsn_mm_ctx *mm, struct sgsn_ggsn_ctx *ggsn, + struct pdp_t *pdp, uint8_t nsapi); void sgsn_pdp_ctx_terminate(struct sgsn_pdp_ctx *pdp); void sgsn_pdp_ctx_free(struct sgsn_pdp_ctx *pdp); diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index 7806ada..2c3fb03 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -60,32 +60,40 @@ /* you don't want to use this directly, call sgsn_create_pdp_ctx() */ struct sgsn_pdp_ctx *sgsn_pdp_ctx_alloc(struct sgsn_mm_ctx *mm, struct sgsn_ggsn_ctx *ggsn, + struct pdp_t *pdp, uint8_t nsapi) { - struct sgsn_pdp_ctx *pdp; + struct sgsn_pdp_ctx *pctx; - pdp = sgsn_pdp_ctx_by_nsapi(mm, nsapi); - if (pdp) + pctx = sgsn_pdp_ctx_by_nsapi(mm, nsapi); + if (pctx) return NULL; - pdp = talloc_zero(sgsn, struct sgsn_pdp_ctx); - if (!pdp) + pctx = talloc_zero(sgsn, struct sgsn_pdp_ctx); + if (!pctx) return NULL; - pdp->mm = mm; - pdp->ggsn = ggsn; - pdp->nsapi = nsapi; - pdp->ctrg = rate_ctr_group_alloc(pdp, &pdpctx_ctrg_desc, nsapi); - if (!pdp->ctrg) { - LOGPDPCTXP(LOGL_ERROR, pdp, "Error allocation counter group\n"); - talloc_free(pdp); + pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, nsapi); + if (!pctx->ctrg) { + LOGPDPCTXP(LOGL_ERROR, pctx, "Error allocation counter group\n"); + talloc_free(pctx); return NULL; } - llist_add(&pdp->list, &mm->pdp_list); - sgsn_ggsn_ctx_add_pdp(pdp->ggsn, pdp); - llist_add(&pdp->g_list, &sgsn->pdp_list); - return pdp; + pdp->priv = pctx; + pctx->lib = pdp; + pctx->mm = mm; + pctx->ggsn = ggsn; + pctx->nsapi = nsapi; + + /* Back up our own local TEID in case we update the library one with RNC TEID when setting up Direct Tunnel: */ + pctx->sgsn_teid_own = pdp->teid_own; + + llist_add(&pctx->list, &mm->pdp_list); + sgsn_ggsn_ctx_add_pdp(pctx->ggsn, pctx); + llist_add(&pctx->g_list, &sgsn->pdp_list); + + return pctx; } /* diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index e637967..4021bbc 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -152,12 +152,6 @@ const uint8_t *qos; int rc; - pctx = sgsn_pdp_ctx_alloc(mmctx, ggsn, nsapi); - if (!pctx) { - LOGP(DGPRS, LOGL_ERROR, "Couldn't allocate PDP Ctx\n"); - return NULL; - } - imsi_ui64 = imsi_str2gtp(mmctx->imsi); rc = gtp_pdp_newpdp(ggsn->gsn, &pdp, imsi_ui64, nsapi, NULL); @@ -165,11 +159,13 @@ LOGP(DGPRS, LOGL_ERROR, "Out of libgtp PDP Contexts\n"); return NULL; } - pdp->priv = pctx; - pctx->lib = pdp; - /* Back up our own local TEID in case we update the library one with RNC TEID when setting up Direct Tunnel: */ - pctx->sgsn_teid_own = pdp->teid_own; + pctx = sgsn_pdp_ctx_alloc(mmctx, ggsn, pdp, nsapi); + if (!pctx) { + LOGP(DGPRS, LOGL_ERROR, "Couldn't allocate PDP Ctx\n"); + pdp_freepdp(pdp); + return NULL; + } //pdp->peer = /* sockaddr_in of GGSN (receive) */ //pdp->ipif = /* not used by library */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 Gerrit-Change-Number: 41457 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: vty: Drop SS7 route info in 'show cnlink'
by pespin 19 Nov '25

19 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email ) Change subject: vty: Drop SS7 route info in 'show cnlink' ...................................................................... vty: Drop SS7 route info in 'show cnlink' Route information is nowadays a complex topic which is mostly handled by libosmo-sigtran, and it can be configured and better queried using VTY commands also provided by libosmo-sigtran. This SS7 route information here is not relevant and moreover the API it uses is deprecated. Drop it. Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index f463522..f1b128c 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -125,7 +125,6 @@ static void _show_cnlink(struct vty *vty, struct hnbgw_cnlink *cnlink) { - struct osmo_ss7_route *rt; struct osmo_ss7_instance *ss7; if (!cnlink) { @@ -158,8 +157,6 @@ hnbgw_cnlink_sccp_addr_to_str(cnlink, &cnlink->remote_addr), VTY_NEWLINE); - rt = osmo_ss7_route_lookup(ss7, cnlink->remote_addr.pc); - vty_out(vty, " SS7 route: %s%s", osmo_ss7_route_name(rt, true), VTY_NEWLINE); vty_out(vty, " RANAP state: %s%s", osmo_fsm_inst_state_name(cnlink->fi), VTY_NEWLINE); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 Gerrit-Change-Number: 41451 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by osmith 19 Nov '25

19 Nov '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Nov 2025 07:20:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 3: (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/8e9ff65b_f326… : PS1, Line 714: fun(X)->enc_net_inst_label(X) end > ```suggestion […] Done File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/c97ae609_087d… : PS2, Line 88: bin_fqdn() :: [bin_fqdn_label()]. : > I believe this type spec is wrong and this is making the dialyzer unhappy. […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has uploaded a new patch set (#3) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... config: Set pfcp_net_inst_* fields as strings The encoded format is not user friendly at all, since length of each DNS label (subdomain) needs to be encoded in the bytestring. Related: SYS#7734 Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 --- M config/sys.config M src/erab_fsm.erl 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/61/41461/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025